mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-14 14:40:52 +00:00
fix(proxy): allow same-origin framing of the document serve route
The blanket X-Frame-Options: DENY + frame-ancestors 'none' refused the detail preview's same-origin <iframe>, and the middleware page CSP clobbered whatever the serve route set — the inline PDF preview rendered as a permanent skeleton. Carve out exactly the /original path: SAMEORIGIN framing, frame-ancestors 'self', and a document CSP of default-src 'none'. Deliberately NO sandbox directive and no sandbox attribute on the preview iframe — Chromium force-downloads PDFs in sandboxed documents instead of rendering them (verified against a real Chromium channel; headless test builds ship no PDF viewer at all). The load-bearing boundaries for user-uploaded bytes are unchanged: magic-byte classification at upload, true Content-Type + nosniff at serve, HTML/SVG denied entirely, attachment-only posture for every non-passive format. Tests pin the carve-out and that every neighbouring path keeps the DENY posture. Plan-Task: W2-T3 (preview integration)
This commit is contained in:
1 parent
2b7a6544d6
commit
f9ca7fef79
3 files changed
+127
-5
No files matched your search
@@ -0,0 +1,88 @@
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { NextRequest } from "next/server";
|
||||
|
||||
/**
|
||||
* The document vault's decrypt-and-serve route is framed same-origin by the
|
||||
* detail preview (`<iframe>` for inline-class PDFs). The proxy's blanket
|
||||
* `X-Frame-Options: DENY` + `frame-ancestors 'none'` would refuse that
|
||||
* embed, and the blanket page CSP overrides whatever the route sets
|
||||
* (middleware headers win) — so the proxy carves out EXACTLY the
|
||||
* `/original` path with a same-origin framing posture and a document CSP
|
||||
* (`default-src 'none'`; deliberately no `sandbox` — Chromium
|
||||
* force-downloads sandboxed PDFs instead of rendering them).
|
||||
*
|
||||
* These tests pin both sides of that carve-out: the serve path gets the
|
||||
* narrow posture, and every neighbouring documents API path keeps the full
|
||||
* DENY posture.
|
||||
*/
|
||||
|
||||
vi.mock("@/lib/process-type", () => ({
|
||||
shouldRunWeb: () => true,
|
||||
}));
|
||||
|
||||
import { proxy } from "../proxy";
|
||||
|
||||
function setNodeEnv(value: "development" | "production") {
|
||||
vi.stubEnv("NODE_ENV", value);
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
setNodeEnv("production");
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
vi.unstubAllEnvs();
|
||||
});
|
||||
|
||||
function makeRequest(pathname: string): NextRequest {
|
||||
return new NextRequest(`http://localhost${pathname}`, {
|
||||
headers: { cookie: "healthlog_session=sess-1" },
|
||||
});
|
||||
}
|
||||
|
||||
describe("proxy.ts document serve-route framing carve-out", () => {
|
||||
it("allows same-origin framing on the /original serve path", () => {
|
||||
const res = proxy(makeRequest("/api/documents/inbound/doc123/original"));
|
||||
expect(res.headers.get("x-frame-options")).toBe("SAMEORIGIN");
|
||||
const csp = res.headers.get("content-security-policy") ?? "";
|
||||
expect(csp).toContain("frame-ancestors 'self'");
|
||||
expect(csp).toContain("default-src 'none'");
|
||||
// No `sandbox` directive: Chromium downloads sandboxed PDFs instead of
|
||||
// rendering them, which would break the inline preview outright.
|
||||
expect(csp).not.toMatch(/sandbox/);
|
||||
// No script sources of any kind for a served document.
|
||||
expect(csp).not.toMatch(/script-src/);
|
||||
});
|
||||
|
||||
it("keeps the DENY posture on the documents list route", () => {
|
||||
const res = proxy(makeRequest("/api/documents/inbound"));
|
||||
expect(res.headers.get("x-frame-options")).toBe("DENY");
|
||||
expect(res.headers.get("content-security-policy") ?? "").toContain(
|
||||
"frame-ancestors 'none'",
|
||||
);
|
||||
});
|
||||
|
||||
it("keeps the DENY posture on the document detail route", () => {
|
||||
const res = proxy(makeRequest("/api/documents/inbound/doc123"));
|
||||
expect(res.headers.get("x-frame-options")).toBe("DENY");
|
||||
});
|
||||
|
||||
it("does not match nested or suffixed lookalike paths", () => {
|
||||
for (const path of [
|
||||
"/api/documents/inbound/doc123/original/extra",
|
||||
"/api/documents/inbound/doc123/originalx",
|
||||
"/api/documents/inbound//original",
|
||||
]) {
|
||||
const res = proxy(makeRequest(path));
|
||||
expect(res.headers.get("x-frame-options"), path).toBe("DENY");
|
||||
}
|
||||
});
|
||||
|
||||
it("keeps the DENY posture on app pages, including /documents itself", () => {
|
||||
const res = proxy(makeRequest("/documents"));
|
||||
expect(res.headers.get("x-frame-options")).toBe("DENY");
|
||||
expect(res.headers.get("content-security-policy") ?? "").toContain(
|
||||
"frame-ancestors 'none'",
|
||||
);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user