mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-18 08:02:12 +00:00
chore(release): v1.4.49 — audit-backlog closure + server reminder suppression + diagnostic endpoint + analytics cold-path fix
Bundles the deferred v1.4.47 Mediums + Lows with the v1.4.48-deferred items into a single release. Headline: server-side suppression of MEDICATION_REMINDER APNs for iOS clients that own their local reminders (closes GH #206), a push_attempts table backing /api/admin/notifications/diagnostic, and a sweep of v1.4.48 QA forward-findings. Performance (the user-visible win): - /api/analytics cold-fallback path splits the heavy single-statement aggregate into two parallel queries. The linearly composable columns (count / min / max / mean) keep the full-partition scan; the windowed 7 / 30 / 90-day avg / slope / r² columns take a 90-day outer cap so the planner does an index range scan on (user_id, type, measured_at) instead of a full-partition sequential scan. Output is bit-identical; cold slim slice drops from multi-second to sub-second on tenants with large measurement partitions. Server-side notifications: - GET + PATCH /api/auth/me/notification-prefs with deep-merge semantics. Initial category medication.clientManaged: boolean (default false). Cron medicationReminderJob skips dose-due APNs when the flag is true, emitting a medication_reminder.suppressed_client_managed wide-event annotation per skip. - push_attempts table backs the diagnostic endpoint. Every APNS / Web-Push / Telegram / NTFY sender writes a fire-and-forget row. Daily 03:35 Europe/Berlin cleanup prunes rows older than 90 days. - /api/admin/notifications/diagnostic — admin-only endpoint surfacing device APNs token presence (masked), channel config presence, and recent push attempts. Registered in OpenAPI. - Per-channel APNs "Send test" button now fires with eventType: "MEDICATION_REMINDER" so the dispatcher's time-sensitive + priority-10 branch runs. A successful self-test now exercises the exact path production reminders take; an unsuccessful one points the user at iOS Settings → Time Sensitive Notifications rather than appearing to be a server-side bug. Withings reliability: - OAuth callback consumes the nonce atomically (delete-first with P2025 catch for the replay branch). The previous read-then-delete pattern allowed a race between two concurrent callbacks. - ?reason=state redirect differentiated into csrf1 / replay / expired / cross_user so operators can tell mismatch types apart without DB shell access. - connect endpoint rate-limited to 10/60s/user; row-create failures redirect to a consistent error surface. Observability hardening: - redactSensitiveFields(body) denylist helper covers password / token / secret / apiKey / authorization / csrfState / nonce, recursive, case-insensitive. Caught: /api/devices invalid_format issues were echoing apnsToken values verbatim into the audit log. - sanitiseZodIssues(issues, { stripValuesFromMessage: true }) overload applied to 14 audit-log sites. Migrations: 0079 (notification_prefs), 0080 (push_attempts). Tests: 4815 → 5272 unit + integration. Workout-batch integration suite that had been red on main since v1.4.45 (three release commits shipped through it) now green again — updated to match v1.4.42 cross-source dedup semantics. Resolves PR #207.
This commit is contained in:
1 parent
30ab2112db
commit
f92e644154
87 files changed
+7939
-2950
No files matched your search
@@ -290,9 +290,15 @@ describe("POST /api/workouts/batch (real Postgres)", () => {
|
||||
expect(stored).toBe(0);
|
||||
});
|
||||
|
||||
it("dedupes a re-posted batch into duplicate status without inserting twice", async () => {
|
||||
it("collapses same-instant cross-source twins via write-time dedup, then surfaces re-posts as duplicates", async () => {
|
||||
const { POST } = await import("@/app/api/workouts/batch/route");
|
||||
|
||||
// Two entries share `sportType`, `startedAt`, and `source`. The
|
||||
// v1.4.42 write-time cross-source picker (`dedupeWorkoutBatch`)
|
||||
// groups by `(userId, activityType, startedAt ± 90 s)` and keeps
|
||||
// ONE canonical row — the other lands as `duplicate` BEFORE
|
||||
// reaching the DB. This is the Apple Watch + Withings ScanWatch
|
||||
// case the picker exists to handle.
|
||||
const body = {
|
||||
workouts: [
|
||||
baseWorkout("hk-uuid-dup-1"),
|
||||
@@ -302,8 +308,15 @@ describe("POST /api/workouts/batch (real Postgres)", () => {
|
||||
|
||||
const first = await POST(makeRequest(body));
|
||||
expect(first.status).toBe(200);
|
||||
const firstJson = (await first.json()) as { data: { inserted: number } };
|
||||
expect(firstJson.data.inserted).toBe(2);
|
||||
const firstJson = (await first.json()) as {
|
||||
data: {
|
||||
inserted: number;
|
||||
duplicates: number;
|
||||
entries: Array<{ status: string }>;
|
||||
};
|
||||
};
|
||||
expect(firstJson.data.inserted).toBe(1);
|
||||
expect(firstJson.data.duplicates).toBe(1);
|
||||
|
||||
const second = await POST(makeRequest(body));
|
||||
expect(second.status).toBe(200);
|
||||
@@ -314,6 +327,9 @@ describe("POST /api/workouts/batch (real Postgres)", () => {
|
||||
entries: Array<{ status: string }>;
|
||||
};
|
||||
};
|
||||
// The write-time dedup still fires on the second post (one twin
|
||||
// collapses), and the surviving twin now collides with the row
|
||||
// persisted by the first post — so both end up as `duplicate`.
|
||||
expect(secondJson.data.inserted).toBe(0);
|
||||
expect(secondJson.data.duplicates).toBe(2);
|
||||
expect(secondJson.data.entries.every((e) => e.status === "duplicate")).toBe(
|
||||
@@ -323,7 +339,9 @@ describe("POST /api/workouts/batch (real Postgres)", () => {
|
||||
const stored = await getPrismaClient().workout.count({
|
||||
where: { userId: TEST_USER_ID },
|
||||
});
|
||||
expect(stored).toBe(2);
|
||||
// Only the first-post survivor lives in the DB — write-time dedup
|
||||
// dropped the other twin before any DB write.
|
||||
expect(stored).toBe(1);
|
||||
});
|
||||
|
||||
it("replays a cached response when the same Idempotency-Key is reused", async () => {
|
||||
|
||||
@@ -177,13 +177,17 @@ describe("POST /api/workouts/batch — concurrent-write race", () => {
|
||||
it("two batches with one overlapping externalId resolve to a single DB row each", async () => {
|
||||
const { POST } = await import("@/app/api/workouts/batch/route");
|
||||
|
||||
// Batch A — entries 0..3 unique-to-A plus one shared key.
|
||||
// Batch A — two entries one minute apart plus one shared key. The
|
||||
// v1.4.42 `dedupeWorkoutBatch` picker collapses the minute-1 +
|
||||
// minute-2 pair (same activity, within the 90 s window) to one
|
||||
// surviving row, leaving 2 effective rows per batch.
|
||||
const batchA: WorkoutFixture[] = [
|
||||
workout("hk-uuid-only-a-0", 1),
|
||||
workout("hk-uuid-only-a-1", 2),
|
||||
workout("hk-uuid-shared", 10),
|
||||
];
|
||||
// Batch B — entries 0..3 unique-to-B plus the SAME shared key.
|
||||
// Batch B — same shape, different externalIds for the unique pair
|
||||
// but the SAME shared key.
|
||||
const batchB: WorkoutFixture[] = [
|
||||
workout("hk-uuid-only-b-0", 21),
|
||||
workout("hk-uuid-only-b-1", 22),
|
||||
@@ -202,16 +206,17 @@ describe("POST /api/workouts/batch — concurrent-write race", () => {
|
||||
};
|
||||
const bJson = (await resB.json()) as typeof aJson;
|
||||
|
||||
// Five unique tuples total across both batches; one shared. The
|
||||
// composite unique index means the shared key lands exactly once,
|
||||
// either as A's "inserted" or B's "inserted" — never both. The
|
||||
// sum of the two batches' inserted counts is exactly 5.
|
||||
expect(aJson.data.inserted + bJson.data.inserted).toBe(5);
|
||||
// Three unique tuples land in the DB after write-time dedup + the
|
||||
// composite unique index: one survivor from A's minute-1/2 pair,
|
||||
// one survivor from B's minute-21/22 pair, and one shared-key row
|
||||
// (either as A's "inserted" or B's "inserted" — never both). The
|
||||
// sum of the two batches' inserted counts equals the row count.
|
||||
expect(aJson.data.inserted + bJson.data.inserted).toBe(3);
|
||||
|
||||
const stored = await getPrismaClient().workout.findMany({
|
||||
where: { userId: TEST_USER_ID },
|
||||
});
|
||||
expect(stored).toHaveLength(5);
|
||||
expect(stored).toHaveLength(3);
|
||||
const sharedRows = stored.filter(
|
||||
(r) => r.externalId === "hk-uuid-shared",
|
||||
);
|
||||
|
||||
Reference in new issue
Block a user