fix(privacy): encrypt Coach conversation titles and custom-metric notes at rest

The title of a Coach conversation is the first 80 characters of the
opening message, and the note on a custom-metric reading is free text;
both were stored readable while every other note was encrypted.

Migration 0357 adds coach_conversations.title_encrypted and
custom_metric_entries.note_encrypted (the title loses its NOT NULL) plus
partial indexes on the backfill's discovery predicate. Every writer now
stores ciphertext only: conversation create, proactive nudge, reminder
surfacing, rename, entry create and edit, and both restore formats.
Readers prefer the ciphertext and fall back to the old column for rows
not yet migrated; a ciphertext that does not open throws instead of
falling back. The history title search decrypts in memory, since SQL can
no longer match the title.

free-text-encryption-backfill is a boot-time, idempotent pg-boss job
(staggered past the startup storm, daily discovery tick) that seals each
remaining readable value and nulls it in one transaction per row. A pass
that sees a row twice stops with an error instead of looping.

Both columns are registered for key rotation (registry, CLI script, and
the in-app rotation that walks the registry). A disaster-recovery backup
carries ciphertext only, sealing a not-yet-migrated row on the way out;
a portable export carries readable text. The old columns are marked for
removal in a later release.
This commit is contained in:
Marc-André Bombeck committed 2026-09-26 19:46:01 +02:00
1 parent 4af6b87a2a
commit f7b3ce6ee0
28 files changed
+1735 -83

No files matched your search

+6 -1
View File
@@ -798,6 +798,8 @@ const customMetricEntryBackupSchema = z
unit: z.string().min(1),
measuredAt: isoDateTime,
note: z.string().nullable().default(null),
/// v1.39.3 — the note's ciphertext, DR payloads only.
noteEncrypted: base64BytesSchema.nullable().optional(),
createdAt: isoDateTime.optional(),
/// v1.37.20 (A3-11) — the entry tombstone rides DR payloads so a restore
/// brings the account back exactly as it stood, undo affordance included.
@@ -1365,7 +1367,10 @@ const coachConversationDocumentBackupSchema = z
const coachConversationBackupSchema = z
.object({
id: z.string().min(1),
title: z.string(),
// v1.39.3 — a portable file (and every file written before) carries the
// readable title; a disaster-recovery file carries only the ciphertext.
title: z.string().optional(),
titleEncrypted: base64BytesSchema.optional(),
// NOT optional with a default. The fence is permanent and a file that does
// not state it is a file that cannot be trusted to re-fence the
// conversation, so the absence has to be visible rather than defaulted to