mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-19 00:12:18 +00:00
fix(cycle): gate the calendar grid to a learning state during cold start
The predictions panel suppressed its fertile-window and ovulation rows while fewer than three cycles were observed, but the month calendar did not — so a brand-new user who logged a single period saw the grid paint a confident fertile-window shading, a predicted-ovulation dot, and full phase bands off a population 28/14 prior at ~0.20 confidence. Calendar-based fertility estimation is unreliable below several recorded cycles, so the grid was asserting days it could not know. Thread the same still-learning gate into the calendar build: while fewer than three cycles are observed, suppress the fertile window, the ovulation dot, and the phase band (the predicted-period bar stays, mirroring the panel). Surface a top-level stillLearning flag on the calendar response so the client renders a calm "learning your cycle" banner over the grid instead of a bare, falsely confident calendar. The flag is additive and back-compatible; older clients ignore it and degrade to the previous render. Also pin the observed-cycle count to a single source — the engine's post-exclusion value — so the response never carries two divergent counts.
This commit is contained in:
1 parent
63f398042d
commit
f5798e20d8
13 files changed
+159
-19
No files matched your search
@@ -2,7 +2,7 @@
|
||||
|
||||
import { useMemo, useState } from "react";
|
||||
import { useSearchParams } from "next/navigation";
|
||||
import { Loader2, Plus, RefreshCw } from "lucide-react";
|
||||
import { Loader2, Plus, RefreshCw, Sparkles } from "lucide-react";
|
||||
|
||||
import { Button } from "@/components/ui/button";
|
||||
import { Card, CardContent } from "@/components/ui/card";
|
||||
@@ -274,16 +274,35 @@ export function CycleView() {
|
||||
) : calendarError ? (
|
||||
<TabError onRetry={() => void calendar.refetch()} />
|
||||
) : (
|
||||
<CycleCalendar
|
||||
days={calendar.data?.days ?? []}
|
||||
today={today}
|
||||
confirmedOvulation={
|
||||
calendar.data?.prediction?.ovulationConfirmed
|
||||
? (calendar.data.prediction.predictedOvulation ?? null)
|
||||
: null
|
||||
}
|
||||
onSelectDay={openSheet}
|
||||
/>
|
||||
<>
|
||||
{/* Cold start: the grid carries no fertile/ovulation/phase
|
||||
overlays yet (the server suppresses them while learning),
|
||||
so name the calm state rather than letting a bare grid
|
||||
imply a confident forecast. */}
|
||||
{calendar.data?.stillLearning ? (
|
||||
<div
|
||||
data-slot="cycle-calendar-learning"
|
||||
className="text-muted-foreground bg-muted/40 mb-3 flex items-start gap-2 rounded-lg p-3 text-sm"
|
||||
>
|
||||
<Sparkles
|
||||
className="text-primary mt-0.5 h-4 w-4 shrink-0"
|
||||
aria-hidden="true"
|
||||
/>
|
||||
<span>{t("cycle.calendar.learning")}</span>
|
||||
</div>
|
||||
) : null}
|
||||
<CycleCalendar
|
||||
days={calendar.data?.days ?? []}
|
||||
today={today}
|
||||
confirmedOvulation={
|
||||
calendar.data?.prediction?.ovulationConfirmed
|
||||
? (calendar.data.prediction.predictedOvulation ??
|
||||
null)
|
||||
: null
|
||||
}
|
||||
onSelectDay={openSheet}
|
||||
/>
|
||||
</>
|
||||
)}
|
||||
</CardContent>
|
||||
</Card>
|
||||
|
||||
@@ -68,6 +68,12 @@ export interface CalendarResponse {
|
||||
cyclesObserved: number;
|
||||
};
|
||||
prediction: CyclePrediction | null;
|
||||
/**
|
||||
* Cold-start gate (mirrors `prediction.stillLearning`): true while < 3 cycles
|
||||
* are observed. When set, `days` carries no fertile window, ovulation dot, or
|
||||
* phase band — render the calm "learning your cycle" state over the grid.
|
||||
*/
|
||||
stillLearning: boolean;
|
||||
days: CalendarDay[];
|
||||
meta: { generatedAt: string };
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user