mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-19 00:12:18 +00:00
fix(cycle): gate the calendar grid to a learning state during cold start
The predictions panel suppressed its fertile-window and ovulation rows while fewer than three cycles were observed, but the month calendar did not — so a brand-new user who logged a single period saw the grid paint a confident fertile-window shading, a predicted-ovulation dot, and full phase bands off a population 28/14 prior at ~0.20 confidence. Calendar-based fertility estimation is unreliable below several recorded cycles, so the grid was asserting days it could not know. Thread the same still-learning gate into the calendar build: while fewer than three cycles are observed, suppress the fertile window, the ovulation dot, and the phase band (the predicted-period bar stays, mirroring the panel). Surface a top-level stillLearning flag on the calendar response so the client renders a calm "learning your cycle" banner over the grid instead of a bare, falsely confident calendar. The flag is additive and back-compatible; older clients ignore it and degrade to the previous render. Also pin the observed-cycle count to a single source — the engine's post-exclusion value — so the response never carries two divergent counts.
This commit is contained in:
1 parent
63f398042d
commit
f5798e20d8
13 files changed
+159
-19
No files matched your search
@@ -137,7 +137,7 @@ export const GET = apiHandler(async (request: NextRequest) => {
|
||||
|
||||
const goalAllowsFertile = goalAllowsFertileWindow(profile.goal);
|
||||
|
||||
const { prediction, days } = buildCalendar(
|
||||
const { prediction, stillLearning, days } = buildCalendar(
|
||||
profile,
|
||||
cycles,
|
||||
dayLogs,
|
||||
@@ -179,11 +179,21 @@ export const GET = apiHandler(async (request: NextRequest) => {
|
||||
goal: profile.goal,
|
||||
rawChartMode: profile.rawChartMode,
|
||||
predictionEnabled: profile.predictionEnabled,
|
||||
// Single source of truth for the observed-cycle count: the engine's
|
||||
// post-exclusion `cyclesObserved` (the same number the prediction and the
|
||||
// `stillLearning` gate key off). The raw `cycles.length` fallback only
|
||||
// applies when no prediction ran (raw-chart mode / prediction disabled),
|
||||
// so a consumer never sees two divergent "cycles observed" values.
|
||||
cyclesObserved: prediction?.cyclesObserved ?? cycles.length,
|
||||
},
|
||||
prediction: prediction
|
||||
? toCyclePredictionDTO(prediction, goalAllowsFertile, disclaimer)
|
||||
: null,
|
||||
// Top-level cold-start flag (mirrors `prediction.stillLearning`): the
|
||||
// calendar grid has suppressed fertile/ovulation/phase output, so the
|
||||
// client renders a calm "learning your cycle" banner over the grid. Additive
|
||||
// + back-compatible — older iOS builds ignore the field.
|
||||
stillLearning,
|
||||
days,
|
||||
meta: { generatedAt },
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user