mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 07:13:29 +00:00
feat(measurements): surface that the entry timestamp is editable for backdating
The add form already defaults the timestamp to now and accepts any earlier instant — the plausibility bound and the picker's max both block the future — but many users never notice they can change it. Add a one-line hint under the date/time field so logging a past reading is discoverable, and pin the manual-create contract with a guard asserting the single POST schema strips an externalId (the stats:-prefix overwrite stays batch-scoped).
This commit is contained in:
1 parent
fbdcb31202
commit
f0a14ac0b4
2 files changed
+26
No files matched your search
@@ -206,6 +206,26 @@ describe("measurement validation", () => {
|
||||
expect(parsed.data.deviceType).toBeUndefined();
|
||||
}
|
||||
});
|
||||
|
||||
// v1.17.1 — the `stats:`-prefix overwrite contract is deliberately
|
||||
// batch-scoped. The single manual POST must never accept an
|
||||
// `externalId`, which would open a client-controlled overwrite vector
|
||||
// on the `(userId, type, source, externalId)` unique key. The schema
|
||||
// strips it (no passthrough), so the parsed value never carries one.
|
||||
it("does not surface an externalId on the manual create schema (overwrite contract)", () => {
|
||||
const parsed = createMeasurementSchema.safeParse({
|
||||
...validBase,
|
||||
type: "WEIGHT",
|
||||
value: 82,
|
||||
externalId: "stats:HKQuantityTypeIdentifierBodyMass:2026-04-27",
|
||||
});
|
||||
expect(parsed.success).toBe(true);
|
||||
if (parsed.success) {
|
||||
expect(
|
||||
(parsed.data as Record<string, unknown>).externalId,
|
||||
).toBeUndefined();
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
// v1.4.37 W7c — list-view "one row per day" mode for cumulative
|
||||
|
||||
Reference in new issue
Block a user