mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-18 08:02:12 +00:00
Give the intake toast one decision, and stop admitting two writes nothing calls
Three surfaces record a dose and all three had to reach the same two conclusions inside somebody else's record: name the record, and drop an Undo the server refuses. Two learned it and the dose ledger did not, because the ternary was written out three times. It is written once now, in the file the other two already share, with its own test. POST /api/allergies and POST /api/family-history leave the frozen delegable write set. The argument that admitted them still stands — an allergy is the single most useful thing a caregiver can contribute — but the only surface that posts to either lives in Settings, which a switch closes, so no delegate could reach the form at any level. That is a permission frozen ahead of the caller for it, and the list is built the other way round on purpose. Both delegable READ arms stay. A caregiver reading the allergy list is what the feature is for; only the contribute step waits, and it comes back in the same diff as the surface that offers it.
This commit is contained in:
1 parent
e26a8f3824
commit
ebf032158e
9 files changed
+262
-65
No files matched your search
@@ -3,6 +3,7 @@ import type { QueryClient } from "@tanstack/react-query";
|
||||
|
||||
import { toast } from "sonner";
|
||||
import {
|
||||
intakeToastOptions,
|
||||
runLogIntake,
|
||||
runRecordIntake,
|
||||
runUndoIntake,
|
||||
@@ -475,3 +476,67 @@ describe("runUndoIntake — shared soft-delete", () => {
|
||||
expect(toast.success).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
||||
/**
|
||||
* v1.36.x — the one decision every intake surface shares.
|
||||
*
|
||||
* Three surfaces record a dose and all three showed the same success toast:
|
||||
* the cards, the log-intake dialog, and the dose-history ledger. Two of them
|
||||
* learned to name the record and drop Undo inside somebody else's; the ledger
|
||||
* built its own copy of the ternary and learned neither, so a delegate met a
|
||||
* dead Undo on every dose they marked. This is the copy that is left.
|
||||
*
|
||||
* Whole objects rather than field probes: when one person's record is being
|
||||
* separated from another's, a failure should print what would have been shown
|
||||
* rather than `false !== true`.
|
||||
*
|
||||
* Mutation check, run: making `intakeToastOptions` ignore `recordName` → the
|
||||
* two shared-record legs go red, printing the Undo action they returned.
|
||||
*/
|
||||
describe("intakeToastOptions — the shared toast decision", () => {
|
||||
const onUndo = vi.fn();
|
||||
|
||||
it("carries an Undo in the caller's own record", () => {
|
||||
expect(
|
||||
intakeToastOptions({ recordName: null, eventId: "evt-1", t, onUndo }),
|
||||
).toEqual({
|
||||
action: {
|
||||
label: "medications.intakeUndo",
|
||||
onClick: expect.any(Function),
|
||||
},
|
||||
});
|
||||
});
|
||||
|
||||
it("names the record and offers no Undo inside somebody else's", () => {
|
||||
expect(
|
||||
intakeToastOptions({
|
||||
recordName: "Margarethe",
|
||||
eventId: "evt-1",
|
||||
t,
|
||||
onUndo,
|
||||
}),
|
||||
).toEqual({ description: "recordSharing.toast.savedTo:Margarethe" });
|
||||
});
|
||||
|
||||
it("still names the record when the write returned no event id", () => {
|
||||
// The two arms are not alternatives: the receipt is owed either way, and
|
||||
// an absent event id must not fall through to a bare "Saved".
|
||||
expect(
|
||||
intakeToastOptions({
|
||||
recordName: "Margarethe",
|
||||
eventId: undefined,
|
||||
t,
|
||||
onUndo,
|
||||
}),
|
||||
).toEqual({ description: "recordSharing.toast.savedTo:Margarethe" });
|
||||
});
|
||||
|
||||
it("carries nothing when there is neither a record to name nor an undo", () => {
|
||||
expect(
|
||||
intakeToastOptions({ recordName: null, eventId: undefined, t, onUndo }),
|
||||
).toBeUndefined();
|
||||
expect(
|
||||
intakeToastOptions({ recordName: null, eventId: "evt-1", t }),
|
||||
).toBeUndefined();
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user