mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 07:13:29 +00:00
fix(copy): make delete confirmations, sleep-debt labels, and the glucose band honest
Three surfaces where the words no longer matched the code, plus the missing web control for a preference the server already honours. Delete confirmations. Four dialogs promised permanence on surfaces that render an Undo: the measurements and mood bulk bodies, the lab-result body, and the illness-episode body (which said "cannot be undone" sixty lines below the code that fires the Undo toast). All four now use the same sentence the single-row measurement and mood dialogs already used. A sweep of every other confirmation in the tree found the rest accurate — the biomarker cascade, the mood-tag purge, and the account purge keep their warning because those deletes really are unrecoverable. Sleep debt. v1.19.0 replaced the summed shortfall with a running balance that credits catch-up sleep; the labels still described the old sum, so the word contradicted the number for anyone who slept in after a short night. Corrected in all six locales, plus the places the old semantics had propagated: the Coach system prompt, the OpenAPI field descriptions the native client reads, and four module docblocks. Glucose reference band. `hasDiabetes` selects the tighter reference band and grounds the Coach, but no web surface set it — a web-only account was pinned to the non-diabetic scale with no way out. The control goes on Targets, above the per-metric editor, because it answers the same question that page answers and the two are ordered: it picks the default band, an override below beats it. The copy says what it is — a reference band, not a diagnosis, never inferred from a reading, no clinical action taken on it. The passkey list was reported as always reading "never used". It does not reproduce: the column is selected by the list route and stamped on every verified assertion, both since v1.23.0. Pinned with tests on both halves so the contract cannot quietly regress.
This commit is contained in:
1 parent
b0021a8258
commit
e9d28b399e
21 files changed
+601
-61
No files matched your search
@@ -137,3 +137,43 @@ describe("verifyAuthentication — Zod boundary (L-3)", () => {
|
||||
expect(out.verification.verified).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
/**
|
||||
* "Last used" is a security-page fact people act on: a passkey that reads
|
||||
* "never used" invites deletion. The column is only ever written here, on a
|
||||
* verified assertion, so the stamp and the counter bump must stay one write.
|
||||
* The read half is pinned in
|
||||
* `src/app/api/auth/passkeys/__tests__/route.test.ts`.
|
||||
*/
|
||||
describe("verifyAuthentication — last-used stamp", () => {
|
||||
// The file-level `beforeEach` re-arms the mocks but does not clear their
|
||||
// call history, so the write assertions below need a clean ledger.
|
||||
beforeEach(() => {
|
||||
vi.mocked(prisma.passkey.update).mockClear();
|
||||
});
|
||||
|
||||
it("stamps lastUsedAt alongside the counter on a verified assertion", async () => {
|
||||
const before = Date.now();
|
||||
await verifyAuthentication("ch-1", VALID_BODY);
|
||||
|
||||
expect(prisma.passkey.update).toHaveBeenCalledTimes(1);
|
||||
const call = vi.mocked(prisma.passkey.update).mock.calls[0][0];
|
||||
|
||||
expect(call.where).toEqual({ id: "pk-1" });
|
||||
expect(call.data?.counter).toBe(BigInt(1));
|
||||
|
||||
const stamped = call.data?.lastUsedAt;
|
||||
expect(stamped).toBeInstanceOf(Date);
|
||||
expect((stamped as Date).getTime()).toBeGreaterThanOrEqual(before);
|
||||
});
|
||||
|
||||
it("does not stamp lastUsedAt when the assertion fails", async () => {
|
||||
vi.mocked(verifyAuthenticationResponse).mockResolvedValue({
|
||||
verified: false,
|
||||
} as never);
|
||||
|
||||
await verifyAuthentication("ch-1", VALID_BODY);
|
||||
|
||||
expect(prisma.passkey.update).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user