Merge branch 'feat/v144-settings' into release/v1.44.0

# Conflicts:
#	src/components/settings/privacy-section.tsx

src/lib/modules/__tests__/surface-module-registry.test.ts

@@ -48,6 +48,7 @@ import { NAV_DESTINATIONS } from "@/components/layout/nav-model";
 import { CAPTURE_KIND_ORDER } from "@/components/layout/capture-picker";
 import { SETTINGS_SECTIONS } from "@/components/settings/settings-shell";
 import { LAYOUT_GROUP_IDS } from "@/components/settings/layout-groups";
+import { MODULE_SETTINGS_PAGE_IDS } from "@/components/settings/module-settings-page-ids";
 import {
   DASHBOARD_WIDGET_CATALOGUE_IDS,
   SCORE_RING_IDS,
@@ -160,6 +161,13 @@ describe("every surface id names a surface that exists", () => {
     }
   });
 
+  it("settings-module: a module page under Settings > Modules", () => {
+    const ids = new Set<string>(MODULE_SETTINGS_PAGE_IDS);
+    for (const id of localIds("settings-module")) {
+      expect(ids.has(id), id).toBe(true);
+    }
+  });
+
   it("day-section: a section the day view renders", () => {
     const keys = new Set<string>(DAY_SECTION_KEYS);
     for (const id of localIds("day-section")) {

src/lib/modules/surface.ts

@@ -46,6 +46,7 @@ import type { ModuleKey } from "@/lib/modules/registry";
  *  - `derived`: a derived score, by its `DerivedMetricId`.
  *  - `settings`: a Settings section, by its slug.
  *  - `settings-layout`: a Settings, Layout group, by its id.
+ *  - `settings-module`: a module's own Settings page under Modules, by its id.
  *  - `correlation`: a correlation-discovery channel, by its channel key.
  *  - `score-ring`: a dashboard hero score ring, by its `ScoreRingId`.
  *  - `day-section`: a section of the day view, by its `DaySectionKey`. The
@@ -66,6 +67,7 @@ export const SURFACE_KINDS = [
   "derived",
   "settings",
   "settings-layout",
+  "settings-module",
   "correlation",
   "score-ring",
   "day-section",
@@ -200,11 +202,15 @@ const STATIC_SURFACE_MODULE = {
 
   // ── Settings, Layout groups ──
   "settings-layout:medications": "medications",
-  "settings-layout:mood": "mood",
   "settings-layout:labs": "labs",
   "settings-layout:illness": "illness",
   "settings-layout:documents": "inboundDocuments",
 
+  // ── Settings, a module's own page under Modules ──
+  "settings-module:medications": "medications",
+  "settings-module:mood": "mood",
+  "settings-module:labs": "labs",
+
   // ── Correlation channels ──
   // Rated mood factors (`FACTOR:<key>`) are mood's too; see
   // `correlationChannelSurfaceId`.