fix(settings): answer a switched-off layout subpage with the module notice

/settings/layout/<module> is a URL a person can land on, so with its
module off it now shows the module notice in place, like every module
page, instead of bouncing to the Layout hub without saying why.
This commit is contained in:
Marc-André Bombeck committed 2026-09-24 10:18:04 +02:00
1 parent 5bd19573ea
commit d8dc6ca8a7
2 files changed
+86 -21

No files matched your search

@@ -0,0 +1,57 @@
/**
* `/settings/layout/<module>` is a real URL (a bookmark, the hub's own link,
* a shared screenshot), so with its module off it answers in place with the
* module notice, like every module page, rather than bouncing to the hub.
*/
import { describe, expect, it, vi } from "vitest";
import { renderToStaticMarkup } from "react-dom/server";
const replace = vi.fn();
vi.mock("next/navigation", () => ({
useRouter: () => ({ push: vi.fn(), replace }),
}));
vi.mock("@/hooks/use-mounted", () => ({ useMounted: () => true }));
const userRef: {
value: {
modules: Record<string, boolean>;
moduleAccess?: Record<string, string>;
};
} = { value: { modules: {} } };
vi.mock("@/hooks/use-auth", () => ({
useAuth: () => ({ user: userRef.value }),
}));
import { I18nProvider } from "@/lib/i18n/context";
import { LayoutModuleGate } from "../layout-module-gate";
function render(moduleKey: "mood" | undefined) {
return renderToStaticMarkup(
<I18nProvider initialLocale="en">
<LayoutModuleGate moduleKey={moduleKey}>
<p data-testid="section">section</p>
</LayoutModuleGate>
</I18nProvider>,
);
}
describe("<LayoutModuleGate>", () => {
it("renders the section while its module is on, and always for an unowned group", () => {
userRef.value = { modules: { mood: true } };
expect(render("mood")).toContain('data-testid="section"');
userRef.value = { modules: { mood: false } };
expect(render(undefined)).toContain('data-testid="section"');
});
it("answers in place with the module notice when its module is off, never redirecting", () => {
userRef.value = {
modules: { mood: false },
moduleAccess: { mood: "disabled" },
};
const html = render("mood");
expect(html).not.toContain('data-testid="section"');
expect(html).toContain('data-slot="module-disabled-notice"');
expect(html).toContain('data-module="mood"');
expect(html).toContain('data-slot="module-off-open-settings"');
expect(replace).not.toHaveBeenCalled();
});
});