feat(dashboard): InsightsCardPreview matches insights page visual language

Replaces the orphan v1.4.0 InsightsCard with a leaner
<InsightsCardPreview> that surfaces only the top 1-2 severity-ordered
recommendations + a "View all" CTA pointing to /insights. Same visual
language as the page (Dracula sparkle glyph, severity-coloured left
border, ring-variant confidence meter inline).

The legacy InsightsCard handled its own data fetching against the
deprecated changed/stable/drivers/nextSteps shape; preview now takes
an `insight: InsightResult | null` prop so the dashboard wires its
existing `/api/insights/generate` data without redundant fetches.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Marc-André BombeckandClaude Opus 4.7 committed 2026-05-10 02:05:10 +02:00
1 parent 0c287f1545
commit d2cdf9d664
4 files changed
+251 -153

No files matched your search

+2
View File
@@ -705,6 +705,8 @@
"heroPersonalBaseline": "Basierend auf deinen letzten 90 Tagen", "heroPersonalBaseline": "Basierend auf deinen letzten 90 Tagen",
"heroRegenerate": "Neu generieren", "heroRegenerate": "Neu generieren",
"heroRegenerating": "Wird generiert", "heroRegenerating": "Wird generiert",
"viewAll": "Alle ansehen",
"previewEmpty": "Noch keine Empfehlungen.",
"relativeJustNow": "gerade eben", "relativeJustNow": "gerade eben",
"relativeMinutesAgo": "vor {count} Minuten", "relativeMinutesAgo": "vor {count} Minuten",
"relativeHoursAgo": "vor {count} Stunden", "relativeHoursAgo": "vor {count} Stunden",
+2
View File
@@ -705,6 +705,8 @@
"heroPersonalBaseline": "Based on your last 90 days", "heroPersonalBaseline": "Based on your last 90 days",
"heroRegenerate": "Regenerate", "heroRegenerate": "Regenerate",
"heroRegenerating": "Regenerating", "heroRegenerating": "Regenerating",
"viewAll": "View all",
"previewEmpty": "No recommendations yet.",
"relativeJustNow": "just now", "relativeJustNow": "just now",
"relativeMinutesAgo": "{count} minutes ago", "relativeMinutesAgo": "{count} minutes ago",
"relativeHoursAgo": "{count} hours ago", "relativeHoursAgo": "{count} hours ago",
@@ -0,0 +1,161 @@
import { describe, it, expect, vi } from "vitest";
import { renderToStaticMarkup } from "react-dom/server";
import { I18nProvider } from "@/lib/i18n/context";
import { InsightsCardPreview } from "../insights-card";
import type { InsightResult, InsightRecommendation } from "@/lib/ai/types";
/**
* v1.4.16 phase B1b — dashboard InsightsCard preview.
*
* The preview is a compact wrapper that surfaces the top 1-2
* severity-ordered recommendations + a "View all" CTA pointing to
* the full `/insights` page. Visual language matches the page hero
* + recommendation grid (Dracula tokens, severity-coloured borders,
* mini confidence meter).
*/
vi.mock("@/components/charts/health-chart", () => ({
HealthChart: () => <div data-testid="health-chart-mock" />,
}));
vi.mock("@/components/charts/mood-chart", () => ({
MoodChart: () => <div data-testid="mood-chart-mock" />,
}));
vi.mock("@tanstack/react-query", () => ({
useQuery: () => ({ data: null, isLoading: false }),
useMutation: () => ({
mutate: vi.fn(),
isPending: false,
isSuccess: false,
isError: false,
error: null,
}),
useQueryClient: () => ({ invalidateQueries: vi.fn() }),
}));
vi.mock("@/hooks/use-auth", () => ({
useAuth: () => ({
user: { id: "test-user", username: "tester", role: "USER" },
isAuthenticated: true,
isLoading: false,
}),
}));
function rec(
id: string,
severity: "info" | "suggestion" | "important" | "urgent",
text: string,
confidence?: number,
): InsightRecommendation {
return {
id,
text,
severity,
confidence,
rationale: {
dataWindow: "last7days",
comparedTo: "your 90-day median",
deviation: "moderate deviation",
},
metricSource: {
type: "weight",
timeRange: "last7days",
summary: "84.2 kg avg over 7 days",
},
};
}
function buildInsight(
recommendations: InsightRecommendation[],
): InsightResult {
return {
insightType: "general",
summary: "Test summary",
classification: "gut",
classificationLabel: "Good",
findings: [],
correlations: [],
primaryRecommendation: "",
recommendations,
dataQuality: { coverage: "good", gaps: [], confidence: "hoch" },
disclaimer: "Not medical advice.",
};
}
function render(node: React.ReactNode, locale: "en" | "de" = "en") {
return renderToStaticMarkup(
<I18nProvider initialLocale={locale}>{node}</I18nProvider>,
);
}
describe("<InsightsCardPreview>", () => {
it("surfaces only the top 2 severity-ordered recommendations", () => {
const recs = [
rec("a", "info", "info-rec"),
rec("b", "urgent", "urgent-rec"),
rec("c", "important", "important-rec"),
rec("d", "suggestion", "suggestion-rec"),
];
const html = render(<InsightsCardPreview insight={buildInsight(recs)} />);
expect(html).toContain("urgent-rec");
expect(html).toContain("important-rec");
// The preview must hide the remaining recs — they live on /insights.
expect(html).not.toContain("info-rec");
expect(html).not.toContain("suggestion-rec");
});
it("renders the 'View all' CTA pointing to /insights", () => {
const recs = [rec("a", "urgent", "urgent-rec")];
const html = render(<InsightsCardPreview insight={buildInsight(recs)} />);
expect(html).toMatch(/href="\/insights"/);
expect(html).toMatch(/data-slot="insights-card-view-all"/);
});
it("paints a severity-coloured left border on each preview card", () => {
const recs = [
rec("a", "urgent", "urgent-rec"),
rec("b", "important", "important-rec"),
];
const html = render(<InsightsCardPreview insight={buildInsight(recs)} />);
expect(html).toMatch(/border-l-dracula-red/);
expect(html).toMatch(/border-l-dracula-orange/);
});
it("renders a mini confidence meter inline when confidence is supplied", () => {
const recs = [rec("a", "urgent", "urgent-rec", 78)];
const html = render(<InsightsCardPreview insight={buildInsight(recs)} />);
// The ConfidenceMeter component renders a 'data-slot="confidence-meter"'
// marker; the preview shows the inline ring/bars variant.
expect(html).toMatch(/data-slot="confidence-meter"/);
});
it("hides the preview entirely when there are no recommendations", () => {
const html = render(<InsightsCardPreview insight={buildInsight([])} />);
// The orphan "no recs" state is delegated to the full /insights page.
// The preview either renders the top recs OR doesn't mount at all.
expect(html).toBe("");
});
it("passes a null insight transparently — no preview", () => {
const html = render(<InsightsCardPreview insight={null} />);
expect(html).toBe("");
});
it("renders the title slot so dashboard nav can sit alongside", () => {
const recs = [rec("a", "urgent", "urgent-rec")];
const html = render(<InsightsCardPreview insight={buildInsight(recs)} />);
expect(html).toMatch(/data-slot="insights-card-preview"/);
// Card title text from the existing translation key.
expect(html).toContain("AI Insights");
});
it("German locale — title + view-all CTA translate", () => {
const recs = [rec("a", "urgent", "urgent-rec")];
const html = render(
<InsightsCardPreview insight={buildInsight(recs)} />,
"de",
);
expect(html).toContain("KI-Insights");
// "View all" → German "Alle ansehen"
expect(html).toContain("Alle ansehen");
});
});
+86 -153
View File
@@ -1,184 +1,117 @@
"use client"; "use client";
import { useState } from "react"; import Link from "next/link";
import { useQuery, useMutation, useQueryClient } from "@tanstack/react-query"; import { Sparkles, ArrowRight } from "lucide-react";
import { useAuth } from "@/hooks/use-auth";
import { Button } from "@/components/ui/button";
import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card"; import { Card, CardContent, CardHeader, CardTitle } from "@/components/ui/card";
import { Badge } from "@/components/ui/badge"; import { Button } from "@/components/ui/button";
import { Sparkles, RefreshCw, Loader2, AlertTriangle } from "lucide-react";
import { useTranslations } from "@/lib/i18n/context"; import { useTranslations } from "@/lib/i18n/context";
import type { InsightResult } from "@/lib/ai/types";
import { sortRecommendationsBySeverity } from "./recommendations-grid";
import { ConfidenceMeter } from "./confidence-meter";
interface InsightsOutput { /**
changed: string; * v1.4.16 phase B1b — dashboard <InsightsCardPreview>.
stable: string; *
drivers: string; * Compact preview of the top 1-2 severity-ordered recommendations
nextSteps: string; * + a "View all" CTA pointing at `/insights`. Visual language matches
confidence: "niedrig" | "mittel" | "hoch"; * the page hero (Dracula gradient sparkle, severity-coloured left
limitations: string; * border, mini confidence meter inline) so the dashboard reads as
* a smaller window onto the same surface.
*
* Design notes:
* - The preview is dashboard-anchored, so it doesn't carry the full
* rationale-expand mechanic. Recs render as one-row tiles.
* - When the preview has zero recs OR no insight at all, the
* component returns `null` so the dashboard's parent card grid
* doesn't render an empty box. The full empty-state lives on
* `/insights` proper.
* - The legacy `InsightsCard` (which fetched its own data + rendered
* the v1.4.0 changed/stable/drivers/nextSteps shape) was an
* orphan component with zero non-test imports — it's been replaced
* by this leaner preview.
*/
interface InsightsCardPreviewProps {
insight: InsightResult | null;
/** Maximum number of recs to surface; defaults to 2. */
topN?: number;
} }
interface InsightsResponse { const SEVERITY_BORDER_CLASSES: Record<string, string> = {
insights: InsightsOutput; urgent: "border-l-dracula-red/70",
cached: boolean; important: "border-l-dracula-orange/70",
cachedAt?: string; suggestion: "border-l-dracula-purple/70",
} info: "border-l-dracula-cyan/70",
const CONFIDENCE_COLORS: Record<string, string> = {
niedrig: "bg-orange-500/20 text-orange-400",
mittel: "bg-yellow-500/20 text-yellow-400",
hoch: "bg-green-500/20 text-green-400",
}; };
export function InsightsCard() { const SEVERITY_BORDER_FALLBACK = "border-l-border";
const { isAuthenticated } = useAuth();
const queryClient = useQueryClient(); export function InsightsCardPreview({
insight,
topN = 2,
}: InsightsCardPreviewProps) {
const { t } = useTranslations(); const { t } = useTranslations();
const [error, setError] = useState<string | null>(null); if (!insight || insight.recommendations.length === 0) return null;
// Check if insights are configured const ordered = sortRecommendationsBySeverity(insight.recommendations).slice(
const { data: settings } = useQuery({ 0,
queryKey: ["insights", "settings"], topN,
queryFn: async () => { );
const res = await fetch("/api/insights/settings");
if (!res.ok) return null;
const json = await res.json();
return json.data as {
codexStatus: string;
hasAdminKey: boolean;
privacyMode: string;
lastInsightAt: string | null;
};
},
enabled: isAuthenticated,
});
const generate = useMutation({
mutationFn: async (force: boolean) => {
const res = await fetch("/api/insights/generate", {
method: "POST",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ force }),
});
const json = await res.json();
if (!res.ok) throw new Error(json.error);
return json.data as InsightsResponse;
},
onSuccess: () => {
setError(null);
queryClient.invalidateQueries({ queryKey: ["insights"] });
},
onError: (err: Error) => {
setError(err.message);
},
});
// Don't show if no API key configured
if (!(settings?.codexStatus === "connected" || settings?.hasAdminKey))
return null;
const insights = generate.data?.insights;
return ( return (
<Card> <Card data-slot="insights-card-preview" className="overflow-hidden">
<CardHeader className="pb-3"> <CardHeader className="pb-3">
<div className="flex items-center justify-between"> <div className="flex items-center justify-between">
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">
<Sparkles className="text-dracula-purple h-5 w-5" /> <Sparkles
<CardTitle className="text-lg"> className="text-dracula-purple h-5 w-5"
aria-hidden="true"
/>
<CardTitle className="text-base">
{t("insights.aiInsights")} {t("insights.aiInsights")}
</CardTitle> </CardTitle>
</div> </div>
<Button <Button
asChild
variant="ghost" variant="ghost"
size="sm" size="sm"
onClick={() => generate.mutate(!insights)} data-slot="insights-card-view-all"
disabled={generate.isPending} className="gap-1.5"
> >
{generate.isPending ? ( <Link href="/insights">
<Loader2 className="mr-1 h-3.5 w-3.5 animate-spin" /> {t("insights.viewAll")}
) : ( <ArrowRight className="h-3.5 w-3.5" aria-hidden="true" />
<RefreshCw className="mr-1 h-3.5 w-3.5" /> </Link>
)}
{insights
? t("insights.refreshButton")
: t("insights.generateButton")}
</Button> </Button>
</div> </div>
</CardHeader> </CardHeader>
<CardContent> <CardContent>
{error && ( <ul className="space-y-2">
<div className="bg-destructive/10 text-destructive flex items-center gap-2 rounded-lg p-3 text-sm"> {ordered.map((rec, index) => {
<AlertTriangle className="h-4 w-4 shrink-0" /> const text = typeof rec === "string" ? rec : rec.text;
{error} const severity = typeof rec === "string" ? null : rec.severity;
</div> const confidence =
)} typeof rec === "string" ? undefined : rec.confidence;
const id = typeof rec === "string" ? `${index}-${rec}` : rec.id;
{generate.isPending && !insights && ( const borderClass =
<div className="flex items-center justify-center py-8"> (severity && SEVERITY_BORDER_CLASSES[severity]) ||
<Loader2 className="text-dracula-purple h-6 w-6 animate-spin" /> SEVERITY_BORDER_FALLBACK;
<span className="text-muted-foreground ml-2 text-sm"> return (
{t("insights.analyzing")} <li
</span> key={id ?? index}
</div> className={`bg-card/40 flex items-start justify-between gap-2 rounded-md border-l-2 px-3 py-2 ${borderClass}`}
)} >
<p className="text-sm leading-snug">{text}</p>
{insights && ( {typeof confidence === "number" && (
<div className="space-y-4"> <span className="shrink-0">
<div className="flex items-center gap-2"> <ConfidenceMeter value={confidence} variant="ring" />
<Badge className={CONFIDENCE_COLORS[insights.confidence] ?? ""}> </span>
{t("insights.confidence")}:{" "} )}
{t(`insights.confidence_${insights.confidence}`)} </li>
</Badge> );
{generate.data?.cached && ( })}
<Badge variant="outline" className="text-xs"> </ul>
{t("insights.cached")}
</Badge>
)}
</div>
<Section
title={t("insights.sectionChanged")}
text={insights.changed}
/>
<Section
title={t("insights.sectionStable")}
text={insights.stable}
/>
<Section
title={t("insights.sectionDrivers")}
text={insights.drivers}
/>
<Section
title={t("insights.sectionNextSteps")}
text={insights.nextSteps}
/>
<div className="bg-muted/50 rounded-lg p-3">
<p className="text-muted-foreground text-xs">
<AlertTriangle className="mr-1 inline h-3 w-3" />
{insights.limitations}
</p>
</div>
</div>
)}
{!insights && !generate.isPending && !error && (
<p className="text-muted-foreground py-4 text-center text-sm">
{t("insights.generatePrompt")}
</p>
)}
</CardContent> </CardContent>
</Card> </Card>
); );
} }
function Section({ title, text }: { title: string; text: string }) {
return (
<div>
<h4 className="mb-1 text-sm font-medium">{title}</h4>
<p className="text-muted-foreground text-sm">{text}</p>
</div>
);
}