refactor(v1.4.15): apply simplify-review safe suggestions

Drop dead exports + misleading comments + unreachable defaults flagged
by phase-D simplify review (autonomous-yes items only):

- channel-state: drop unused TEST_CONSTANTS re-export
- retry-policy: drop unused RejectKind type alias
- achievements: drop misleading "fallback" comment on exhaustive switch
- notification-status-card: drop unreachable default in stateBadgeFor
- withings: export isWithingsRefreshReauthFailure + dedupe inline
  classifier in /api/withings/status route
- codex-slug-cache: drop test-only inspectCodexSlugCache helper; tests
  read getCachedCodexSlug() instead

Findings 1, 2, 8, 9 deferred to v1.4.16 (require product call).
Finding 11 is an explicit anti-finding.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Marc-André BombeckandClaude Opus 4.7 committed 2026-05-09 22:14:43 +02:00
1 parent 895c9f3b3a
commit cd3b890067
9 files changed
+11 -51

No files matched your search

@@ -327,7 +327,6 @@ function stateBadgeFor(
icon: <Clock className="h-3 w-3" aria-hidden />,
};
case "manually_disabled":
default:
return {
label: t("settings.notificationStatus.stateManuallyDisabled"),
variant: "secondary",