mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-17 15:42:24 +00:00
Never render a failed read as an absence of data
"No data yet" is a claim about the user's record. Making it when the read failed states something false about their health history. The mental-wellbeing surface was the one that mattered: the assessment history read dropped isError entirely, so a failure left both instrument cards showing "not taken yet" and the detail sheet showing an empty trend. Someone with months of screening results was told, on a mental-health surface, that the results did not exist. It now tells loading, failed and genuinely empty apart, with a retry on the failure. Also swept: - the workouts insights page read isEmpty but not isError, so a failed list read fell through every branch to null and painted a titled shell with nothing in it; - the micronutrients card (not in the original list) rendered its "no nutrient data" empty state on a failed read, while its sibling hydration card already used the shared error card; - the medication detail page and the custom-metric values list showed an honest error with no way out. Both keep retry: false — right for a deleted row, wrong for a transient failure — and gain a user-initiated retry instead, which cannot storm; - /achievements rendered a blank page on a direct hit with the module disabled. It now bounces to /insights like every other gated page. The achievements query error branch, the custom-metric error branch and the chronotype notice were already correct and are left alone.
This commit is contained in:
1 parent
c23f2545cc
commit
c87ce161ba
13 files changed
+330
-53
No files matched your search
@@ -5,6 +5,7 @@ import { Leaf } from "lucide-react";
|
||||
|
||||
import { Card, CardContent, CardHeader } from "@/components/ui/card";
|
||||
import { EmptyState } from "@/components/ui/empty-state";
|
||||
import { QueryErrorCard } from "@/components/ui/query-error-card";
|
||||
import { Skeleton } from "@/components/ui/skeleton";
|
||||
import { TileHeader } from "@/components/insights/tile-header";
|
||||
import { useAuth } from "@/hooks/use-auth";
|
||||
@@ -53,7 +54,11 @@ export function MicronutrientsCard() {
|
||||
const sex =
|
||||
user?.gender === "MALE" || user?.gender === "FEMALE" ? user.gender : null;
|
||||
|
||||
const { data, isLoading } = useQuery({
|
||||
// A failed read left `data` undefined, `rows` empty, and the card rendered
|
||||
// its "no micronutrient data" EmptyState — the same output as an account that
|
||||
// genuinely logs no nutrients. The sibling hydration card already routes
|
||||
// through QueryErrorCard; this one now matches it.
|
||||
const { data, isLoading, isError, refetch } = useQuery({
|
||||
queryKey: queryKeys.nutrientIntake(WINDOW_DAYS),
|
||||
queryFn: () =>
|
||||
apiGet<NutrientIntakeOverview>(`/api/nutrients?days=${WINDOW_DAYS}`),
|
||||
@@ -72,7 +77,12 @@ export function MicronutrientsCard() {
|
||||
<TileHeader icon={Leaf} title={t("nutrients.micronutrients.title")} />
|
||||
</CardHeader>
|
||||
<CardContent className="space-y-3">
|
||||
{isLoading ? (
|
||||
{isError ? (
|
||||
<QueryErrorCard
|
||||
title={t("nutrients.micronutrients.loadError")}
|
||||
onRetry={() => void refetch()}
|
||||
/>
|
||||
) : isLoading ? (
|
||||
<div className="space-y-1" aria-hidden="true">
|
||||
<Skeleton className="h-9 w-full rounded-md" />
|
||||
<Skeleton className="h-9 w-full rounded-md" />
|
||||
|
||||
Reference in new issue
Block a user