From c63e4ded628a8d5c4a75de6dc06bda381b04712e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= <mbombeck@gmail.com>
Date: Sat, 9 May 2026 20:19:47 +0200
Subject: [PATCH] fix(feedback): gate ErrorDetails report-bug button on
 bugReportEnabled
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Follow-up to bde167d — the test landed but the implementation file
was unstaged at commit time (the prior `git add` only picked up the
new test file). This commit applies the actual gating: import
`useAppSettings()` and wrap the `<Button asChild>` in
`{bugReportEnabled && (...)}` so the button disappears when the
admin disables the feature.

Without this, the test in bde167d would have failed for the disabled
branch (the button would still render). Verified locally with `pnpm
test --run src/components/__tests__/error-details.test.tsx` — both
branches green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 src/components/error-details.tsx | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/components/error-details.tsx b/src/components/error-details.tsx
index 47d4409d7..d8b37eb22 100644
--- a/src/components/error-details.tsx
+++ b/src/components/error-details.tsx
@@ -5,6 +5,7 @@ import { Copy, CheckCircle2, RotateCcw, Bug } from "lucide-react";
 import Link from "next/link";
 import { Button } from "@/components/ui/button";
 import { useTranslations } from "@/lib/i18n/context";
+import { useAppSettings } from "@/components/app-settings-provider";
 
 export interface ErrorDetailsProps {
   /** The error object, whether it's a runtime Error or a typed API error. */
@@ -32,6 +33,7 @@ export function ErrorDetails({
   reportHref = "/bugreport",
 }: ErrorDetailsProps) {
   const { t, locale } = useTranslations();
+  const { bugReportEnabled } = useAppSettings();
   const [copied, setCopied] = useState(false);
 
   async function handleCopy() {
@@ -95,12 +97,14 @@ export function ErrorDetails({
           )}
           {copied ? t("common.copied") : t("common.copyDetails")}
         </Button>
-        <Button asChild variant="outline" size="sm">
-          <Link href={reportHref}>
-            <Bug className="mr-2 h-4 w-4" />
-            {t("common.reportIssue")}
-          </Link>
-        </Button>
+        {bugReportEnabled && (
+          <Button asChild variant="outline" size="sm">
+            <Link href={reportHref}>
+              <Bug className="mr-2 h-4 w-4" />
+              {t("common.reportIssue")}
+            </Link>
+          </Button>
+        )}
       </div>
     </div>
   );