From c08dfc618f12e91a3e40a809cf260310ba0503a7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= <mbombeck@gmail.com>
Date: Fri, 2 Oct 2026 22:56:27 +0200
Subject: [PATCH] test(e2e): call a lab review field beside the value when it
 shares its row

The spec compared field tops within 8 px. A field label that wraps onto a
second line, which depends on the runner's font metrics, moves that
field's input down by one line while it stays in the same row, and the
560 px case failed on it. A field is now beside the value when it sits to
its right and starts above the value's bottom edge.
---
 e2e/dialog-horizontal-overflow.spec.ts | 28 +++++++++++++++-----------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/e2e/dialog-horizontal-overflow.spec.ts b/e2e/dialog-horizontal-overflow.spec.ts
index 07b198b23..72d49564f 100644
--- a/e2e/dialog-horizontal-overflow.spec.ts
+++ b/e2e/dialog-horizontal-overflow.spec.ts
@@ -482,20 +482,24 @@ test.describe("lab-scan review dialog uses the width it is given", () => {
 
       // Value, unit and date share a line when the fields have room for three
       // columns, and the date wraps under them when they do not.
+      // "Beside" means the same grid row: to the right of the value and
+      // starting above the value's bottom edge. Comparing the tops alone was
+      // too strict, because a field label that wraps onto a second line (it
+      // depends on the runner's font metrics) moves that field's input down
+      // by one line while it stays in the same row.
+      const besideValue = (field: { x: number; y: number }, name: string) => {
+        expect(field.x, `${label}: ${name} right of value`).toBeGreaterThan(
+          value.x,
+        );
+        expect(field.y, `${label}: ${name} in the value's row`).toBeLessThan(
+          value.y + value.height,
+        );
+      };
       if (vp.threeAcross) {
-        expect(
-          Math.abs(unit.y - value.y),
-          `${label}: unit beside value`,
-        ).toBeLessThan(8);
-        expect(
-          Math.abs(date.y - value.y),
-          `${label}: date beside value`,
-        ).toBeLessThan(8);
+        besideValue(unit, "unit");
+        besideValue(date, "date");
       } else {
-        expect(
-          Math.abs(unit.y - value.y),
-          `${label}: unit beside value`,
-        ).toBeLessThan(8);
+        besideValue(unit, "unit");
         expect(date.y, `${label}: date wraps`).toBeGreaterThan(
           value.y + value.height - 1,
         );