refactor(settings): one header, one action row, one integration card

The sweep that follows from the primitives. Nothing here is new behaviour;
every change removes a second way of saying something the surface already
said one way somewhere else.

Headers. The two collapsible security cards stop rebuilding
`SettingsCardHeader` by hand to carry a chevron — the chevron rides inside
the title button, and the description moves out of the collapsed region, so
the first paint is no longer a bare title. The import card shell, the export
and import section headings, and the four free-standing group headers stop
inventing their own type scale: a heading above a GROUP of cards is
`SectionHeading` (`text-base`), a card title is `SettingsCardHeader`
(`text-lg`), and the step between them is what says which is which. The
targets card gets a title instead of a naked icon.

Actions. Every card-level row is `SettingsCardActions`. The primary action
comes out of the header's status slot in six cards (password, web push,
pillar order, coach memory, and the two danger-zone triggers) and out of the
middle of the card in three more; the reset that hung in the dashboard-layout
header joins save as a secondary in the same row. Result and status lines
move ABOVE the row — sources' cross-link, the invite form's two status lines
— because nothing follows a card's actions. Revoking a share link is
`variant="destructive"` rather than an `outline` hand-tinted red in two
different ways. The import row had four variants for four buttons; it has
two. Export downloads are the card's primary, not an outline link.

Integrations. One description sentence with the setup-guide link inline: the
second paragraph was byte-identical across six of eight cards, which is the
tell that it said nothing about the provider it sat under. The `<hr>` under
the header — which existed only in this folder — is gone. So is the hint that
pointed at a guide 40 px above it, and the second format for "not
configured". Connect is one button everywhere: primary, `sm`, in the action
row, instead of primary-and-small in three cards and outline-and-large in
four.

Plus the standards leftovers the audit listed: two `pl-5` list gutters, one
`scroll-mt-20` anchor, a purple header icon, `text-[10px]` badges, four
hand-rolled callout shells that `SettingsInfoTile` already paints, and the
two inline buttons that never had the mobile tap floor at all.
This commit is contained in:
Marc-André Bombeck committed 2026-08-07 19:39:11 +02:00
1 parent ce9b2814e6
commit b2e1aa0cde
63 files changed
+720 -760

No files matched your search

@@ -64,7 +64,7 @@ function TruncatedCell({
/**
* v1.4.22 W5 reconcile (S-03) — the revoked / isExpired / active
* 3-way ternary is identical between the desktop table and the
* mobile card list; the only difference is `text-xs` vs `text-[10px]`.
* mobile card list; the only difference is `text-xs` vs `text-2xs`.
* Centralise so the two surfaces stay in lock-step.
*/
function TokenStatusBadge({
@@ -77,7 +77,7 @@ function TokenStatusBadge({
const { t } = useTranslations();
const expired =
token.expiresAt != null && new Date(token.expiresAt) < new Date();
const sizeClass = size === "xs" ? "text-[10px]" : "text-xs";
const sizeClass = size === "xs" ? "text-2xs" : "text-xs";
if (token.revoked) {
return (
<Badge variant="destructive" className={`shrink-0 ${sizeClass}`}>
@@ -317,7 +317,7 @@ export function ApiTokenOverviewSection() {
<Badge
key={p}
variant="secondary"
className="max-w-full truncate text-[10px]"
className="text-2xs max-w-full truncate"
title={
p === "*"
? t("admin.tokenPermissionAllTooltip")
+3 -2
View File
@@ -5,6 +5,7 @@ import { useMutation } from "@tanstack/react-query";
import { AlertTriangle, Loader2 } from "lucide-react";
import { toast } from "sonner";
import { SettingsCard } from "@/components/settings/settings-card";
import { SettingsCardActions } from "@/components/settings/_card-actions";
import { SettingsCardHeader } from "@/components/settings/_card-header";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
@@ -130,7 +131,7 @@ export function GlitchtipSection() {
</div>
</div>
<div className="flex justify-end gap-2">
<SettingsCardActions>
<Button
size="sm"
variant="outline"
@@ -152,7 +153,7 @@ export function GlitchtipSection() {
)}
{t("common.save")}
</Button>
</div>
</SettingsCardActions>
</SettingsCard>
);
}
+3 -2
View File
@@ -12,6 +12,7 @@ import {
} from "lucide-react";
import { toast } from "sonner";
import { Badge } from "@/components/ui/badge";
import { SettingsCardActions } from "@/components/settings/_card-actions";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import { Label } from "@/components/ui/label";
@@ -260,7 +261,7 @@ export function RemindersSection() {
</div>
</div>
<div className="flex justify-end gap-2">
<SettingsCardActions>
<Button
size="sm"
variant="outline"
@@ -315,7 +316,7 @@ export function RemindersSection() {
)}
{t("common.save")}
</Button>
</div>
</SettingsCardActions>
{testNotification.data?.results &&
testNotification.data.results.length > 0 && (
+3 -2
View File
@@ -5,6 +5,7 @@ import { useMutation } from "@tanstack/react-query";
import { Activity, Loader2 } from "lucide-react";
import { toast } from "sonner";
import { SettingsCard } from "@/components/settings/settings-card";
import { SettingsCardActions } from "@/components/settings/_card-actions";
import { SettingsCardHeader } from "@/components/settings/_card-header";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
@@ -131,7 +132,7 @@ export function UmamiSection() {
</div>
</div>
<div className="flex justify-end gap-2">
<SettingsCardActions>
<Button
size="sm"
variant="outline"
@@ -153,7 +154,7 @@ export function UmamiSection() {
)}
{t("common.save")}
</Button>
</div>
</SettingsCardActions>
</SettingsCard>
);
}
@@ -5,6 +5,7 @@ import { useQueryClient } from "@tanstack/react-query";
import { toast } from "sonner";
import { BellRing, KeyRound, Loader2 } from "lucide-react";
import { SettingsCard } from "@/components/settings/settings-card";
import { SettingsCardActions } from "@/components/settings/_card-actions";
import { SettingsCardHeader } from "@/components/settings/_card-header";
import { Button } from "@/components/ui/button";
import {
@@ -191,7 +192,7 @@ export function WebPushVapidSection() {
</div>
</div>
<div className="flex justify-end gap-2">
<SettingsCardActions>
<Button
variant="outline"
size="sm"
@@ -217,7 +218,7 @@ export function WebPushVapidSection() {
)}
{t("common.save")}
</Button>
</div>
</SettingsCardActions>
<AlertDialog
open={overwriteConfirmOpen}