chore(v1.22): clear the QA punch-list across Coach, insights, settings

Code-review and design follow-ups before the v1.22 cut. No behaviour change
beyond the items below.

Coach / insights:
- Coach SSE route: a non-provider error raised inside the open producer (e.g. a
  DB failure persisting the reply) now records on the wide event and forwards to
  GlitchTip instead of masquerading as a provider outage; it still surfaces an
  error frame since the stream is open.
- Lab ↔ outcome correlations: hedge faint-tier pairs ("a faint hint, if
  anything … too small to lean on") so the narrated confidence never outruns the
  effect, matching the daily engine.
- Reminder sweep: mint the plan-review reminder and clear the plan's reviewDate
  in one transaction so a half-applied write can't duplicate the reminder.
- Fold the two raw provider-fallback runners onto one shared chain walker.

Design / accessibility:
- Lift sub-44px tap targets to the 44px mobile floor (suggested-action card,
  Coach bubble affordances), brighten the resting timestamp clock for non-text
  contrast, and route the lab chart height through the shared constant.
- Replace ad-hoc arbitrary type sizes with the scale token and static size-11
  icon buttons with the named icon-lg variant.
- Settings: add the missing About card-header descriptions, normalise the
  low-stock numeric widths, and relax the notification-status rows from nested
  cards to a divided list.

Housekeeping:
- Drop three unused exported types (and the now-orphaned source const), re-stamp
  v1.21.5 comments to v1.22, and register the live-judge eval harness as a knip
  entry so the script-only module resolves.
This commit is contained in:
Marc-André Bombeck committed 2026-06-27 16:29:58 +02:00
1 parent ee4fa55c1e
commit b217535b62
40 files changed
+330 -227

No files matched your search

+7 -1
View File
@@ -193,7 +193,12 @@ export function AboutSection() {
which read as a separate field even though the two values belong
on the same row. */}
<SettingsCard>
<SettingsCardHeader icon={Info} title="HealthLog" className="mb-4" />
<SettingsCardHeader
icon={Info}
title="HealthLog"
description={t("settings.about.identityDescription")}
className="mb-4"
/>
{isLoading || !version ? (
<div className="flex items-center gap-2 pl-7">
@@ -266,6 +271,7 @@ export function AboutSection() {
<SettingsCardHeader
icon={BookOpen}
title={t("settings.about.linksHeading")}
description={t("settings.about.linksDescription")}
className="mb-4"
/>
<div className="flex flex-col gap-2 pl-7 sm:flex-row sm:flex-wrap">
@@ -130,7 +130,7 @@ export function PasskeyListSection({
<td className="px-3 py-2 text-xs">
<Badge
variant={pk.credentialBackedUp ? "secondary" : "outline"}
className="text-[11px]"
className="text-xs"
>
{pk.credentialBackedUp
? t("settings.backedUp")
@@ -209,14 +209,14 @@ export function PasskeyListSection({
"Single-device / Multi-device" column. Sits on the
same chip row as the backup status and date so all
metadata reads as a single horizontal stride. */}
<div className="mt-1 flex flex-wrap items-center gap-1.5 text-[11px]">
<Badge variant="outline" className="text-[11px]">
<div className="mt-1 flex flex-wrap items-center gap-1.5 text-xs">
<Badge variant="outline" className="text-xs">
{DEVICE_TYPE_LABELS[pk.credentialDeviceType] ??
pk.credentialDeviceType}
</Badge>
<Badge
variant={pk.credentialBackedUp ? "secondary" : "outline"}
className="text-[11px]"
className="text-xs"
>
{pk.credentialBackedUp
? t("settings.backedUp")
-1
View File
@@ -40,7 +40,6 @@ export interface UserAIProvider {
/** v1.22 (#90) — providers the dedicated document-scan path accepts. */
export const OCR_PROVIDER_TYPES = ["OPENAI", "ANTHROPIC", "LOCAL"] as const;
export type OcrProviderType = (typeof OCR_PROVIDER_TYPES)[number];
/**
* v1.4.16 phase B2 — provider tags exposed to the UI. Mirrors
+2 -2
View File
@@ -232,7 +232,7 @@ export function LowStockCard({
inputMode="numeric"
min={MIN_DAYS}
max={MAX_DAYS}
className="w-24"
className="w-auto"
value={draft ?? String(days)}
disabled={!isAuthenticated || saving}
onChange={(e) => setDraft(e.target.value)}
@@ -263,7 +263,7 @@ export function LowStockCard({
inputMode="numeric"
min={MIN_LEAD}
max={MAX_LEAD}
className="w-24"
className="w-auto"
value={leadDraft ?? String(leadDays)}
disabled={!isAuthenticated || saving}
onChange={(e) => setLeadDraft(e.target.value)}
@@ -148,7 +148,7 @@ export function NotificationStatusCard() {
/>
<ul
className="mt-4 space-y-3 pl-7"
className="divide-border/60 mt-4 divide-y pl-7"
data-testid="notification-status-list"
>
{channels.map((ch) => (
@@ -189,7 +189,7 @@ function ChannelRow({
return (
<li
className="border-border/60 flex flex-col gap-2 rounded-lg border p-4 sm:flex-row sm:items-start sm:justify-between"
className="flex flex-col gap-2 py-4 first:pt-0 last:pb-0 sm:flex-row sm:items-start sm:justify-between"
data-testid={`notification-status-row-${channel.type}`}
data-state={channel.state}
>