mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-18 16:12:11 +00:00
fix(settings): saved source ladders learn about sources added later
A stored per-metric ladder replaced the default wholesale, so a source integrated after the user last saved — WHOOP on a pre-v1.11 sleep ladder, Fitbit on pre-v1.12 ones — never surfaced again: the settings page renders only the stored array and offers reorder, not add, and the picker ranked the invisible source behind everything. The resolver now appends default-ladder sources missing from the stored ladder after the user's explicit order — visible, reorderable, and ranked where the old behaviour already ranked them.
This commit is contained in:
1 parent
c150983dc0
commit
a86c59b77f
2 files changed
+95
-9
No files matched your search
@@ -344,11 +344,29 @@ function buildResolved(
|
||||
deviceTypePriority: DeviceTypePriority,
|
||||
): ResolvedSourcePriority {
|
||||
// Merge: defaults < flat (W5e) < nested (W8c).
|
||||
const merged: Required<MetricPriority> = {
|
||||
const replaced: Required<MetricPriority> = {
|
||||
...DEFAULT_SOURCE_PRIORITY,
|
||||
...flat,
|
||||
...nested,
|
||||
};
|
||||
// v1.16.11 — reconcile every stored ladder against the metric's
|
||||
// default ladder. A stored ladder used to REPLACE the default
|
||||
// wholesale, so a source integrated after the user last saved
|
||||
// (WHOOP on a pre-v1.11 sleep ladder, Fitbit on pre-v1.12 ones)
|
||||
// never surfaced again: the settings UI renders only the stored
|
||||
// array and offers reorder, not add, and the picker ranked the
|
||||
// invisible source last. The user's explicit order stays untouched;
|
||||
// sources the default ladder knows and the stored ladder lacks
|
||||
// append at the end — visible, reorderable, and ranked exactly where
|
||||
// the old behaviour ranked them (after everything ranked).
|
||||
const merged = {} as Required<MetricPriority>;
|
||||
for (const key of Object.keys(replaced) as (keyof MetricPriority)[]) {
|
||||
const stored = replaced[key];
|
||||
const missing = DEFAULT_SOURCE_PRIORITY[key].filter(
|
||||
(source) => !stored.includes(source),
|
||||
);
|
||||
merged[key] = missing.length > 0 ? [...stored, ...missing] : stored;
|
||||
}
|
||||
const resolved: ResolvedSourcePriority = {
|
||||
...merged,
|
||||
metricPriority: merged,
|
||||
|
||||
Reference in new issue
Block a user