mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 23:33:29 +00:00
Tell a first-run what Apple Health is actually doing
Refs #778. Two honesty gaps from the first-run report: the web onboarding presented Apple Health like a web connector although the connection only completes in the iPhone app, and the initial backfill gave no sign of progress, so a working first sync looked broken. The onboarding source step now says plainly that Apple Health is set up in the iPhone app after onboarding, without dead-ending the flow. The integration card gains a server-authoritative progress summary — rows accepted, oldest reading reached, and an honest flowing/waiting line derived from the last accepted batch. Nothing the server does not know is shown: no percentage, no ETA, no invented throttle state; a quiet stretch reads as waiting for the phone, not as an error.
This commit is contained in:
1 parent
b1be67bfa7
commit
a3561b4600
10 files changed
+486
-4
No files matched your search
@@ -112,3 +112,23 @@ describe("<SourceCardGrid> Withings card", () => {
|
||||
expect(html).not.toContain("Connect Withings");
|
||||
});
|
||||
});
|
||||
|
||||
// #778 — the step listed Apple Health next to the web connectors with nothing
|
||||
// saying its setup happens in the iOS app afterwards, so it read like one more
|
||||
// OAuth flow to hunt for.
|
||||
describe("<SourceCardGrid> Apple Health note", () => {
|
||||
it("says Apple Health setup completes in the iPhone app, not on the web", () => {
|
||||
integrationStatusState.data = undefined;
|
||||
const html = render();
|
||||
expect(html).toContain('data-testid="source-more-apple-health-note"');
|
||||
expect(html).toContain("open the HealthLog app on your iPhone");
|
||||
expect(html).toContain("no web connection");
|
||||
});
|
||||
|
||||
it("keeps the Apple Health chip tappable so the note is not a dead end", () => {
|
||||
integrationStatusState.data = undefined;
|
||||
const html = render();
|
||||
expect(html).toContain('data-testid="source-more-apple-health"');
|
||||
expect(html).toContain('href="/settings/integrations"');
|
||||
});
|
||||
});
|
||||
@@ -222,6 +222,18 @@ export function SourceCardGrid() {
|
||||
</li>
|
||||
))}
|
||||
</ul>
|
||||
{/* #778 — Apple Health looked like one more web connector here, but
|
||||
there is nothing to connect on the web: the sync is set up in the
|
||||
iOS app after onboarding. Say so, so nobody hunts Settings for an
|
||||
OAuth flow that does not exist. The chip stays tappable (it lands
|
||||
on the Integrations page, whose Apple Health card walks through
|
||||
the iPhone-app setup) and Next / Skip advance as always. */}
|
||||
<p
|
||||
className="text-muted-foreground text-xs leading-relaxed"
|
||||
data-testid="source-more-apple-health-note"
|
||||
>
|
||||
{t("onboarding.source.more.appleHealthHint")}
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<Link
|
||||
|
||||
Reference in new issue
Block a user