fix(sharing): invitations need a fresh proof and end with sign out everywhere

Offering access to the record took a live session alone, and an
invitation outlives the session that sent it: whoever held a stolen
session could invite their own account and keep a way into the record
after the owner signed everything out. POST /api/account/grants now takes
the recent-proof gate at every level (a sign-in or re-proof within five
minutes on the browser, with the second factor on an account that has one;
a step-up elevation on a token, which no shipped client uses here), and
the invite form opens the re-proof dialog and sends again.

Sign out everywhere now withdraws every invitation the account offered
that nobody has accepted. Accepted grants are left standing on purpose:
each is a person the owner chose, often a carer who still needs the
record, and a sign-out button must not quietly cut them off. The response
lists them as grantsKept and the sessions card shows each with a one-click
End access.
This commit is contained in:
Marc-André Bombeck committed 2026-09-26 22:34:21 +02:00
1 parent a4d27c618e
commit a294d7f684
22 files changed
+585 -65

No files matched your search

@@ -70,15 +70,13 @@ describe("grant invitation lapse date", () => {
),
"utf8",
);
const onError = source.slice(
source.indexOf("onError: (err) => setError"),
source.indexOf(
" );\n };",
source.indexOf("onError: (err) => setError"),
),
);
// The failure arm of the submit: everything from its `catch` to the end
// of the handler.
const start = source.indexOf("} catch (err) {");
expect(start).toBeGreaterThan(-1);
const onError = source.slice(start, source.indexOf("\n };", start));
expect(onError).toContain("setError(t(inviteErrorKey(err)))");
expect(onError).toContain("t(inviteErrorKey(err))");
expect(onError).not.toContain("setIdentifier");
expect(onError).not.toContain("setExpiresOn");
expect(source).toContain('role="alert"');
@@ -18,6 +18,10 @@ import { useModuleEnabled } from "@/hooks/use-module-enabled";
import { ApiError } from "@/lib/api/api-fetch";
import { useTranslations } from "@/lib/i18n/context";
import { useInviteGrant } from "@/lib/queries/use-account-grants";
import {
ReproofCancelledError,
useRecentProof,
} from "@/components/settings/security-section/use-recent-proof";
import { SHARE_DOMAINS, type ShareDomain } from "@/lib/sharing/scope";
import { DEFAULT_TIMEZONE, isValidTimezone } from "@/lib/tz/format";
import { wallClockInTz, zonedWallClockToUtc } from "@/lib/tz/wall-clock";
@@ -79,6 +83,7 @@ import { wallClockInTz, zonedWallClockToUtc } from "@/lib/tz/wall-clock";
export function GrantInviteCard() {
const { t } = useTranslations();
const invite = useInviteGrant();
const recentProof = useRecentProof();
const ownerTimezone = useInvitationOwnerTimezone();
const [identifier, setIdentifier] = useState("");
const [expiresOn, setExpiresOn] = useState("");
@@ -118,31 +123,40 @@ export function GrantInviteCard() {
setError(null);
};
const submit = (event: React.FormEvent) => {
const submit = async (event: React.FormEvent) => {
event.preventDefault();
const value = identifier.trim();
if (value.length === 0 || choice.blocked) return;
setError(null);
setInvited(null);
invite.mutate(
{
identifier: value,
access,
scope: choice.scope,
expiresAt: endOfDayIso(expiresOn, ownerTimezone),
},
{
onSuccess: (grant) => {
setIdentifier("");
setExpiresOn("");
setAccess("READ");
setNarrowed(null);
setSections([]);
setInvited(grant.account.username);
},
onError: (err) => setError(t(inviteErrorKey(err))),
},
);
// Offering access hands somebody a standing way into the record, so the
// server asks for a fresh proof unless the session signed in or re-proved
// within five minutes; the dialog collects it and the invitation is sent
// again.
try {
const grant = await recentProof.run(() =>
invite.mutateAsync({
identifier: value,
access,
scope: choice.scope,
expiresAt: endOfDayIso(expiresOn, ownerTimezone),
}),
);
setIdentifier("");
setExpiresOn("");
setAccess("READ");
setNarrowed(null);
setSections([]);
setInvited(grant.account.username);
} catch (err) {
if (err instanceof ReproofCancelledError) return;
setError(
err instanceof ApiError &&
err.meta?.errorCode === "auth.reproof.sign_in_again"
? err.message
: t(inviteErrorKey(err)),
);
}
};
return (
@@ -159,7 +173,7 @@ export function GrantInviteCard() {
"recordSharing.invite.needsAccount",
)}`}
/>
<form onSubmit={submit} className="space-y-3">
<form onSubmit={(event) => void submit(event)} className="space-y-3">
<div className="space-y-1.5">
<Label htmlFor="grant-invite-identifier">
{t("recordSharing.invite.identifierLabel")}
@@ -373,6 +387,7 @@ export function GrantInviteCard() {
</Button>
</SettingsCardActions>
</form>
{recentProof.dialog}
</SettingsCard>
);
}