mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 15:23:29 +00:00
fix(oura): audit credential deletes and trim integration vestiges
Deleting a user's stored Oura BYO credentials drops a live connection (a token minted against the deleted app is orphaned), but the credentials DELETE route skipped the auditLog + markDisconnected the disconnect route performs, leaving the integration ledger parked at its last state with no audit trail. Mirror the disconnect route when a token was present. Drop two unused classifier type aliases and unexport the internal invalid-grant helper, and refresh the stale 'full OAuth from env' headers on the connect route and the env-credentials helper to the v1.17.1 DB-first framing. Add the missing route tests for the BYO surface this release touched: credentials GET/PUT/DELETE (422 reject, encrypt-on-write, the audit/ledger branch) and the callback CSRF / cross-user / nocreds / success paths.
This commit is contained in:
1 parent
c5e91c4cb6
commit
a0662d1b20
5 files changed
+263
-10
No files matched your search
@@ -0,0 +1,115 @@
|
||||
import { describe, it, expect, vi, beforeEach } from "vitest";
|
||||
|
||||
vi.mock("@/lib/api-handler", () => ({
|
||||
apiHandler: <T extends (...args: unknown[]) => unknown>(fn: T) => fn,
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/db", () => ({
|
||||
prisma: { user: { update: vi.fn() } },
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/auth/session", () => ({ getSession: vi.fn(async () => null) }));
|
||||
|
||||
vi.mock("@/lib/logging/context", () => ({
|
||||
annotate: vi.fn(),
|
||||
getEvent: () => ({ setError: vi.fn(), setAuth: vi.fn() }),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/auth/audit", () => ({ auditLog: vi.fn() }));
|
||||
vi.mock("@/lib/crypto", () => ({ encrypt: (s: string) => `enc:${s}` }));
|
||||
vi.mock("@/lib/integrations/status", () => ({ markReconnected: vi.fn() }));
|
||||
|
||||
const { exchangeMock, getCredsMock, matchMock, verifyMock } = vi.hoisted(() => ({
|
||||
exchangeMock: vi.fn(),
|
||||
getCredsMock: vi.fn(),
|
||||
matchMock: vi.fn(),
|
||||
verifyMock: vi.fn(),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/oura/client", () => ({ exchangeCode: exchangeMock }));
|
||||
vi.mock("@/lib/oura/credentials", () => ({
|
||||
getOuraClientCredentials: getCredsMock,
|
||||
}));
|
||||
vi.mock("@/lib/oauth/signed-state", () => ({
|
||||
oauthStateCookieName: (p: string) => `${p}_state`,
|
||||
stateMatchesCookie: matchMock,
|
||||
verifySignedState: verifyMock,
|
||||
}));
|
||||
|
||||
import { GET } from "../route";
|
||||
import { prisma } from "@/lib/db";
|
||||
import { auditLog } from "@/lib/auth/audit";
|
||||
import { getSession } from "@/lib/auth/session";
|
||||
import type { NextRequest } from "next/server";
|
||||
|
||||
const userUpdate = prisma.user.update as ReturnType<typeof vi.fn>;
|
||||
|
||||
process.env.NEXT_PUBLIC_APP_URL = "https://app.example";
|
||||
|
||||
function makeReq(opts: { code?: string; state?: string; cookie?: string }): NextRequest {
|
||||
const params = new URLSearchParams();
|
||||
if (opts.code) params.set("code", opts.code);
|
||||
if (opts.state) params.set("state", opts.state);
|
||||
return {
|
||||
url: `https://app.example/api/oura/callback?${params}`,
|
||||
cookies: {
|
||||
get: (name: string) =>
|
||||
name === "oura_state" && opts.cookie ? { value: opts.cookie } : undefined,
|
||||
},
|
||||
} as unknown as NextRequest;
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
matchMock.mockReturnValue(true);
|
||||
verifyMock.mockReturnValue({ userId: "u1" });
|
||||
getCredsMock.mockResolvedValue({ clientId: "c", clientSecret: "s" });
|
||||
exchangeMock.mockResolvedValue({ access_token: "at", refresh_token: "rt" });
|
||||
userUpdate.mockResolvedValue({});
|
||||
(getSession as ReturnType<typeof vi.fn>).mockResolvedValue(null);
|
||||
});
|
||||
|
||||
describe("GET /api/oura/callback", () => {
|
||||
it("rejects a cookie/state mismatch as csrf1 before any exchange", async () => {
|
||||
matchMock.mockReturnValue(false);
|
||||
const res = await GET(makeReq({ code: "c", state: "S", cookie: "X" }));
|
||||
expect(res.headers.get("location")).toContain("reason=csrf1");
|
||||
expect(exchangeMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("rejects an unverifiable signed state", async () => {
|
||||
verifyMock.mockReturnValue(null);
|
||||
const res = await GET(makeReq({ code: "c", state: "S", cookie: "S" }));
|
||||
expect(res.headers.get("location")).toContain("reason=state");
|
||||
expect(exchangeMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("rejects when the verified userId mismatches a live session (cross_user)", async () => {
|
||||
(getSession as ReturnType<typeof vi.fn>).mockResolvedValue({
|
||||
user: { id: "attacker" },
|
||||
});
|
||||
const res = await GET(makeReq({ code: "c", state: "S", cookie: "S" }));
|
||||
expect(res.headers.get("location")).toContain("reason=cross_user");
|
||||
expect(exchangeMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("falls back to nocreds when no BYO/env credentials resolve", async () => {
|
||||
getCredsMock.mockResolvedValue(null);
|
||||
const res = await GET(makeReq({ code: "c", state: "S", cookie: "S" }));
|
||||
expect(res.headers.get("location")).toContain("reason=nocreds");
|
||||
expect(exchangeMock).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("exchanges the code, persists encrypted tokens, and audits on success", async () => {
|
||||
const res = await GET(makeReq({ code: "auth-code", state: "S", cookie: "S" }));
|
||||
expect(exchangeMock).toHaveBeenCalledWith("auth-code", {
|
||||
clientId: "c",
|
||||
clientSecret: "s",
|
||||
});
|
||||
const data = userUpdate.mock.calls[0]![0].data;
|
||||
expect(data.ouraAccessTokenEncrypted).toBe("enc:at");
|
||||
expect(data.ouraRefreshTokenEncrypted).toBe("enc:rt");
|
||||
expect(auditLog).toHaveBeenCalledWith("oura.connect", { userId: "u1" });
|
||||
expect(res.headers.get("location")).toContain("oura=connected");
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user