fix(proxy): pin no-store on every session-gated page

The dashboard, Insights, the workouts list, the medications list and the
Coach server-prefetch their data and serialise one account's health record
into the HTML document through a TanStack HydrationBoundary. Those pages
are dynamic today only as a side effect of reading the session cookie —
a property of the page code, not a guarantee. A stray revalidate export, a
force-static segment, or a caching proxy in front of the app would be
enough to retain one account's record and hand it to the next caller.

Stamp `Cache-Control: private, no-store` at the edge instead, driven by the
same predicate that governs the auth redirect, so a page cannot be
session-gated without also being uncacheable. Public legal, auth and
locale-catalog surfaces keep their cacheable posture; API routes keep
managing their own caching.

Two guards: the proxy test pins the header on gated pages and its absence
on the public ones, and a structural test walks the app tree and refuses a
prefetching page that sits on a public path or opts into static /
revalidated rendering.
This commit is contained in:
Marc-André Bombeck committed 2026-07-19 10:59:40 +02:00
1 parent fadd21b3fd
commit 860cb61b0b
3 files changed
+256 -1

No files matched your search

+26 -1
View File
@@ -245,7 +245,11 @@ export function proxy(request: NextRequest) {
const isApiRoute = pathname.startsWith("/api/");
const isStaticFile = /\.\w+$/.test(pathname);
const isPublic = isPublicPath(pathname);
if (!isApiRoute && !isStaticFile && !isPublic) {
// Every page behind the session gate. The same predicate drives the
// auth redirect below and the `no-store` header further down, so a page
// can never be session-gated without also being uncacheable.
const isSessionGatedPage = !isApiRoute && !isStaticFile && !isPublic;
if (isSessionGatedPage) {
const hasSession = request.cookies.has("healthlog_session");
if (!hasSession) {
return NextResponse.redirect(new URL("/auth/login", request.url));
@@ -335,6 +339,27 @@ export function proxy(request: NextRequest) {
// Both serve routes take the narrow, document-only header posture.
const isServeRoute = isDocumentServeRoute || isShareDocumentServeRoute;
// Session-gated pages carry one account's health record in the document
// itself. Several of them server-prefetch their data and serialise it into
// the HTML through a TanStack `HydrationBoundary` — the dashboard, Insights,
// the workouts list, the medications list, the Coach. Those pages are
// dynamic today only as a side effect of reading the session cookie, which
// is a property of the page code, not a guarantee: a stray `revalidate`
// export, a `force-static` segment, or a caching proxy in front of the app
// would be enough to retain one account's record and hand it to the next
// caller. Pin the guarantee at the edge instead, where no page-level change
// can weaken it.
//
// `private` bars shared caches (CDN, reverse proxy) outright; `no-store`
// additionally stops the browser's own disk cache and the bfcache snapshot,
// so a back-navigation after logout cannot repaint the record. The public
// surfaces (`/auth/*`, `/privacy`, `/about`, `/i18n/*`) are excluded by the
// same predicate that governs the auth redirect, so the statically
// rendered marketing/legal pages stay cacheable.
if (isSessionGatedPage) {
response.headers.set("Cache-Control", "private, no-store");
}
// Security headers
response.headers.set("X-Content-Type-Options", "nosniff");
response.headers.set("X-Frame-Options", isServeRoute ? "SAMEORIGIN" : "DENY");