mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 07:13:29 +00:00
refactor(labs): drop the fail-soft lab-note decrypt, which has no caller left
The export was its only user, and the export now reads through a helper that marks an undecryptable note instead of blanking it. Nothing else wanted the silent null: the list DTO never carries the note at all, only `hasNote`, and the single-resource GET has always used the throwing decrypt so a key gap surfaces there. Deleted rather than kept behind a dead-code exemption. A fail-soft twin sitting unused next to a strict one is the exact shape this branch has been clearing out — the next person writing an export reaches for whatever is nearest, and the whole point was that the nearest thing should not silently swallow a row. It had no test of its own, so none was removed; the three comments that pointed at it are rewritten to say what is true now.
This commit is contained in:
1 parent
ae731b92d9
commit
83b1400e5b
4 files changed
+19
-36
No files matched your search
@@ -2627,7 +2627,7 @@ describe("every model the plan claims two-ended survives a real restore", () =>
|
||||
* A note this instance can no longer decrypt leaves the export as a marker,
|
||||
* not as nothing.
|
||||
*
|
||||
* `decryptNoteSoft` answers `null` on a wrong or dropped key, and in a
|
||||
* A fail-soft decrypt answers `null` on a wrong or dropped key, and in a
|
||||
* portable file `null` is byte-for-byte what a note that was never written
|
||||
* looks like. The restore importer then writes no note, so a note the person
|
||||
* did write is gone and no one is told — the whole loss fits inside a
|
||||
|
||||
Reference in new issue
Block a user