mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-17 07:42:23 +00:00
refactor(labs): drop the fail-soft lab-note decrypt, which has no caller left
The export was its only user, and the export now reads through a helper that marks an undecryptable note instead of blanking it. Nothing else wanted the silent null: the list DTO never carries the note at all, only `hasNote`, and the single-resource GET has always used the throwing decrypt so a key gap surfaces there. Deleted rather than kept behind a dead-code exemption. A fail-soft twin sitting unused next to a strict one is the exact shape this branch has been clearing out — the next person writing an export reaches for whatever is nearest, and the whole point was that the nearest thing should not silently swallow a row. It had no test of its own, so none was removed; the three comments that pointed at it are rewritten to say what is true now.
This commit is contained in:
1 parent
ae731b92d9
commit
83b1400e5b
4 files changed
+19
-36
No files matched your search
@@ -50,13 +50,13 @@ export const WORKOUTS_MANIFEST_NOTE =
|
||||
* Decrypt an encrypted free-text column for a portable export, or say plainly
|
||||
* that this one could not be read.
|
||||
*
|
||||
* `decryptNoteSoft` / `decryptContextSoft` answer `null` on a wrong or dropped
|
||||
* key. In a list view that is right — one bad row must not take the page down.
|
||||
* In an export it is not: `null` is exactly what a column that was never
|
||||
* written looks like, so the restore importer writes nothing and a note the
|
||||
* person did write disappears without anyone being told. The Coach transcript
|
||||
* and the doctor report both refuse that trade, one with a placeholder
|
||||
* sentence and one with a rendered flag; this follows the same rule.
|
||||
* A fail-soft decrypt answers `null` on a wrong or dropped key. In a list view
|
||||
* that is right — one bad row must not take the page down. In an export it is
|
||||
* not: `null` is exactly what a column that was never written looks like, so
|
||||
* the restore importer writes nothing and a note the person did write
|
||||
* disappears without anyone being told. The Coach transcript and the doctor
|
||||
* report both refuse that trade, one with a placeholder sentence and one with
|
||||
* a rendered flag; this follows the same rule.
|
||||
*
|
||||
* The warning the soft helpers emitted is kept, so a systemic key gap still
|
||||
* shows up in the wide event rather than only in the file.
|
||||
|
||||
Reference in new issue
Block a user