fix(a11y): close violations the new e2e axe-core sweep surfaced

Five real WCAG 2.1 AA violations the extended axe-core spec caught:

- top-bar.tsx: mobile user-menu DropdownMenuTrigger had no
  accessible name on viewports < sm (the username text is
  `hidden sm:inline`, leaving an icon-only button). Added
  aria-label using the existing nav.userMenu key.
- password-input.tsx: show/hide eye toggle was icon-only, no
  aria-label. Added common.showPassword / common.hidePassword
  in en + de and bound to the visible state.
- auth/login/page.tsx: "Sign up" link relied on colour alone
  (link-in-text-block). Switched hover:underline → underline so
  the link is distinguishable without colour.
- page.tsx (dashboard): "Add" dropdown trigger was 32px tall
  (size="sm"); on Pixel 5 below WCAG 2.5.5 44px threshold.
  Added min-h-11 — desktop visual unchanged because the explicit
  height only kicks in if it exceeds the size variant's h-8.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Marc-André BombeckandClaude Opus 4.7 committed 2026-05-09 16:49:34 +02:00
1 parent ca3c599e7c
commit 7af1f59bb9
6 files changed
+28 -5

No files matched your search

+6 -1
View File
@@ -217,7 +217,12 @@ export default function LoginPage() {
{t("auth.noAccount")}{" "}
<Link
href="/auth/register"
className="text-primary hover:underline"
// axe-core `link-in-text-block` requires a visible
// distinction beyond colour alone (WCAG 1.4.1). Forcing
// the underline always-on instead of `hover:underline`
// satisfies the rule without changing the visual after
// hover.
className="text-primary underline"
>
{t("auth.register")}
</Link>
+5 -1
View File
@@ -363,7 +363,11 @@ export default function DashboardPage() {
</div>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button size="sm">
{/* WCAG 2.5.5 — touch targets must be ≥44×44 CSS px on mobile.
`size="sm"` (h-8 = 32px) was below threshold; the explicit
min-h-11 ensures we hit 44px on the Pixel 5 viewport while
keeping the desktop visual unchanged. */}
<Button size="sm" className="min-h-11">
<Plus className="mr-1 h-4 w-4" />
{t("common.add")}
</Button>