From 793c19e179c86ff84ec12f62b896352997c71f66 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= <mbombeck@gmail.com>
Date: Thu, 8 Oct 2026 18:45:02 +0200
Subject: [PATCH] Keep delete affordances neutral until the confirmation

Row delete buttons, overflow-menu delete items and per-row revoke
buttons painted red in lists, so a list of tokens or shares read as a
wall of alarms. They now sit in the muted tone (foreground on hover)
or as an outline button; the red is kept for the confirmation dialog
that every one of them opens, and for the danger zones, which are a
destructive card-wide action by design.
---
 src/components/admin/invite-tokens-section.tsx                | 4 ++--
 src/components/admin/user-management-section.tsx              | 2 +-
 src/components/cycle/log-day-sheet.tsx                        | 2 +-
 src/components/data-list/delete-button.tsx                    | 2 +-
 src/components/illness/episode-menu.tsx                       | 1 -
 src/components/insights/coach-panel/history-rail.tsx          | 1 -
 src/components/measurement-reminders/vorsorge-section.tsx     | 1 -
 src/components/measurements/measurement-list.tsx              | 1 -
 src/components/medications/dose-history-ledger.tsx            | 1 -
 src/components/medications/medication-categories-sheet.tsx    | 2 +-
 .../medications/scheduling/schedule-history-timeline.tsx      | 2 +-
 src/components/medications/sections/courses-section.tsx       | 2 +-
 src/components/medications/side-effects-section.tsx           | 2 +-
 src/components/medications/wizard/steps/step8-summary.tsx     | 2 +-
 src/components/mood/manage/archived-tags-card.tsx             | 2 +-
 src/components/mood/manage/tag-groups-card.tsx                | 2 +-
 src/components/mood/mood-list.tsx                             | 1 -
 src/components/settings/api-section.tsx                       | 4 ++--
 src/components/settings/coach-reminders-section.tsx           | 2 +-
 src/components/settings/mcp-section.tsx                       | 4 ++--
 .../settings/security-section/passkey-list-section.tsx        | 2 +-
 .../settings/security-section/security-keys-card.tsx          | 2 +-
 src/components/settings/sharing-section.tsx                   | 2 +-
 src/components/symptoms/symptoms-section.tsx                  | 2 --
 src/components/workouts/delete-workout-button.tsx             | 2 +-
 25 files changed, 21 insertions(+), 29 deletions(-)

diff --git a/src/components/admin/invite-tokens-section.tsx b/src/components/admin/invite-tokens-section.tsx
index 9047a519b..024cb742a 100644
--- a/src/components/admin/invite-tokens-section.tsx
+++ b/src/components/admin/invite-tokens-section.tsx
@@ -411,7 +411,7 @@ export function InviteTokensSection() {
                             type="button"
                             variant="ghost"
                             size="sm"
-                            className="text-destructive hover:text-destructive"
+                            className="text-muted-foreground hover:text-foreground"
                             aria-label={t("admin.invites.revokeAria")}
                             disabled={revoke.isPending}
                             onClick={() => setRevokeTarget(invite)}
@@ -479,7 +479,7 @@ export function InviteTokensSection() {
                         type="button"
                         variant="ghost"
                         size="sm"
-                        className="text-destructive hover:text-destructive"
+                        className="text-muted-foreground hover:text-foreground"
                         disabled={revoke.isPending}
                         onClick={() => setRevokeTarget(invite)}
                       >
diff --git a/src/components/admin/user-management-section.tsx b/src/components/admin/user-management-section.tsx
index 696231967..8c2f746c0 100644
--- a/src/components/admin/user-management-section.tsx
+++ b/src/components/admin/user-management-section.tsx
@@ -254,7 +254,7 @@ export function UserManagementSection() {
       <Button
         variant="ghost"
         size="sm"
-        className="text-destructive hover:text-destructive min-h-11 min-w-11 px-2 text-xs"
+        className="text-muted-foreground hover:text-foreground min-h-11 min-w-11 px-2 text-xs"
         onClick={() => setLogoutTarget(u)}
         disabled={u.id === currentUserId}
         title={
diff --git a/src/components/cycle/log-day-sheet.tsx b/src/components/cycle/log-day-sheet.tsx
index b15617d7a..94a273ec6 100644
--- a/src/components/cycle/log-day-sheet.tsx
+++ b/src/components/cycle/log-day-sheet.tsx
@@ -1465,7 +1465,7 @@ export function SymptomRow({
             onClick={() => setConfirmRemove(true)}
             disabled={deleteCustom.isPending}
             aria-label={t("cycle.symptom.custom.remove", { label })}
-            className="text-muted-foreground hover:text-destructive hover:bg-accent focus-visible:ring-ring/50 grid size-11 shrink-0 place-items-center rounded-md transition-colors focus-visible:ring-2 focus-visible:outline-none sm:size-9"
+            className="text-muted-foreground hover:text-foreground hover:bg-accent focus-visible:ring-ring/50 grid size-11 shrink-0 place-items-center rounded-md transition-colors focus-visible:ring-2 focus-visible:outline-none sm:size-9"
           >
             <X className="size-4" aria-hidden="true" />
           </button>
diff --git a/src/components/data-list/delete-button.tsx b/src/components/data-list/delete-button.tsx
index c90311978..6d2f9fbfa 100644
--- a/src/components/data-list/delete-button.tsx
+++ b/src/components/data-list/delete-button.tsx
@@ -73,7 +73,7 @@ export function DeleteButton({
         <Button
           variant="ghost"
           size="icon-lg"
-          className={`text-destructive ${className}`}
+          className={`text-muted-foreground hover:text-foreground ${className}`}
           aria-label={confirmLabel ?? t("common.delete")}
           title={triggerTitle ?? confirmLabel ?? t("common.delete")}
         >
diff --git a/src/components/illness/episode-menu.tsx b/src/components/illness/episode-menu.tsx
index e938f9336..6cfa233c5 100644
--- a/src/components/illness/episode-menu.tsx
+++ b/src/components/illness/episode-menu.tsx
@@ -106,7 +106,6 @@ export function EpisodeMenu({
           ) : null}
           <DropdownMenuSeparator />
           <DropdownMenuItem
-            variant="destructive"
             onSelect={(e) => {
               e.preventDefault();
               setConfirmOpen(true);
diff --git a/src/components/insights/coach-panel/history-rail.tsx b/src/components/insights/coach-panel/history-rail.tsx
index 452ed291c..5cbf68e6c 100644
--- a/src/components/insights/coach-panel/history-rail.tsx
+++ b/src/components/insights/coach-panel/history-rail.tsx
@@ -340,7 +340,6 @@ function HistoryRow({
               {t("insights.coach.frame.rename")}
             </DropdownMenuItem>
             <DropdownMenuItem
-              variant="destructive"
               data-slot="coach-history-delete"
               onSelect={() => onDelete(c.id)}
             >
diff --git a/src/components/measurement-reminders/vorsorge-section.tsx b/src/components/measurement-reminders/vorsorge-section.tsx
index 9a25f2ed9..6a3ad1110 100644
--- a/src/components/measurement-reminders/vorsorge-section.tsx
+++ b/src/components/measurement-reminders/vorsorge-section.tsx
@@ -1002,7 +1002,6 @@ function VorsorgeCard({
         )}
         <DropdownMenuSeparator />
         <DropdownMenuItem
-          variant="destructive"
           disabled={busy}
           onSelect={() => setConfirmDelete(true)}
         >
diff --git a/src/components/measurements/measurement-list.tsx b/src/components/measurements/measurement-list.tsx
index 1521a11f7..71ed9f544 100644
--- a/src/components/measurements/measurement-list.tsx
+++ b/src/components/measurements/measurement-list.tsx
@@ -1770,7 +1770,6 @@ export function MeasurementList({
                       </DropdownMenuTrigger>
                       <DropdownMenuContent align="start">
                         <DropdownMenuItem
-                          variant="destructive"
                           onClick={() => setEditDeleteDialogOpen(true)}
                         >
                           <Trash2 className="mr-2 h-4 w-4" />
diff --git a/src/components/medications/dose-history-ledger.tsx b/src/components/medications/dose-history-ledger.tsx
index deb5eff75..084bf9e2f 100644
--- a/src/components/medications/dose-history-ledger.tsx
+++ b/src/components/medications/dose-history-ledger.tsx
@@ -868,7 +868,6 @@ export function LedgerRowItem({
                   <DropdownMenuSeparator />
                   <DropdownMenuItem
                     onClick={() => onDelete(intake.id as string)}
-                    className="text-destructive focus:text-destructive"
                     data-slot="ledger-delete"
                   >
                     <Trash2 aria-hidden="true" className="mr-2 size-4" />
diff --git a/src/components/medications/medication-categories-sheet.tsx b/src/components/medications/medication-categories-sheet.tsx
index 17c53309f..94d944111 100644
--- a/src/components/medications/medication-categories-sheet.tsx
+++ b/src/components/medications/medication-categories-sheet.tsx
@@ -189,7 +189,7 @@ function CategoryRow({
         type="button"
         variant="ghost"
         size="icon"
-        className="text-destructive hover:text-destructive size-11 sm:size-9"
+        className="text-muted-foreground hover:text-foreground size-11 sm:size-9"
         onClick={() => onDelete(category)}
         aria-label={`${t("medications.category.custom.delete")}: ${category.label}`}
         title={t("medications.category.custom.delete")}
diff --git a/src/components/medications/scheduling/schedule-history-timeline.tsx b/src/components/medications/scheduling/schedule-history-timeline.tsx
index 0e6f04e37..40a402d88 100644
--- a/src/components/medications/scheduling/schedule-history-timeline.tsx
+++ b/src/components/medications/scheduling/schedule-history-timeline.tsx
@@ -239,7 +239,7 @@ export function ScheduleHistoryTimeline({
                         type="button"
                         variant="ghost"
                         size="icon"
-                        className="text-muted-foreground hover:text-destructive size-11 sm:size-8"
+                        className="text-muted-foreground hover:text-foreground size-11 sm:size-8"
                         aria-label={t(
                           "medications.detail.zeitplan.history.deleteAria",
                         )}
diff --git a/src/components/medications/sections/courses-section.tsx b/src/components/medications/sections/courses-section.tsx
index 56fc71fe7..a60d5959e 100644
--- a/src/components/medications/sections/courses-section.tsx
+++ b/src/components/medications/sections/courses-section.tsx
@@ -313,7 +313,7 @@ export function CoursesRow({
                     type="button"
                     variant="ghost"
                     size="icon"
-                    className="text-destructive hover:text-destructive size-11 sm:size-9"
+                    className="text-muted-foreground hover:text-foreground size-11 sm:size-9"
                     onClick={() => setDeleting(course)}
                     aria-label={t("medications.course.delete")}
                     title={t("medications.course.delete")}
diff --git a/src/components/medications/side-effects-section.tsx b/src/components/medications/side-effects-section.tsx
index ee1b71bb9..7df4d2477 100644
--- a/src/components/medications/side-effects-section.tsx
+++ b/src/components/medications/side-effects-section.tsx
@@ -352,7 +352,7 @@ export function SideEffectsSection({ medicationId }: SideEffectsSectionProps) {
                   <Button
                     variant="ghost"
                     size="icon"
-                    className="text-muted-foreground hover:text-destructive size-11 shrink-0"
+                    className="text-muted-foreground hover:text-foreground size-11 shrink-0"
                     aria-label={t("medications.sideEffects.deleteCta")}
                     onClick={() => setPendingDeleteId(row.id)}
                     disabled={deleteMutation.isPending}
diff --git a/src/components/medications/wizard/steps/step8-summary.tsx b/src/components/medications/wizard/steps/step8-summary.tsx
index d4ae10b58..0696d60a4 100644
--- a/src/components/medications/wizard/steps/step8-summary.tsx
+++ b/src/components/medications/wizard/steps/step8-summary.tsx
@@ -121,7 +121,7 @@ export function Step8Summary({
                   type="button"
                   variant="ghost"
                   size="sm"
-                  className="text-muted-foreground hover:text-destructive h-8 gap-1 px-2 text-xs"
+                  className="text-muted-foreground hover:text-foreground h-8 gap-1 px-2 text-xs"
                   onClick={() => onRemoveSchedule(index)}
                   disabled={!canRemove}
                   data-slot="wizard-schedule-remove"
diff --git a/src/components/mood/manage/archived-tags-card.tsx b/src/components/mood/manage/archived-tags-card.tsx
index 989fd401f..b0dd87f86 100644
--- a/src/components/mood/manage/archived-tags-card.tsx
+++ b/src/components/mood/manage/archived-tags-card.tsx
@@ -151,7 +151,7 @@ export function ArchivedTagsCard({ catalog }: ArchivedTagsCardProps) {
                   type="button"
                   variant="ghost"
                   size="icon"
-                  className="text-destructive hover:text-destructive size-11 sm:size-9"
+                  className="text-muted-foreground hover:text-foreground size-11 sm:size-9"
                   onClick={() => setPurgeTag(tag)}
                   aria-label={`${t("mood.manage.purgeAction")} — ${name}`}
                   title={t("mood.manage.purgeAction")}
diff --git a/src/components/mood/manage/tag-groups-card.tsx b/src/components/mood/manage/tag-groups-card.tsx
index 8406992f4..6d16c9c82 100644
--- a/src/components/mood/manage/tag-groups-card.tsx
+++ b/src/components/mood/manage/tag-groups-card.tsx
@@ -494,7 +494,7 @@ function SortableGroupRow({
               <Pencil className="mr-2 h-4 w-4" />
               {t("common.edit")}
             </DropdownMenuItem>
-            <DropdownMenuItem variant="destructive" onClick={onDelete}>
+            <DropdownMenuItem onClick={onDelete}>
               <Trash2 className="mr-2 h-4 w-4" />
               {t("common.delete")}
             </DropdownMenuItem>
diff --git a/src/components/mood/mood-list.tsx b/src/components/mood/mood-list.tsx
index 238292f77..21e1badb9 100644
--- a/src/components/mood/mood-list.tsx
+++ b/src/components/mood/mood-list.tsx
@@ -1196,7 +1196,6 @@ export function MoodList({ onAddFirst }: MoodListProps = {}) {
                       </DropdownMenuTrigger>
                       <DropdownMenuContent align="start">
                         <DropdownMenuItem
-                          variant="destructive"
                           onClick={() => setEditDeleteDialogOpen(true)}
                         >
                           <Trash2 className="mr-2 h-4 w-4" />
diff --git a/src/components/settings/api-section.tsx b/src/components/settings/api-section.tsx
index 16d1afff2..c73749b12 100644
--- a/src/components/settings/api-section.tsx
+++ b/src/components/settings/api-section.tsx
@@ -579,7 +579,7 @@ function ApiTokensCard() {
                                 <Button
                                   variant="ghost"
                                   size="icon"
-                                  className="text-destructive h-9 w-9"
+                                  className="text-muted-foreground hover:text-foreground h-9 w-9"
                                   aria-label={t("settings.tokenRevokeAction")}
                                 >
                                   <Trash2 className="h-3.5 w-3.5" />
@@ -676,7 +676,7 @@ function ApiTokensCard() {
                         <AlertDialog>
                           <AlertDialogTrigger asChild>
                             <Button
-                              variant="destructive"
+                              variant="outline"
                               size="sm"
                               className="min-h-11 w-full"
                             >
diff --git a/src/components/settings/coach-reminders-section.tsx b/src/components/settings/coach-reminders-section.tsx
index 27b01e0f1..4156eac5c 100644
--- a/src/components/settings/coach-reminders-section.tsx
+++ b/src/components/settings/coach-reminders-section.tsx
@@ -149,7 +149,7 @@ export function CoachRemindersSection({
             slot="coach-reminder-delete"
             variant="ghost"
             size="sm"
-            className="text-muted-foreground hover:text-destructive min-h-9"
+            className="text-muted-foreground hover:text-foreground min-h-9"
             disabled={!isAuthenticated}
             pending={busy}
             ariaLabel={t("settings.ai.coachReminders.deleteAria")}
diff --git a/src/components/settings/mcp-section.tsx b/src/components/settings/mcp-section.tsx
index 87d5dafc7..75ec5efc9 100644
--- a/src/components/settings/mcp-section.tsx
+++ b/src/components/settings/mcp-section.tsx
@@ -165,7 +165,7 @@ function McpConnectionsCard() {
                 <AlertDialog>
                   <AlertDialogTrigger asChild>
                     <Button
-                      variant="destructive"
+                      variant="outline"
                       size="sm"
                       className="min-h-11 w-full"
                     >
@@ -506,7 +506,7 @@ function McpTokensCard() {
                     <AlertDialog>
                       <AlertDialogTrigger asChild>
                         <Button
-                          variant="destructive"
+                          variant="outline"
                           size="sm"
                           className="min-h-11 w-full"
                         >
diff --git a/src/components/settings/security-section/passkey-list-section.tsx b/src/components/settings/security-section/passkey-list-section.tsx
index ed6cd4b7b..94fa4b4cf 100644
--- a/src/components/settings/security-section/passkey-list-section.tsx
+++ b/src/components/settings/security-section/passkey-list-section.tsx
@@ -299,7 +299,7 @@ export function PasskeyListSection({
                             type="button"
                             variant="ghost"
                             size="icon"
-                            className="text-destructive min-h-11 min-w-11 sm:h-8 sm:min-h-0 sm:w-8 sm:min-w-0"
+                            className="text-muted-foreground hover:text-foreground min-h-11 min-w-11 sm:h-8 sm:min-h-0 sm:w-8 sm:min-w-0"
                             disabled={remove.isPending}
                             aria-label={t("settings.deletePasskey")}
                           >
diff --git a/src/components/settings/security-section/security-keys-card.tsx b/src/components/settings/security-section/security-keys-card.tsx
index 7dcb374f2..9d487d5b0 100644
--- a/src/components/settings/security-section/security-keys-card.tsx
+++ b/src/components/settings/security-section/security-keys-card.tsx
@@ -293,7 +293,7 @@ export function SecurityKeysCard({
                             type="button"
                             variant="ghost"
                             size="icon"
-                            className="text-destructive min-h-11 min-w-11 sm:h-8 sm:min-h-0 sm:w-8 sm:min-w-0"
+                            className="text-muted-foreground hover:text-foreground min-h-11 min-w-11 sm:h-8 sm:min-h-0 sm:w-8 sm:min-w-0"
                             disabled={remove.isPending}
                             aria-label={t("settings.security.keys.remove")}
                           >
diff --git a/src/components/settings/sharing-section.tsx b/src/components/settings/sharing-section.tsx
index c05674421..c39fe0b96 100644
--- a/src/components/settings/sharing-section.tsx
+++ b/src/components/settings/sharing-section.tsx
@@ -242,7 +242,7 @@ function ShareLinksCard() {
                     <AlertDialog>
                       <AlertDialogTrigger asChild>
                         <Button
-                          variant="destructive"
+                          variant="outline"
                           size="sm"
                           className="ml-auto flex min-h-11 w-fit sm:min-h-9"
                         >
diff --git a/src/components/symptoms/symptoms-section.tsx b/src/components/symptoms/symptoms-section.tsx
index 6807ca848..17fd7b0ef 100644
--- a/src/components/symptoms/symptoms-section.tsx
+++ b/src/components/symptoms/symptoms-section.tsx
@@ -223,7 +223,6 @@ function DefinitionMenu({
           </DropdownMenuItem>
           <DropdownMenuSeparator />
           <DropdownMenuItem
-            variant="destructive"
             onSelect={(e) => {
               e.preventDefault();
               setConfirmOpen(true);
@@ -301,7 +300,6 @@ export function SymptomEventMenu({
           </DropdownMenuItem>
           <DropdownMenuSeparator />
           <DropdownMenuItem
-            variant="destructive"
             onSelect={(e) => {
               e.preventDefault();
               setConfirmOpen(true);
diff --git a/src/components/workouts/delete-workout-button.tsx b/src/components/workouts/delete-workout-button.tsx
index 904ea6280..adfdcb303 100644
--- a/src/components/workouts/delete-workout-button.tsx
+++ b/src/components/workouts/delete-workout-button.tsx
@@ -99,7 +99,7 @@ export function DeleteWorkoutButton({
         title={t("insights.workouts.manual.deleteLabel")}
         onClick={() => setOpen(true)}
         className={cn(
-          "text-muted-foreground hover:text-destructive relative size-10",
+          "text-muted-foreground hover:text-foreground relative size-10",
           "before:absolute before:-inset-1.5 before:content-['']",
         )}
       >