Merge main — the test-infrastructure fixes from the shared suite

Brings in the truncate retry, the socket fix for the record-fence spec that
failed this branch's second e2e shard, and the corrected absence assertions.

src/__tests__/integration-truncate-deadlock-retry.test.ts

@@ -0,0 +1,63 @@
+/**
+ * The integration suite wipes the database between files with one
+ * `TRUNCATE`, which needs the strictest lock on every table at once. The
+ * server writes in thirty-nine places without awaiting the result, so one of
+ * those can land after the test that caused it has returned and take the
+ * truncate down with a deadlock. Postgres picks a victim; ours was an
+ * unrelated file, twice in two days, green on the rerun both times.
+ *
+ * The helper retries that one error now. These cases hold it to exactly that:
+ * it gives up on anything else immediately, and it does not retry forever.
+ */
+import { describe, expect, it, vi } from "vitest";
+
+import { truncateAllTables } from "../../tests/integration/setup";
+
+function deadlock(): Error & { code: string } {
+  const error = new Error("deadlock detected") as Error & { code: string };
+  error.code = "40P01";
+  return error;
+}
+
+function fakeClient(executeRaw: ReturnType<typeof vi.fn>) {
+  const empty = vi.fn().mockResolvedValue([]);
+  return {
+    $executeRawUnsafe: executeRaw,
+    moodTag: { findMany: empty, createMany: vi.fn() },
+    moodTagCategory: { findMany: empty, createMany: vi.fn() },
+  } as unknown as Parameters<typeof truncateAllTables>[0];
+}
+
+describe("truncateAllTables", () => {
+  it("retries a deadlocked truncate and succeeds once the lock clears", async () => {
+    const executeRaw = vi
+      .fn()
+      .mockRejectedValueOnce(deadlock())
+      .mockRejectedValueOnce(deadlock())
+      .mockResolvedValue(0);
+
+    await truncateAllTables(fakeClient(executeRaw));
+
+    expect(executeRaw).toHaveBeenCalledTimes(3);
+  });
+
+  it("gives up on an error that is not a deadlock, on the first attempt", async () => {
+    const other = new Error("permission denied") as Error & { code: string };
+    other.code = "42501";
+    const executeRaw = vi.fn().mockRejectedValue(other);
+
+    await expect(truncateAllTables(fakeClient(executeRaw))).rejects.toThrow(
+      "permission denied",
+    );
+    expect(executeRaw).toHaveBeenCalledTimes(1);
+  });
+
+  it("stops retrying a deadlock that never clears", async () => {
+    const executeRaw = vi.fn().mockRejectedValue(deadlock());
+
+    await expect(truncateAllTables(fakeClient(executeRaw))).rejects.toThrow(
+      "deadlock detected",
+    );
+    expect(executeRaw).toHaveBeenCalledTimes(5);
+  });
+});

src/lib/openapi/routes/coach.ts

@@ -1604,7 +1604,7 @@ export const coachPaths: NonNullable<ZodOpenApiObject["paths"]> = {
       tags: ["Insights"],
       summary: "List the caller's Coach goal / if-then plans",
       description:
-        'v1.21.3 (B1) — returns the durable plans the Coach has proposed for the caller, newest first, each decrypted on the fly. A plan is an "if-then" implementation intention tied to one metric, with an optional target. The Coach extractor writes a plan as `proposed`; only `PATCH /api/coach/plans/{id}` activates it. Pass `?status=` to filter to one lifecycle status, or `?scope=` for a named group (open = proposed + active + review_due, past = met + abandoned + reviewed, all = every non-deleted plan) — mutually exclusive. Both omitted returns the non-terminal set (proposed + active). Coach-gated (`requireModuleEnabled("coach")`); a disabled surface 403s. Auth via cookie or Bearer; the owner is always narrowed from the session, never the body. Undecryptable rows are omitted rather than failing the read.',
+        'v1.21.3 — returns the durable plans the Coach has proposed for the caller, newest first, each decrypted on the fly. A plan is an "if-then" implementation intention tied to one metric, with an optional target. The Coach extractor writes a plan as `proposed`; only `PATCH /api/coach/plans/{id}` activates it. Pass `?status=` to filter to one lifecycle status, or `?scope=` for a named group (open = proposed + active + review_due, past = met + abandoned + reviewed, all = every non-deleted plan) — mutually exclusive. Both omitted returns the non-terminal set (proposed + active). Coach-gated (`requireModuleEnabled("coach")`); a disabled surface 403s. Auth via cookie or Bearer; the owner is always narrowed from the session, never the body. Undecryptable rows are omitted rather than failing the read.',
       parameters: [
         {
           name: "status",
@@ -1645,7 +1645,7 @@ export const coachPaths: NonNullable<ZodOpenApiObject["paths"]> = {
       tags: ["Insights"],
       summary: "Confirm or update a Coach plan's lifecycle",
       description:
-        "v1.21.3 (B1) — confirm a proposed plan (status proposed → active) or mark it met / abandoned, and optionally set / clear a review date. The body carries ONLY lifecycle fields — never the metric or the encrypted free text — so a client can change a plan's status but never inject or overwrite its prose. A foreign / unknown / already-deleted id maps to 404 (never 403) so the existence channel does not leak across accounts. Coach-gated. Auth via cookie or Bearer; the owner is narrowed from the session.",
+        "v1.21.3 — confirm a proposed plan (status proposed → active) or mark it met / abandoned, and optionally set / clear a review date. The body carries ONLY lifecycle fields — never the metric or the encrypted free text — so a client can change a plan's status but never inject or overwrite its prose. A foreign / unknown / already-deleted id maps to 404 (never 403) so the existence channel does not leak across accounts. Coach-gated. Auth via cookie or Bearer; the owner is narrowed from the session.",
       parameters: [
         {
           name: "id",
@@ -1688,7 +1688,7 @@ export const coachPaths: NonNullable<ZodOpenApiObject["paths"]> = {
       tags: ["Insights"],
       summary: "Soft-delete one Coach plan",
       description:
-        "v1.21.3 (B1) — soft-deletes a single plan owned by the caller. An unknown / cross-user / already-deleted id is an idempotent no-op returning `{ deleted: false }`, never revealing whether the id exists under another account. Coach-gated. Auth via cookie or Bearer.",
+        "v1.21.3 — soft-deletes a single plan owned by the caller. An unknown / cross-user / already-deleted id is an idempotent no-op returning `{ deleted: false }`, never revealing whether the id exists under another account. Coach-gated. Auth via cookie or Bearer.",
       parameters: [
         {
           name: "id",
@@ -1760,7 +1760,7 @@ export const coachReminderPaths: NonNullable<ZodOpenApiObject["paths"]> = {
       tags: ["Insights"],
       summary: "Create a Coach reminder manually",
       description:
-        "v1.22 (B6) — create a reminder from the ledger. `note` is the only writable content; `when` is the closed grammar (ISO date | +Nd / +Nw | a context cue) resolved into the trigger server-side; `metric` optional. The per-user cap returns 409 when the non-terminal set is full. Coach-gated. Auth via cookie or Bearer; the owner is narrowed from the session.",
+        "v1.22 — create a reminder from the ledger. `note` is the only writable content; `when` is the closed grammar (ISO date | +Nd / +Nw | a context cue) resolved into the trigger server-side; `metric` optional. The per-user cap returns 409 when the non-terminal set is full. Coach-gated. Auth via cookie or Bearer; the owner is narrowed from the session.",
       requestBody: {
         required: true,
         content: {
@@ -1796,7 +1796,7 @@ export const coachReminderPaths: NonNullable<ZodOpenApiObject["paths"]> = {
       tags: ["Insights"],
       summary: "Confirm or update a Coach reminder's lifecycle",
       description:
-        "v1.22 (B6) — confirm a proposed reminder (→ active), mark it done / dismissed, or re-schedule via the closed `when` grammar (null clears the due moment). The body never carries the note text. A foreign / unknown / already-deleted id maps to 404 (never 403) so the existence channel does not leak. Coach-gated. Auth via cookie or Bearer.",
+        "v1.22 — confirm a proposed reminder (→ active), mark it done / dismissed, or re-schedule via the closed `when` grammar (null clears the due moment). The body never carries the note text. A foreign / unknown / already-deleted id maps to 404 (never 403) so the existence channel does not leak. Coach-gated. Auth via cookie or Bearer.",
       parameters: [
         {
           name: "id",
@@ -1839,7 +1839,7 @@ export const coachReminderPaths: NonNullable<ZodOpenApiObject["paths"]> = {
       tags: ["Insights"],
       summary: "Soft-delete one Coach reminder",
       description:
-        "v1.22 (B6) — soft-deletes a single reminder owned by the caller. An unknown / cross-user / already-deleted id is an idempotent no-op returning `{ deleted: false }`. Coach-gated. Auth via cookie or Bearer.",
+        "v1.22 — soft-deletes a single reminder owned by the caller. An unknown / cross-user / already-deleted id is an idempotent no-op returning `{ deleted: false }`. Coach-gated. Auth via cookie or Bearer.",
       parameters: [
         {
           name: "id",