From 7363bcd5d375b8f91b0a4147aaf3b55cc203f511 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= Date: Thu, 22 Oct 2026 14:16:08 +0200 Subject: [PATCH] ci(e2e): trust the checkout in the WebKit container; measure the day button once it settles --- .github/workflows/e2e.yml | 5 ++++- e2e/day-doors.spec.ts | 8 ++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index cc008d5ce..e791a08d6 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -180,11 +180,14 @@ jobs: AUTH_RP_ORIGIN: http://localhost:3000 SESSION_COOKIE_SECURE: "false" NODE_ENV: production - HOME: /root steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + # The image runs as root while the checkout belongs to the runner user; + # git refuses such a tree, and the prepare hook calls git. + - run: git config --global --add safe.directory "$GITHUB_WORKSPACE" + - uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0 - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 diff --git a/e2e/day-doors.spec.ts b/e2e/day-doors.spec.ts index c290471b5..ae2c4bb49 100644 --- a/e2e/day-doors.spec.ts +++ b/e2e/day-doors.spec.ts @@ -49,8 +49,12 @@ async function openFromPlot(page: Page, plot: Locator, testInfo: TestInfo) { await expect(open).toBeVisible(); // A tap alone never opens a sheet: a point is a small target. await expect(panel(page)).toHaveCount(0); - // The button is a calm, full 44 px row. - expect((await open.boundingBox())!.height).toBeGreaterThanOrEqual(44); + // The button is a calm, full 44 px row. The tooltip re-renders while the + // tap settles, so the measurement retries instead of reading a box from + // a node that has just been replaced. + await expect + .poll(async () => (await open.boundingBox())?.height ?? 0) + .toBeGreaterThanOrEqual(44); await open.tap(); await expect(panel(page)).toHaveAttribute("data-shell", "bottom"); } else {