mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 15:23:29 +00:00
fix(deploy-webhook): keep DEPLOY_WEBHOOK_REQUIRE_TIMESTAMP's meaning, add a signature-only flag
DEPLOY_WEBHOOK_REQUIRE_TIMESTAMP had been changed to mean signed requests only, so an operator who set it for a sender that adds a timestamp but cannot sign would have had every deploy notification refused after the upgrade. It means the secret header plus a fresh timestamp again. Signature-only, the setting that stops a replay, is DEPLOY_WEBHOOK_REQUIRE_SIGNATURE, on the compose whitelist, in the env manifest and examples, and in the deploy guide.
This commit is contained in:
1 parent
d87718407e
commit
70df2009d9
7 files changed
+93
-26
No files matched your search
+9
-5
@@ -311,14 +311,18 @@ x-healthlog-env: &healthlog_env
|
||||
# X-Deploy-Webhook-Secret header (what Coolify's stock sender can do; no
|
||||
# replay protection) or with X-Deploy-Webhook-Signature: sha256=<HMAC of
|
||||
# "<X-Deploy-Webhook-Timestamp>.<body>" under the secret>, the timestamp
|
||||
# within 5 minutes. DEPLOY_WEBHOOK_REQUIRE_TIMESTAMP=true accepts signed
|
||||
# requests only. DEPLOY_LOGS_URL is the deployment-dashboard URL (e.g. the
|
||||
# Coolify UI) linked in deploy-failure notifications. Listed here so
|
||||
# operator values in .env reach the container (the `environment:` block is
|
||||
# a whitelist). See docs/ops/deploy.md.
|
||||
# within 5 minutes. DEPLOY_WEBHOOK_REQUIRE_TIMESTAMP=true also requires a
|
||||
# fresh X-Deploy-Webhook-Timestamp on a secret-header request;
|
||||
# DEPLOY_WEBHOOK_REQUIRE_SIGNATURE=true accepts signed requests only, the
|
||||
# one setting that stops a replay. DEPLOY_LOGS_URL is the
|
||||
# deployment-dashboard URL (e.g. the Coolify UI) linked in deploy-failure
|
||||
# notifications. Listed here so operator values in .env reach the
|
||||
# container (the `environment:` block is a whitelist). See
|
||||
# docs/ops/deploy.md.
|
||||
DEPLOY_WEBHOOK_SECRET: "${DEPLOY_WEBHOOK_SECRET:-}"
|
||||
DEPLOY_LOGS_URL: "${DEPLOY_LOGS_URL:-}"
|
||||
DEPLOY_WEBHOOK_REQUIRE_TIMESTAMP: "${DEPLOY_WEBHOOK_REQUIRE_TIMESTAMP:-}"
|
||||
DEPLOY_WEBHOOK_REQUIRE_SIGNATURE: "${DEPLOY_WEBHOOK_REQUIRE_SIGNATURE:-}"
|
||||
# TLS leaf SPKI-change alarm baseline (optional). The native client
|
||||
# pins the served TLS leaf; this is the known-good pin set the monitor
|
||||
# alarms against on a rotation. Comma-separated for the dual-pin
|
||||
|
||||
Reference in new issue
Block a user