mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-16 15:23:29 +00:00
fix(auth): stop exempting a previously used address from the sign-in throttle
The per-account password throttle skipped every attempt that came from an address one of the account's sessions or device logins had used in the last thirty days. An address is the easiest thing about a request to share or claim: in a household or an office the guesser has the owner's address, and a direct caller could name it in a forwarding header. Either way the throttle switched off and guessing was bounded only by the hash cost. A remembered browser (the trusted-device cookie) and a phone presenting the device id of one of the account's logins still pass; everything else gets the growing wait.
This commit is contained in:
1 parent
d6d0f7e73f
commit
6fbfe71955
3 files changed
+28
-49
No files matched your search
@@ -113,7 +113,8 @@ export const POST = apiHandler(async (request: NextRequest) => {
|
||||
}
|
||||
|
||||
// The per-account half of the throttle (`@/lib/auth/login-throttle`): a
|
||||
// place this account has signed in from is neither counted nor held back,
|
||||
// remembered browser or a phone this account signed in on is neither
|
||||
// counted nor held back,
|
||||
// anywhere else waits longer after each failure past the first few, up to
|
||||
// fifteen minutes. Decided before the Argon2id verification, so a waiting
|
||||
// attempt costs no hashing.
|
||||
@@ -121,7 +122,6 @@ export const POST = apiHandler(async (request: NextRequest) => {
|
||||
user,
|
||||
identifier,
|
||||
request,
|
||||
ip: rl.ip,
|
||||
});
|
||||
annotate({ meta: { login_known_source: attempt.source ?? "none" } });
|
||||
if (attempt.waiting) {
|
||||
|
||||
Reference in new issue
Block a user