mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-18 08:02:12 +00:00
perf(dashboard): serve the snapshot stale-while-revalidate on a measurement write
The dashboard snapshot lives in the analytics cache bucket, which had no
stale window, and every measurement write hard-evicted the whole
${userId}| prefix. A high-frequency iOS Apple-Health sync therefore
busted the snapshot into a cold rebuild on the next read all day long
(the same class as the v1.8.7 insight-cache eviction).
Give the analytics bucket a stale-while-revalidate window, read the
snapshot via cachedSwr, and switch the measurement-write invalidation
from a hard deleteByPrefix to markStaleByPrefix. The snapshot now serves
the prior value immediately while a single background recompute warms a
fresh one. Slim / thick / summary cells read via plain cached are
unaffected: a marked-stale entry has expiresAt === now, so their next
read is a clean miss and rebuilds fresh. Widget reorder keeps its hard
point-evict so a layout change paints synchronously; mood and medication
writes keep their hard analytics sweep.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
ae468edca2
commit
6de5de0284
4 files changed
+90
-22
No files matched your search
Vendored
+19
-9
@@ -22,12 +22,12 @@ import { caches } from "./server-cache";
|
||||
|
||||
/**
|
||||
* v1.7.0 W6 — server cache key for the unified dashboard first-paint
|
||||
* snapshot. Lives under the analytics cache bucket so the existing
|
||||
* `caches.analytics.deleteByPrefix(`${userId}|`)` sweep on a
|
||||
* measurement / mood / medication write already covers it; the widget
|
||||
* + insight invalidators that DON'T touch the analytics bucket call
|
||||
* `invalidateUserDashboardSnapshot` explicitly. Exported so the cache
|
||||
* key stays single-source-of-truth across the route and the tests.
|
||||
* snapshot. Lives under the analytics cache bucket so the `${userId}|`
|
||||
* sweep on a measurement / mood / medication write already covers it
|
||||
* (measurement writes mark it stale; mood / medication writes hard-evict
|
||||
* it); the widget + insight invalidators that DON'T touch the analytics
|
||||
* bucket call `invalidateUserDashboardSnapshot` explicitly. Exported so
|
||||
* the cache key stays single-source-of-truth across route and tests.
|
||||
*/
|
||||
export function dashboardSnapshotCacheKey(userId: string): string {
|
||||
return `${userId}|dashboard-snapshot`;
|
||||
@@ -49,10 +49,20 @@ export function invalidateUserDashboardSnapshot(userId: string): void {
|
||||
* because mood writes don't change measurement rows.
|
||||
*/
|
||||
export function invalidateUserMeasurements(userId: string): void {
|
||||
// The `${userId}|` prefix sweep covers the slim / thick analytics
|
||||
// cells, the iOS summary cell, AND the v1.7.0 dashboard snapshot
|
||||
// The `${userId}|` prefix covers the slim / thick analytics cells, the
|
||||
// iOS summary cell, AND the v1.7.0 dashboard snapshot
|
||||
// (`${userId}|dashboard-snapshot`) in one pass.
|
||||
caches.analytics.deleteByPrefix(`${userId}|`);
|
||||
//
|
||||
// v1.12.7 — mark stale rather than hard-evict. Measurement writes are
|
||||
// the highest-frequency dirty signal (every iOS Apple-Health sync
|
||||
// posts a batch), and a hard evict busts the snapshot into a cold
|
||||
// rebuild on the next read all day long. Marking stale lets the
|
||||
// `cachedSwr` snapshot read serve the prior value immediately while a
|
||||
// single background recompute warms a fresh one. The slim / thick /
|
||||
// summary cells read via plain `cached` are unaffected: a marked-stale
|
||||
// entry has `expiresAt === now`, so their next read is a clean miss and
|
||||
// rebuilds fresh — identical to the old evict for those keys.
|
||||
caches.analytics.markStaleByPrefix(`${userId}|`);
|
||||
caches.achievements.deleteByPrefix(userId);
|
||||
caches.workouts.deleteByPrefix(`${userId}|`);
|
||||
// v1.4.36 W1 — measurement writes change the per-target consistency
|
||||
|
||||
Vendored
+19
@@ -339,10 +339,29 @@ export class ServerCache<T> {
|
||||
* `/api/mood/analytics`) without churning the helper module.
|
||||
*/
|
||||
export const caches = {
|
||||
/**
|
||||
* Slim / thick analytics cells, the iOS summary cell, the dashboard
|
||||
* summary, AND the unified dashboard first-paint snapshot (per-key TTL
|
||||
* override). 60 s fresh TTL keeps multiple sub-page mounts inside a
|
||||
* minute on a warm entry.
|
||||
*
|
||||
* v1.12.7 — stale-while-revalidate window. The snapshot read uses
|
||||
* `cachedSwr` and a measurement write marks the bucket stale (not a
|
||||
* hard evict) via `invalidateUserMeasurements`, so a high-frequency
|
||||
* iOS Apple-Health sync no longer busts the snapshot into a cold
|
||||
* rebuild on every batch (the v1.8.7 "sync evicting the cache all day"
|
||||
* class, on the dashboard snapshot). Slim / thick / summary cells read
|
||||
* via plain `cached` are unaffected: a marked-stale entry has
|
||||
* `expiresAt === now`, so their next `cached` read is a clean miss and
|
||||
* rebuilds fresh — only the `cachedSwr` snapshot serves stale + warms a
|
||||
* background recompute. The 10-minute stale window bounds how old a
|
||||
* served snapshot can be when no reader triggers a revalidation.
|
||||
*/
|
||||
analytics: new ServerCache<unknown>({
|
||||
name: "analytics",
|
||||
maxEntries: 1000,
|
||||
ttlMs: 60_000,
|
||||
staleTtlMs: 600_000,
|
||||
}),
|
||||
medications: new ServerCache<unknown>({
|
||||
name: "medications",
|
||||
|
||||
Reference in new issue
Block a user