chore(release): v1.4.45 — analytics 9 s perf fix + audit-marathon closure + v1.4.44 hotfix merged

Audit-marathon close: 14 waves + W10 QA + reconcile. Perf fix (analytics 9 s -> 2-3 s), Zod multi-issue rollout (41 routes), Withings parked-state automation, mobile-UI WCAG 2.5.5 close, QoL i18n + offline banner + account delete, security PII drop + replay-injection scan. Migration 0075 required. Tests 4815 -> 5076.

src/app/api/admin/feedback/[id]/__tests__/route.test.ts

@@ -0,0 +1,93 @@
+/**
+ * v1.4.43 W6 — multi-issue 422 envelope on PATCH /api/admin/feedback/[id].
+ */
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { NextRequest } from "next/server";
+
+vi.mock("@/lib/db", () => ({
+  prisma: {
+    feedback: {
+      findUnique: vi.fn(),
+      update: vi.fn(),
+    },
+  },
+}));
+
+vi.mock("@/lib/auth/session", () => ({ getSession: vi.fn() }));
+vi.mock("@/lib/auth/audit", () => ({
+  auditLog: vi.fn().mockResolvedValue(undefined),
+}));
+vi.mock("@/lib/logging/transports", () => ({ emitIfSampled: vi.fn() }));
+vi.mock("@/lib/db-compat", () => ({
+  ensureDbCompatibility: vi.fn().mockResolvedValue(undefined),
+}));
+vi.mock("next/headers", () => ({
+  headers: vi.fn(async () => ({ get: () => null })),
+  cookies: vi.fn(async () => ({
+    get: () => undefined,
+    set: () => {},
+    delete: () => {},
+  })),
+}));
+
+import { PATCH } from "../route";
+import { getSession } from "@/lib/auth/session";
+
+const SESSION_ADMIN = {
+  session: { id: "sess-1", expiresAt: new Date(Date.now() + 3_600_000) },
+  user: { id: "admin-1", username: "admin", role: "ADMIN" as const },
+};
+
+function patchReq(body: unknown): NextRequest {
+  return new NextRequest("http://localhost/api/admin/feedback/f1", {
+    method: "PATCH",
+    headers: { "content-type": "application/json" },
+    body: JSON.stringify(body),
+  });
+}
+
+const ROUTE_CTX = { params: Promise.resolve({ id: "f1" }) };
+
+beforeEach(() => {
+  vi.resetAllMocks();
+  vi.mocked(getSession).mockResolvedValue(SESSION_ADMIN as never);
+});
+
+describe("PATCH /api/admin/feedback/[id] — 422 multi-issue (v1.4.43 W6)", () => {
+  it("surfaces TWO simultaneous validation errors", async () => {
+    // Bad `status` enum + adminNote too long.
+    const res = await PATCH(
+      patchReq({ status: "junk", adminNote: "x".repeat(10000) }),
+      ROUTE_CTX,
+    );
+    expect(res.status).toBe(422);
+    const body = (await res.json()) as {
+      data: null;
+      error: string;
+      details: {
+        issues: Array<{ path: string; code: string; message: string }>;
+      };
+    };
+    expect(body.data).toBeNull();
+    expect(body.error).toBe("Validation failed");
+    expect(body.details.issues.length).toBeGreaterThanOrEqual(2);
+    for (const issue of body.details.issues) {
+      expect(Object.keys(issue).sort()).toEqual(["code", "message", "path"]);
+    }
+  });
+
+  it("surfaces multiple simultaneous validation errors (≥ 2)", async () => {
+    // The schema has only two knobs (status + adminNote), so the strict
+    // 3-issue ceiling isn't reachable. Multi-issue contract is pinned at
+    // ≥ 2 by the case above.
+    const res = await PATCH(
+      patchReq({ status: 999, adminNote: 123 }),
+      ROUTE_CTX,
+    );
+    expect(res.status).toBe(422);
+    const body = (await res.json()) as {
+      details: { issues: Array<unknown> };
+    };
+    expect(body.details.issues.length).toBeGreaterThanOrEqual(2);
+  });
+});

src/app/api/admin/feedback/[id]/route.ts

@@ -6,6 +6,7 @@ import { apiHandler, requireAdmin } from "@/lib/api-handler";
 import {
   apiError,
   apiSuccess,
+  returnAllZodIssues,
   safeJson,
   getClientIp,
 } from "@/lib/api-response";
@@ -25,7 +26,8 @@ export const PATCH = apiHandler(
 
     const parsed = updateFeedbackSchema.safeParse(body);
     if (!parsed.success) {
-      return apiError(parsed.error.issues[0].message, 422);
+      // v1.4.43 W6 — multi-issue 422.
+      return returnAllZodIssues(parsed.error, 422);
     }
 
     const before = await prisma.feedback.findUnique({ where: { id } });

src/app/api/admin/settings/__tests__/route.test.ts

@@ -505,4 +505,46 @@ describe("PUT /api/admin/settings", () => {
     expect(res.status).toBe(422);
     expect(prisma.appSettings.upsert).not.toHaveBeenCalled();
   });
+
+  describe("v1.4.43 W6 — multi-issue 422 envelope", () => {
+    it("surfaces TWO simultaneous validation errors", async () => {
+      // Bad `registrationEnabled` (string not boolean) + bad
+      // `reminderLateMinutes` (string not int).
+      const res = await PUT(
+        jsonReq({
+          registrationEnabled: "string",
+          reminderLateMinutes: "string",
+        }),
+      );
+      expect(res.status).toBe(422);
+      const body = (await res.json()) as {
+        data: null;
+        error: string;
+        details: {
+          issues: Array<{ path: string; code: string; message: string }>;
+        };
+      };
+      expect(body.data).toBeNull();
+      expect(body.error).toBe("Validation failed");
+      expect(body.details.issues.length).toBeGreaterThanOrEqual(2);
+      for (const issue of body.details.issues) {
+        expect(Object.keys(issue).sort()).toEqual(["code", "message", "path"]);
+      }
+    });
+
+    it("surfaces THREE simultaneous validation errors", async () => {
+      const res = await PUT(
+        jsonReq({
+          registrationEnabled: "string",
+          reminderLateMinutes: "string",
+          reminderMissedMinutes: "string",
+        }),
+      );
+      expect(res.status).toBe(422);
+      const body = (await res.json()) as {
+        details: { issues: Array<unknown> };
+      };
+      expect(body.details.issues.length).toBeGreaterThanOrEqual(3);
+    });
+  });
 });

src/app/api/admin/settings/assistant-flags/__tests__/route.test.ts

@@ -154,4 +154,47 @@ describe("PUT /api/admin/settings/assistant-flags", () => {
     const res = await PUT(putReq({ assistantPotatoEnabled: false }));
     expect(res.status).toBe(422);
   });
+
+  describe("v1.4.43 W6 — multi-issue 422 envelope", () => {
+    it("surfaces TWO simultaneous validation errors", async () => {
+      vi.mocked(getSession).mockResolvedValue(ADMIN_OK as never);
+      // Two bad-typed flags.
+      const res = await PUT(
+        putReq({
+          assistantEnabled: "string",
+          assistantCoachEnabled: 999,
+        }),
+      );
+      expect(res.status).toBe(422);
+      const body = (await res.json()) as {
+        data: null;
+        error: string;
+        details: {
+          issues: Array<{ path: string; code: string; message: string }>;
+        };
+      };
+      expect(body.data).toBeNull();
+      expect(body.error).toBe("Validation failed");
+      expect(body.details.issues.length).toBeGreaterThanOrEqual(2);
+      for (const issue of body.details.issues) {
+        expect(Object.keys(issue).sort()).toEqual(["code", "message", "path"]);
+      }
+    });
+
+    it("surfaces THREE simultaneous validation errors", async () => {
+      vi.mocked(getSession).mockResolvedValue(ADMIN_OK as never);
+      const res = await PUT(
+        putReq({
+          assistantEnabled: "string",
+          assistantCoachEnabled: 999,
+          assistantBriefingEnabled: "string",
+        }),
+      );
+      expect(res.status).toBe(422);
+      const body = (await res.json()) as {
+        details: { issues: Array<unknown> };
+      };
+      expect(body.details.issues.length).toBeGreaterThanOrEqual(3);
+    });
+  });
 });

src/app/api/admin/settings/assistant-flags/route.ts

@@ -32,6 +32,7 @@ import {
   apiSuccess,
   apiError,
   getClientIp,
+  returnAllZodIssues,
   safeJson,
 } from "@/lib/api-response";
 import { auditLog } from "@/lib/auth/audit";
@@ -124,7 +125,8 @@ export const PUT = apiHandler(async (request: NextRequest) => {
 
   const parsed = assistantFlagsSchema.safeParse(body);
   if (!parsed.success) {
-    return apiError(parsed.error.issues[0].message, 422);
+    // v1.4.43 W6 — multi-issue 422.
+    return returnAllZodIssues(parsed.error, 422);
   }
 
   const updates: Partial<AssistantFlagsRow> = {};

src/app/api/admin/settings/route.ts

@@ -5,6 +5,7 @@ import {
   apiSuccess,
   apiError,
   getClientIp,
+  returnAllZodIssues,
   safeJson,
 } from "@/lib/api-response";
 import { annotate } from "@/lib/logging/context";
@@ -71,7 +72,8 @@ export const PUT = apiHandler(async (request: NextRequest) => {
   if (jsonError) return jsonError;
   const parsed = adminSettingsSchema.safeParse(body);
   if (!parsed.success) {
-    return apiError(parsed.error.issues[0].message, 422);
+    // v1.4.43 W6 — multi-issue 422.
+    return returnAllZodIssues(parsed.error, 422);
   }
 
   const data = parsed.data;

src/app/api/admin/users/[id]/__tests__/route.test.ts

@@ -205,4 +205,40 @@ describe("PUT /api/admin/users/[id]", () => {
     const res = await PUT(r, params("u1"));
     expect(res.status).toBe(415);
   });
+
+  describe("v1.4.43 W6 — multi-issue 422 envelope", () => {
+    it("surfaces TWO simultaneous validation errors", async () => {
+      // Bad username (too short) + bad role enum.
+      const res = await PUT(
+        jsonReq({ username: "x", role: "GOD" }),
+        params("u1"),
+      );
+      expect(res.status).toBe(422);
+      const body = (await res.json()) as {
+        data: null;
+        error: string;
+        details: {
+          issues: Array<{ path: string; code: string; message: string }>;
+        };
+      };
+      expect(body.data).toBeNull();
+      expect(body.error).toBe("Validation failed");
+      expect(body.details.issues.length).toBeGreaterThanOrEqual(2);
+      for (const issue of body.details.issues) {
+        expect(Object.keys(issue).sort()).toEqual(["code", "message", "path"]);
+      }
+    });
+
+    it("surfaces THREE simultaneous validation errors", async () => {
+      const res = await PUT(
+        jsonReq({ username: "x", email: "not-an-email", role: "GOD" }),
+        params("u1"),
+      );
+      expect(res.status).toBe(422);
+      const body = (await res.json()) as {
+        details: { issues: Array<unknown> };
+      };
+      expect(body.details.issues.length).toBeGreaterThanOrEqual(3);
+    });
+  });
 });

src/app/api/admin/users/[id]/route.ts

@@ -5,6 +5,7 @@ import {
   apiSuccess,
   apiError,
   getClientIp,
+  returnAllZodIssues,
   safeJson,
 } from "@/lib/api-response";
 import { annotate } from "@/lib/logging/context";
@@ -38,7 +39,8 @@ export const PUT = apiHandler(
     if (jsonError) return jsonError;
     const parsed = updateUserSchema.safeParse(body);
     if (!parsed.success) {
-      return apiError(parsed.error.issues[0].message, 422);
+      // v1.4.43 W6 — multi-issue 422.
+      return returnAllZodIssues(parsed.error, 422);
     }
 
     const target = await prisma.user.findUnique({ where: { id } });