refactor(v1.4.19): apply simplify-review safe suggestions

Mechanical clean-up sweep across five hot spots flagged by the simplify
audit:

- Lift the 11-key auth.* audit-action label map out of the two admin
  components that rebuilt it on every render. The shared
  useAuthActionLabels() hook in _shared.tsx is now the single home for
  new entries (login-overview + recent-audit-preview consume it).
- Drop the dead chipClass branches in IntegrationStatusPill: only the
  connected state actually paints a Dracula-green chip; error and
  disconnected fall back to the badge variant.
- Add thin DateInput / DateTimeInput wrappers under components/ui that
  bake in the lang={locale} hint so 14 callsites across 9 files no
  longer have to remember the prop. A future date input cannot
  silently regress.
- Remove the leading icon-only flex wrappers left behind when the
  duplicate card titles were dropped on /admin/feedback,
  /admin/danger-zone, and the thresholds editor.
- Strip the five "v1.4.19 X removed because…" narration comments from
  insights/page.tsx and the dashboard. git blame already answers what
  changed and the comments aged into history.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Marc-André BombeckandClaude Opus 4.7 committed 2026-05-10 14:24:35 +02:00
1 parent ef74241a68
commit 6b35cad079
19 files changed
+108 -155

No files matched your search

+29
View File
@@ -1,5 +1,6 @@
"use client";
import { useMemo } from "react";
import { useQuery, useMutation, useQueryClient } from "@tanstack/react-query";
import { toast } from "sonner";
import { Switch } from "@/components/ui/switch";
@@ -257,6 +258,34 @@ export async function getApiErrorMessage(response: Response): Promise<string> {
return fallback;
}
/**
* Shared `auth.*` audit-action label map. Two surfaces consume it
* today (`/admin/login-overview` and the dashboard recent-activity
* preview), and any future audit feed will need the same translation
* lookup. New auth actions are added here once instead of being
* copy-pasted into every consumer.
*/
export function useAuthActionLabels(): Record<string, string> {
const { t, locale } = useTranslations();
return useMemo(
() => ({
"auth.register": t("admin.authRegister"),
"auth.login": t("admin.authLogin"),
"auth.login.passkey": t("admin.authLoginPasskey"),
"auth.login.password": t("admin.authLoginPassword"),
"auth.login.failed": t("admin.authLoginFailed"),
"auth.logout": t("admin.authLogout"),
"auth.passkey.register": t("admin.authPasskeyRegister"),
"auth.passkey.delete": t("admin.authPasskeyDelete"),
"auth.token.autoissue.native": t("admin.authTokenAutoissueNative"),
"auth.token.refresh": t("admin.authTokenRefresh"),
"auth.token.revoke": t("admin.authTokenRevoke"),
}),
// eslint-disable-next-line react-hooks/exhaustive-deps
[locale],
);
}
export function useSystemStatus() {
return useQuery({
queryKey: ["admin", "status"],
+4 -6
View File
@@ -70,12 +70,10 @@ export function DangerZoneSection() {
already names the section, so the card-level title was a
duplicate of the page title. The destructive icon stays so
the card still flags itself as dangerous at a glance. */}
<div className="flex items-center gap-2">
<AlertTriangle
className="text-destructive h-5 w-5"
aria-hidden="true"
/>
</div>
<AlertTriangle
className="text-destructive h-5 w-5"
aria-hidden="true"
/>
<div className="mt-4">
<p className="text-sm font-medium">{t("admin.deleteAllData")}</p>
<p className="text-muted-foreground text-xs">
@@ -78,9 +78,7 @@ export function FeedbackInboxSection() {
`/admin/feedback`, so the page header already provides the
title + description — the card-level repetition was just
visual noise. The icon stays as a low-key card affordance. */}
<div className="flex items-center gap-2">
<Inbox className="text-primary h-5 w-5" aria-hidden="true" />
</div>
<Inbox className="text-primary h-5 w-5" aria-hidden="true" />
<Tabs
value={activeStatus}
@@ -23,7 +23,7 @@ import {
import { formatDateTime } from "@/lib/format";
import { useTranslations } from "@/lib/i18n/context";
import { toCSV } from "@/lib/export";
import { type AdminAuditEntry } from "./_shared";
import { type AdminAuditEntry, useAuthActionLabels } from "./_shared";
type DateRangePreset = "all" | "24h" | "7d" | "30d";
type PerPageValue = 25 | 50 | 100;
@@ -67,19 +67,7 @@ export function LoginOverviewSection() {
const [page, setPage] = useState(1);
const [perPage, setPerPage] = useState<PerPageValue>(50);
const AUTH_ACTION_LABELS: Record<string, string> = {
"auth.register": t("admin.authRegister"),
"auth.login": t("admin.authLogin"),
"auth.login.passkey": t("admin.authLoginPasskey"),
"auth.login.password": t("admin.authLoginPassword"),
"auth.login.failed": t("admin.authLoginFailed"),
"auth.logout": t("admin.authLogout"),
"auth.passkey.register": t("admin.authPasskeyRegister"),
"auth.passkey.delete": t("admin.authPasskeyDelete"),
"auth.token.autoissue.native": t("admin.authTokenAutoissueNative"),
"auth.token.refresh": t("admin.authTokenRefresh"),
"auth.token.revoke": t("admin.authTokenRevoke"),
};
const AUTH_ACTION_LABELS = useAuthActionLabels();
// Build the query string once so it's reused by the data-query key, the
// export download, and the next-/prev- buttons.
+2 -14
View File
@@ -21,7 +21,7 @@ import {
import { EmptyState } from "@/components/ui/empty-state";
import { formatDateTime } from "@/lib/format";
import { useTranslations } from "@/lib/i18n/context";
import { type AdminAuditEntry } from "./_shared";
import { type AdminAuditEntry, useAuthActionLabels } from "./_shared";
const PREVIEW_LIMIT = 10;
@@ -47,19 +47,7 @@ export function RecentAuditPreview() {
staleTime: 30_000,
});
const AUTH_ACTION_LABELS: Record<string, string> = {
"auth.register": t("admin.authRegister"),
"auth.login": t("admin.authLogin"),
"auth.login.passkey": t("admin.authLoginPasskey"),
"auth.login.password": t("admin.authLoginPassword"),
"auth.login.failed": t("admin.authLoginFailed"),
"auth.logout": t("admin.authLogout"),
"auth.passkey.register": t("admin.authPasskeyRegister"),
"auth.passkey.delete": t("admin.authPasskeyDelete"),
"auth.token.autoissue.native": t("admin.authTokenAutoissueNative"),
"auth.token.refresh": t("admin.authTokenRefresh"),
"auth.token.revoke": t("admin.authTokenRevoke"),
};
const AUTH_ACTION_LABELS = useAuthActionLabels();
const entries = data?.entries ?? [];