mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-12 06:06:10 +00:00
feat(api): batch measurement ingest for the iOS Apple Health sync
`POST /api/measurements/batch` accepts up to 500 HealthKit-shaped entries per call, runs each through the new mapping helper, and writes them under `source = APPLE_HEALTH` with the inbound sample UUID as the external id. The composite unique index on `(user_id, type, source, external_id)` does the per-entry dedup; `Idempotency-Key` covers the batch-level retry case so the iOS observer queue can replay in flight without double-writing. Per-entry status (`inserted` / `duplicate` / `skipped`) lets the client advance its sync cursor accurately even when individual rows land on different paths. Skip reasons cover unknown HealthKit identifiers and out-of-plausible-range values so a single bogus sensor reading never rejects an otherwise clean batch. Insertion uses chunked `createMany` with `skipDuplicates: true` so a race between two concurrent retries reconciles cleanly via the unique index instead of failing the transaction. Wide Event annotation logs `processed / inserted / duplicates / skipped` for ops visibility. Six integration tests against a real Postgres testcontainer cover the happy path, the per-entry duplicate path, the over-cap 422, mixed unmappable + out-of-range entries, per-stage sleep rows, and `Idempotency-Key` replay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Marc-André BombeckandClaude Opus 4.7 committed
1 parent
30c0f76a34
commit
5cc0a00eaf
2 files changed
+660
No files matched your search
@@ -0,0 +1,363 @@
|
||||
/**
|
||||
* Integration suite for `POST /api/measurements/batch` — the iOS Apple
|
||||
* Health ingest endpoint. Asserts the contract the iOS client relies on:
|
||||
* - Mixed batches succeed end-to-end
|
||||
* - Re-posting the same batch yields an idempotent outcome
|
||||
* - Over-cap batches return 422 with the documented error code
|
||||
* - Unmappable identifiers and out-of-range values surface as `skipped`
|
||||
* - The composite unique index dedupes by `(user_id, type, source, external_id)`
|
||||
* - Idempotency-Key replay returns the cached envelope
|
||||
*/
|
||||
import { NextRequest } from "next/server";
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { cookieJar } from "./mock-next-headers";
|
||||
import { getPrismaClient, truncateAllTables } from "./setup";
|
||||
|
||||
const TEST_USER_ID = "user-batch-ingest-test";
|
||||
|
||||
vi.mock("next/headers", async () => {
|
||||
const { cookieJar, headerJar } = await import("./mock-next-headers");
|
||||
return {
|
||||
headers: vi.fn(async () => ({
|
||||
get: (name: string) => headerJar.get(name.toLowerCase()) ?? null,
|
||||
})),
|
||||
cookies: vi.fn(async () => ({
|
||||
get: (name: string) => {
|
||||
const value = cookieJar.get(name);
|
||||
return value ? { name, value } : undefined;
|
||||
},
|
||||
set: (name: string, value: string) => {
|
||||
cookieJar.set(name, value);
|
||||
},
|
||||
delete: (name: string) => {
|
||||
cookieJar.delete(name);
|
||||
},
|
||||
})),
|
||||
};
|
||||
});
|
||||
|
||||
vi.mock("@/lib/db-compat", () => ({
|
||||
ensureDbCompatibility: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
|
||||
beforeEach(async () => {
|
||||
await truncateAllTables(getPrismaClient());
|
||||
cookieJar.clear();
|
||||
await getPrismaClient().user.create({
|
||||
data: {
|
||||
id: TEST_USER_ID,
|
||||
username: "batch-ingest",
|
||||
email: "batch-ingest@example.test",
|
||||
},
|
||||
});
|
||||
const session = await getPrismaClient().session.create({
|
||||
data: {
|
||||
userId: TEST_USER_ID,
|
||||
expiresAt: new Date(Date.now() + 60 * 60 * 1000),
|
||||
},
|
||||
});
|
||||
cookieJar.set("healthlog_session", session.id);
|
||||
});
|
||||
|
||||
interface BatchEntryFixture {
|
||||
hkIdentifier: string;
|
||||
value: number;
|
||||
unit: string;
|
||||
startDate: string;
|
||||
endDate: string;
|
||||
externalId: string;
|
||||
externalSourceVersion?: string;
|
||||
sleepStage?: number;
|
||||
}
|
||||
|
||||
function makeRequest(
|
||||
body: { entries: BatchEntryFixture[] },
|
||||
opts: { idempotencyKey?: string } = {},
|
||||
): NextRequest {
|
||||
const headers: Record<string, string> = {
|
||||
"content-type": "application/json",
|
||||
};
|
||||
if (opts.idempotencyKey) {
|
||||
headers["idempotency-key"] = opts.idempotencyKey;
|
||||
}
|
||||
return new NextRequest("http://localhost/api/measurements/batch", {
|
||||
method: "POST",
|
||||
headers,
|
||||
body: JSON.stringify(body),
|
||||
});
|
||||
}
|
||||
|
||||
describe("POST /api/measurements/batch (real Postgres)", () => {
|
||||
it("inserts a well-formed batch and returns per-entry status", async () => {
|
||||
const { POST } = await import("@/app/api/measurements/batch/route");
|
||||
|
||||
const body = {
|
||||
entries: [
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierBodyMass",
|
||||
value: 81.4,
|
||||
unit: "kg",
|
||||
startDate: "2026-05-09T07:30:00.000Z",
|
||||
endDate: "2026-05-09T07:30:00.000Z",
|
||||
externalId: "uuid-weight-001",
|
||||
},
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierHeartRate",
|
||||
value: 64,
|
||||
unit: "count/min",
|
||||
startDate: "2026-05-09T08:00:00.000Z",
|
||||
endDate: "2026-05-09T08:00:00.000Z",
|
||||
externalId: "uuid-pulse-001",
|
||||
},
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierOxygenSaturation",
|
||||
value: 0.97,
|
||||
unit: "fraction",
|
||||
startDate: "2026-05-09T08:05:00.000Z",
|
||||
endDate: "2026-05-09T08:05:00.000Z",
|
||||
externalId: "uuid-spo2-001",
|
||||
},
|
||||
],
|
||||
};
|
||||
|
||||
const response = await POST(makeRequest(body));
|
||||
expect(response.status).toBe(200);
|
||||
const json = (await response.json()) as {
|
||||
data: {
|
||||
processed: number;
|
||||
inserted: number;
|
||||
duplicates: number;
|
||||
skipped: Array<{ index: number; reason: string }>;
|
||||
};
|
||||
};
|
||||
|
||||
expect(json.data.processed).toBe(3);
|
||||
expect(json.data.inserted).toBe(3);
|
||||
expect(json.data.duplicates).toBe(0);
|
||||
expect(json.data.skipped).toHaveLength(0);
|
||||
|
||||
const stored = await getPrismaClient().measurement.findMany({
|
||||
where: { userId: TEST_USER_ID },
|
||||
orderBy: { measuredAt: "asc" },
|
||||
});
|
||||
expect(stored).toHaveLength(3);
|
||||
expect(stored.every((r) => r.source === "APPLE_HEALTH")).toBe(true);
|
||||
|
||||
const spo2 = stored.find((r) => r.type === "OXYGEN_SATURATION");
|
||||
expect(spo2?.value).toBeCloseTo(97);
|
||||
expect(spo2?.unit).toBe("%");
|
||||
});
|
||||
|
||||
it("dedupes a re-posted batch into duplicate status without inserting twice", async () => {
|
||||
const { POST } = await import("@/app/api/measurements/batch/route");
|
||||
|
||||
const body = {
|
||||
entries: [
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierBodyMass",
|
||||
value: 81.5,
|
||||
unit: "kg",
|
||||
startDate: "2026-05-09T07:30:00.000Z",
|
||||
endDate: "2026-05-09T07:30:00.000Z",
|
||||
externalId: "uuid-dup-001",
|
||||
},
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierBodyMass",
|
||||
value: 81.6,
|
||||
unit: "kg",
|
||||
startDate: "2026-05-09T08:00:00.000Z",
|
||||
endDate: "2026-05-09T08:00:00.000Z",
|
||||
externalId: "uuid-dup-002",
|
||||
},
|
||||
],
|
||||
};
|
||||
|
||||
const first = await POST(makeRequest(body));
|
||||
expect(first.status).toBe(200);
|
||||
const firstJson = (await first.json()) as { data: { inserted: number } };
|
||||
expect(firstJson.data.inserted).toBe(2);
|
||||
|
||||
// Re-post the SAME body with NO idempotency-key. Per-entry dedup
|
||||
// should kick in via the composite unique index, returning all
|
||||
// duplicates and inserting nothing new.
|
||||
const second = await POST(makeRequest(body));
|
||||
expect(second.status).toBe(200);
|
||||
const secondJson = (await second.json()) as {
|
||||
data: { inserted: number; duplicates: number };
|
||||
};
|
||||
expect(secondJson.data.inserted).toBe(0);
|
||||
expect(secondJson.data.duplicates).toBe(2);
|
||||
|
||||
const stored = await getPrismaClient().measurement.findMany({
|
||||
where: { userId: TEST_USER_ID },
|
||||
});
|
||||
expect(stored).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("returns 422 with coach.batch.too_large when entries exceed the cap", async () => {
|
||||
const { POST } = await import("@/app/api/measurements/batch/route");
|
||||
|
||||
const entries: BatchEntryFixture[] = [];
|
||||
for (let i = 0; i < 501; i++) {
|
||||
entries.push({
|
||||
hkIdentifier: "HKQuantityTypeIdentifierBodyMass",
|
||||
value: 80 + (i % 10) * 0.1,
|
||||
unit: "kg",
|
||||
startDate: "2026-05-09T07:30:00.000Z",
|
||||
endDate: "2026-05-09T07:30:00.000Z",
|
||||
externalId: `uuid-cap-${i}`,
|
||||
});
|
||||
}
|
||||
|
||||
const response = await POST(makeRequest({ entries }));
|
||||
expect(response.status).toBe(422);
|
||||
const json = (await response.json()) as {
|
||||
error: string;
|
||||
meta?: { errorCode?: string };
|
||||
};
|
||||
expect(json.error).toMatch(/500/);
|
||||
expect(json.meta?.errorCode).toBe("coach.batch.too_large");
|
||||
});
|
||||
|
||||
it("flags unmappable identifiers and out-of-range values as skipped", async () => {
|
||||
const { POST } = await import("@/app/api/measurements/batch/route");
|
||||
|
||||
const body = {
|
||||
entries: [
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierHallucinated",
|
||||
value: 42,
|
||||
unit: "kg",
|
||||
startDate: "2026-05-09T07:30:00.000Z",
|
||||
endDate: "2026-05-09T07:30:00.000Z",
|
||||
externalId: "uuid-skip-unknown",
|
||||
},
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierBodyMass",
|
||||
value: 9999, // out of plausible range
|
||||
unit: "kg",
|
||||
startDate: "2026-05-09T07:30:00.000Z",
|
||||
endDate: "2026-05-09T07:30:00.000Z",
|
||||
externalId: "uuid-skip-range",
|
||||
},
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierBodyMass",
|
||||
value: 81.5,
|
||||
unit: "kg",
|
||||
startDate: "2026-05-09T07:30:00.000Z",
|
||||
endDate: "2026-05-09T07:30:00.000Z",
|
||||
externalId: "uuid-good-001",
|
||||
},
|
||||
],
|
||||
};
|
||||
|
||||
const response = await POST(makeRequest(body));
|
||||
expect(response.status).toBe(200);
|
||||
const json = (await response.json()) as {
|
||||
data: {
|
||||
processed: number;
|
||||
inserted: number;
|
||||
skipped: Array<{ index: number; reason: string }>;
|
||||
};
|
||||
};
|
||||
|
||||
expect(json.data.processed).toBe(3);
|
||||
expect(json.data.inserted).toBe(1);
|
||||
expect(json.data.skipped).toEqual(
|
||||
expect.arrayContaining([
|
||||
{ index: 0, reason: "unmappable_identifier" },
|
||||
{ index: 1, reason: "value_out_of_range" },
|
||||
]),
|
||||
);
|
||||
|
||||
const stored = await getPrismaClient().measurement.findMany({
|
||||
where: { userId: TEST_USER_ID },
|
||||
});
|
||||
expect(stored).toHaveLength(1);
|
||||
expect(stored[0]?.externalId).toBe("uuid-good-001");
|
||||
});
|
||||
|
||||
it("inserts per-stage sleep rows with the sleepStage column populated", async () => {
|
||||
const { POST } = await import("@/app/api/measurements/batch/route");
|
||||
|
||||
const body = {
|
||||
entries: [
|
||||
{
|
||||
hkIdentifier: "HKCategoryTypeIdentifierSleepAnalysis",
|
||||
value: 60, // minutes
|
||||
unit: "min",
|
||||
startDate: "2026-05-09T01:00:00.000Z",
|
||||
endDate: "2026-05-09T02:00:00.000Z",
|
||||
externalId: "uuid-sleep-core-001",
|
||||
sleepStage: 3, // CORE
|
||||
},
|
||||
{
|
||||
hkIdentifier: "HKCategoryTypeIdentifierSleepAnalysis",
|
||||
value: 90,
|
||||
unit: "min",
|
||||
startDate: "2026-05-09T02:00:00.000Z",
|
||||
endDate: "2026-05-09T03:30:00.000Z",
|
||||
externalId: "uuid-sleep-deep-001",
|
||||
sleepStage: 4, // DEEP
|
||||
},
|
||||
{
|
||||
hkIdentifier: "HKCategoryTypeIdentifierSleepAnalysis",
|
||||
value: 25,
|
||||
unit: "min",
|
||||
startDate: "2026-05-09T03:30:00.000Z",
|
||||
endDate: "2026-05-09T03:55:00.000Z",
|
||||
externalId: "uuid-sleep-rem-001",
|
||||
sleepStage: 5, // REM
|
||||
},
|
||||
],
|
||||
};
|
||||
|
||||
const response = await POST(makeRequest(body));
|
||||
expect(response.status).toBe(200);
|
||||
|
||||
const stored = await getPrismaClient().measurement.findMany({
|
||||
where: { userId: TEST_USER_ID, type: "SLEEP_DURATION" },
|
||||
orderBy: { measuredAt: "asc" },
|
||||
});
|
||||
expect(stored).toHaveLength(3);
|
||||
expect(stored.map((r) => r.sleepStage)).toEqual(["CORE", "DEEP", "REM"]);
|
||||
expect(stored.every((r) => r.unit === "minutes")).toBe(true);
|
||||
});
|
||||
|
||||
it("replays a cached response when the same Idempotency-Key is reused", async () => {
|
||||
const { POST } = await import("@/app/api/measurements/batch/route");
|
||||
|
||||
const body = {
|
||||
entries: [
|
||||
{
|
||||
hkIdentifier: "HKQuantityTypeIdentifierBodyMass",
|
||||
value: 81.7,
|
||||
unit: "kg",
|
||||
startDate: "2026-05-09T07:30:00.000Z",
|
||||
endDate: "2026-05-09T07:30:00.000Z",
|
||||
externalId: "uuid-idem-001",
|
||||
},
|
||||
],
|
||||
};
|
||||
|
||||
const key = "ios-batch-12345678";
|
||||
const first = await POST(makeRequest(body, { idempotencyKey: key }));
|
||||
expect(first.status).toBe(200);
|
||||
const firstJson = (await first.json()) as { data: { inserted: number } };
|
||||
expect(firstJson.data.inserted).toBe(1);
|
||||
|
||||
const second = await POST(makeRequest(body, { idempotencyKey: key }));
|
||||
expect(second.status).toBe(200);
|
||||
expect(second.headers.get("X-Idempotent-Replay")).toBe("true");
|
||||
const secondJson = (await second.json()) as { data: { inserted: number } };
|
||||
// Same envelope as the first call — even though it would otherwise
|
||||
// have surfaced as a duplicate.
|
||||
expect(secondJson.data.inserted).toBe(1);
|
||||
|
||||
const stored = await getPrismaClient().measurement.findMany({
|
||||
where: { userId: TEST_USER_ID, externalId: "uuid-idem-001" },
|
||||
});
|
||||
expect(stored).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user