refactor(ui): give Settings and Admin one card rhythm and one page header

The two consoles used the same primitives and still read as two systems,
because everything without a primitive had drifted: the header-to-body
step existed in three competing techniques at once (`mt-4` on the first
body child, `space-y-4` on the card, `mb-4` on the header), the body
started either at the card edge or 28 px in, and both shells hand-rolled
the page title instead of calling `PageHeader`.

Move the decisions into the primitives so a call site cannot re-open them:

- `SettingsCard` is gap-based like `Card` (`flex flex-col gap-4`). The
  header-to-body step is the container's, not a margin somebody remembers.
  A dense card still overrides the gap on the card itself.
- The body starts at the card edge. `pl-7` is gone — off the spacing scale,
  and it mis-aligned action rows against their own forms wherever two
  neighbouring cards disagreed about it.
- The card header's description slot loses its `space-y-1`. That was the
  licence call sites used to stack explainer paragraphs into a muted
  `text-xs` slot; the slot holds one sentence.
- New `SettingsCardActions`: one action row, trailing edge, last thing in
  the card. `align="start"` spells the one exception, a card whose only
  actions are links out.
- New `StatTile` replaces four hand-rolled label/value boxes in Admin.
- `SectionHeading` moves from `insights/` to `ui/`. It is the heading above
  a group of cards, which is what Settings needs; Settings had been using a
  card header with no card, which reads as a card that failed to paint.

Both shells now render their heading through `PageHeader`, which gained
`headingAs="div"` for the second copy each shell paints (mobile above the
nav strip, desktop inside the grid) so only one is a real `<h1>`. The
page explainer is muted everywhere: the primitive said foreground, the
standards and every hand-rolled copy said muted, so pages disagreed with
each other. Medications, Vorsorge, the labs / custom-metric / illness
detail pages and the clinician view drop their hand-rolled title blocks
too, including the mid-word truncation on the medications subtitle.

Tests pin the parts that can be checked exactly: the card's gap, the
description slot's missing rhythm, the action row's two alignments, the
`<h1>`-free shells, and a sweep asserting `pl-7` stays gone.
This commit is contained in:
Marc-André Bombeck committed 2026-08-07 19:05:15 +02:00
1 parent 00e8d05235
commit 5445bfc1f1
121 files changed
+832 -620

No files matched your search

@@ -160,12 +160,9 @@ export function AppleHealthCard({ enabled }: { enabled: boolean }) {
}
/>
<hr
data-testid="integration-card-divider"
className="border-border/60 mt-4"
/>
<hr data-testid="integration-card-divider" className="border-border/60" />
<div className="mt-4 space-y-4 pl-7">
<div className="space-y-4">
{isError && (
<IntegrationErrorMessage
message={t("settings.appleHealth.status.unavailable")}
@@ -243,12 +243,9 @@ export function FitbitCard({
}
/>
<hr
data-testid="integration-card-divider"
className="border-border/60 mt-4"
/>
<hr data-testid="integration-card-divider" className="border-border/60" />
<div className="mt-4 space-y-4 pl-7">
<div className="space-y-4">
{errorMessage && <IntegrationErrorMessage message={errorMessage} />}
{/* Parked-integration resume CTA. Surfaces only when the row
state is `parked` (>24h of persistent failures). The button
@@ -415,12 +415,9 @@ export function GoogleHealthCard({
}
/>
<hr
data-testid="integration-card-divider"
className="border-border/60 mt-4"
/>
<hr data-testid="integration-card-divider" className="border-border/60" />
<div className="mt-4 space-y-4 pl-7">
<div className="space-y-4">
{errorMessage && <IntegrationErrorMessage message={errorMessage} />}
{/* Re-consent CTA — distinct from parked/disconnected. Google expires
@@ -95,7 +95,7 @@ export function IntegrationFallbackRow({
/>
}
/>
<p className="text-muted-foreground mt-4 pl-7 text-xs">{meta}</p>
<p className="text-muted-foreground text-xs">{meta}</p>
</SettingsCard>
);
}
@@ -216,12 +216,9 @@ export function NightscoutCard({
}
/>
<hr
data-testid="integration-card-divider"
className="border-border/60 mt-4"
/>
<hr data-testid="integration-card-divider" className="border-border/60" />
<div className="mt-4 space-y-4 pl-7">
<div className="space-y-4">
{errorMessage && <IntegrationErrorMessage message={errorMessage} />}
{operatorApprovalRequired && (
<div
@@ -285,12 +285,9 @@ export function OAuthProviderCard({
}
/>
<hr
data-testid="integration-card-divider"
className="border-border/60 mt-4"
/>
<hr data-testid="integration-card-divider" className="border-border/60" />
<div className="mt-4 space-y-4 pl-7">
<div className="space-y-4">
{errorMessage && (
<div data-testid={`${provider}-error`}>
<IntegrationErrorMessage message={errorMessage} />
@@ -224,12 +224,9 @@ export function WhoopCard({
}
/>
<hr
data-testid="integration-card-divider"
className="border-border/60 mt-4"
/>
<hr data-testid="integration-card-divider" className="border-border/60" />
<div className="mt-4 space-y-4 pl-7">
<div className="space-y-4">
{errorMessage && <IntegrationErrorMessage message={errorMessage} />}
{/* Parked-integration resume CTA. Surfaces only when the row
state is `parked` (>24h of persistent failures). The button
@@ -236,12 +236,9 @@ export function WithingsCard({
}
/>
<hr
data-testid="integration-card-divider"
className="border-border/60 mt-4"
/>
<hr data-testid="integration-card-divider" className="border-border/60" />
<div className="mt-4 space-y-4 pl-7">
<div className="space-y-4">
{errorMessage && <IntegrationErrorMessage message={errorMessage} />}
{/* v1.4.25 W5d — Withings activity-scope reconnect banner.
Only paints when (a) the user has an active Withings