From 4be7d8ac5bb7887c02e0db268d09dbf039fad6b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= Date: Sun, 7 Jun 2026 17:46:26 +0200 Subject: [PATCH] fix(insights): rename the review section and even its top spacing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Shorten the period-narrative section title to 'Rückblick' (and the idiomatic short equivalent per locale) — the same i18n key the customizable-overview edit-mode labels read, so the rename flows through automatically. Drop the redundant 300px min-height floor on the Trends cards. The chart slot is a fixed 180px and the caption is clamped to three lines, so the floor padded dead space below every caption that read as an oversized Trends to Rückblick seam. The grid's auto-rows-fr plus the fixed chart slot already pin the cards to a single baseline, so the seam now matches the uniform rhythm. --- messages/de.json | 2 +- messages/en.json | 2 +- messages/es.json | 2 +- messages/fr.json | 2 +- messages/it.json | 2 +- messages/pl.json | 2 +- src/components/insights/trends-row.tsx | 11 ++++++++++- 7 files changed, 16 insertions(+), 7 deletions(-) diff --git a/messages/de.json b/messages/de.json index 6e28dbb65..61b7ab6ba 100644 --- a/messages/de.json +++ b/messages/de.json @@ -1659,7 +1659,7 @@ "regenerateAnalysis": "Einschätzung neu erstellen", "regenerateSuccess": "Einschätzung wurde neu erstellt", "warmStarted": "Einschätzungen werden im Hintergrund erstellt", - "narrativeTitle": "Zeitraum im Rückblick", + "narrativeTitle": "Rückblick", "narrativeWeek": "Diese Woche", "narrativeMonth": "Dieser Monat", "narrativePreparing": "Deine Zusammenfassung wird erstellt…", diff --git a/messages/en.json b/messages/en.json index 350e1e68a..5831a4c4d 100644 --- a/messages/en.json +++ b/messages/en.json @@ -1659,7 +1659,7 @@ "regenerateAnalysis": "Re-run assessment", "regenerateSuccess": "Assessment refreshed", "warmStarted": "Assessments are being prepared in the background", - "narrativeTitle": "Period in review", + "narrativeTitle": "In review", "narrativeWeek": "This week", "narrativeMonth": "This month", "narrativePreparing": "Preparing your summary…", diff --git a/messages/es.json b/messages/es.json index 33284f26e..53b7eb981 100644 --- a/messages/es.json +++ b/messages/es.json @@ -1659,7 +1659,7 @@ "regenerateAnalysis": "Volver a generar la valoración", "regenerateSuccess": "Valoración regenerada", "warmStarted": "Las valoraciones se están preparando en segundo plano", - "narrativeTitle": "Período en resumen", + "narrativeTitle": "Resumen", "narrativeWeek": "Esta semana", "narrativeMonth": "Este mes", "narrativePreparing": "Preparando tu resumen…", diff --git a/messages/fr.json b/messages/fr.json index b34577c5b..0cd4dc2be 100644 --- a/messages/fr.json +++ b/messages/fr.json @@ -1659,7 +1659,7 @@ "regenerateAnalysis": "Relancer l’évaluation", "regenerateSuccess": "Évaluation regénérée", "warmStarted": "Les évaluations sont en cours de préparation en arrière-plan", - "narrativeTitle": "Période en revue", + "narrativeTitle": "Rétrospective", "narrativeWeek": "Cette semaine", "narrativeMonth": "Ce mois-ci", "narrativePreparing": "Préparation de votre résumé…", diff --git a/messages/it.json b/messages/it.json index cbb8ccfb5..1c4676998 100644 --- a/messages/it.json +++ b/messages/it.json @@ -1659,7 +1659,7 @@ "regenerateAnalysis": "Rigenera la valutazione", "regenerateSuccess": "Valutazione rigenerata", "warmStarted": "Le valutazioni vengono preparate in background", - "narrativeTitle": "Periodo in sintesi", + "narrativeTitle": "Riepilogo", "narrativeWeek": "Questa settimana", "narrativeMonth": "Questo mese", "narrativePreparing": "Preparazione del riepilogo…", diff --git a/messages/pl.json b/messages/pl.json index 00c462378..7af88ae4b 100644 --- a/messages/pl.json +++ b/messages/pl.json @@ -1659,7 +1659,7 @@ "regenerateAnalysis": "Uruchom ocenę ponownie", "regenerateSuccess": "Ocena wygenerowana ponownie", "warmStarted": "Oceny są przygotowywane w tle", - "narrativeTitle": "Okres w skrócie", + "narrativeTitle": "Przegląd", "narrativeWeek": "Ten tydzień", "narrativeMonth": "Ten miesiąc", "narrativePreparing": "Przygotowywanie podsumowania…", diff --git a/src/components/insights/trends-row.tsx b/src/components/insights/trends-row.tsx index 5178d212d..5b9bcac4b 100644 --- a/src/components/insights/trends-row.tsx +++ b/src/components/insights/trends-row.tsx @@ -243,7 +243,16 @@ export function TrendsRow({ key={config.metric} data-slot="trends-row-card" data-metric={config.metric} - className="flex h-full flex-col gap-2 md:min-h-[300px]" + // v1.15.12 D1 — drop the `md:min-h-[300px]` floor. The chart + // slot is a fixed 180 px and the caption is `line-clamp-3`, so a + // card's natural height tops out around 270 px; the 300 px floor + // padded ~30 px of dead space below every caption, which read as + // an oversized Trends→Rückblick seam (the `space-y-6` gap is even, + // the empty card tail was the culprit). `auto-rows-fr` + + // `md:items-stretch` on the grid already pin every card to a + // single baseline, and the fixed chart slot aligns the charts, so + // the floor was redundant. Cards now size to content. + className="flex h-full flex-col gap-2" > {/* v1.4.28 R3c-Insights — fixed chart slot. The mini chart paints its own band; this wrapper pins the