mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-17 23:52:24 +00:00
feat(documents): gate document, lab and medication reading on their capabilities
Reading a document, scanning a lab report and turning a medication description into a schedule follow documentAi, labsOcr and medicationExtract. Unavailable, the action is not offered. With only the document-reading consent missing, the place that reads asks for it and grants exactly that (ai_extraction), nothing wider. Refusals are read by meta.errorCode: a 403 is no longer always called a missing consent, and a spent daily budget no longer shows the rate-limit sentence.
This commit is contained in:
1 parent
48d97ef70d
commit
4449b34ac7
15 files changed
+466
-40
No files matched your search
@@ -17,6 +17,15 @@ import type {
|
||||
* the strip, the chart placeholder, and the assessment card all paint.
|
||||
*/
|
||||
|
||||
// AI surfaces paint only while their capability is available; these tests
|
||||
// cover the painted surface, so every capability reads available here.
|
||||
vi.mock("@/hooks/use-ai-capability", () => ({
|
||||
useAiCapability: () => ({
|
||||
available: true,
|
||||
reason: null,
|
||||
onDeviceAllowed: true,
|
||||
}),
|
||||
}));
|
||||
vi.mock("@/lib/api/api-fetch", () => ({
|
||||
apiGet: () => new Promise(() => {}),
|
||||
apiDelete: vi.fn(),
|
||||
@@ -31,10 +40,6 @@ vi.mock("@/hooks/use-auth", () => ({
|
||||
useAuth: () => ({ isAuthenticated: true, user: { id: "u1" } }),
|
||||
}));
|
||||
|
||||
vi.mock("@/hooks/use-feature-flags", () => ({
|
||||
useFeatureFlags: () => ({ insightStatus: true }),
|
||||
}));
|
||||
|
||||
import { LabBiomarkerDetail } from "../lab-biomarker-detail";
|
||||
|
||||
const BIOMARKER_ID = "bm-1";
|
||||
|
||||
@@ -10,7 +10,8 @@ describe("shouldProbeOcrCapability", () => {
|
||||
labsEnabled: true,
|
||||
mounted: true,
|
||||
ownRecord: true,
|
||||
};
|
||||
labsOcr: { available: true, reason: null, onDeviceAllowed: true },
|
||||
} as const;
|
||||
|
||||
expect(shouldProbeOcrCapability(ownerControl)).toBe(true);
|
||||
expect(
|
||||
@@ -26,4 +27,36 @@ describe("shouldProbeOcrCapability", () => {
|
||||
false,
|
||||
);
|
||||
});
|
||||
|
||||
it("follows the labsOcr capability: probes when available or when only consent is missing", () => {
|
||||
const base = {
|
||||
isAuthenticated: true,
|
||||
isLoading: false,
|
||||
labsEnabled: true,
|
||||
mounted: true,
|
||||
ownRecord: true,
|
||||
};
|
||||
const state = (reason: string | null) =>
|
||||
({
|
||||
available: reason === null,
|
||||
reason,
|
||||
onDeviceAllowed: false,
|
||||
}) as Parameters<typeof shouldProbeOcrCapability>[0]["labsOcr"];
|
||||
|
||||
// Consent is asked for inside the scan dialog, so the scan stays offered.
|
||||
expect(
|
||||
shouldProbeOcrCapability({ ...base, labsOcr: state("consent_required") }),
|
||||
).toBe(true);
|
||||
for (const reason of [
|
||||
"operator_disabled",
|
||||
"no_provider",
|
||||
"module_disabled",
|
||||
"not_permitted_for_record",
|
||||
"check_failed",
|
||||
]) {
|
||||
expect(
|
||||
shouldProbeOcrCapability({ ...base, labsOcr: state(reason) }),
|
||||
).toBe(false);
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -5,7 +5,13 @@ import { afterEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { I18nProvider } from "@/lib/i18n/context";
|
||||
|
||||
import { handleFilePickerChange, OcrReviewDialog } from "../ocr-review-dialog";
|
||||
import { ApiError } from "@/lib/api/api-fetch";
|
||||
|
||||
import {
|
||||
extractErrorMessage,
|
||||
handleFilePickerChange,
|
||||
OcrReviewDialog,
|
||||
} from "../ocr-review-dialog";
|
||||
|
||||
const hookState = vi.hoisted(() => ({ extractPending: false }));
|
||||
|
||||
@@ -44,13 +50,25 @@ vi.mock("../use-ocr-extract", () => ({
|
||||
}),
|
||||
}));
|
||||
|
||||
vi.mock("@/hooks/use-grant-document-reading-consent", () => ({
|
||||
useGrantDocumentReadingConsent: () => ({
|
||||
isPending: false,
|
||||
isError: false,
|
||||
mutate: vi.fn(),
|
||||
}),
|
||||
}));
|
||||
|
||||
vi.mock("sonner", () => ({
|
||||
toast: { success: vi.fn(), error: vi.fn() },
|
||||
}));
|
||||
|
||||
function render(
|
||||
locale: "en" | "de" = "en",
|
||||
options: { mode?: "vision" | "text"; pdfSupported?: boolean } = {},
|
||||
options: {
|
||||
mode?: "vision" | "text";
|
||||
pdfSupported?: boolean;
|
||||
consentRequired?: boolean;
|
||||
} = {},
|
||||
): string {
|
||||
return renderToStaticMarkup(
|
||||
<I18nProvider initialLocale={locale}>
|
||||
@@ -59,6 +77,7 @@ function render(
|
||||
onOpenChange={() => {}}
|
||||
mode={options.mode ?? "vision"}
|
||||
pdfSupported={options.pdfSupported ?? true}
|
||||
consentRequired={options.consentRequired}
|
||||
onCommitted={() => {}}
|
||||
/>
|
||||
</I18nProvider>,
|
||||
@@ -138,3 +157,47 @@ describe("<OcrReviewDialog> file picker", () => {
|
||||
expect(input.value).toBe("");
|
||||
});
|
||||
});
|
||||
|
||||
describe("<OcrReviewDialog> document-reading consent", () => {
|
||||
it("asks for the reading consent in place of the picker while it is missing", () => {
|
||||
const html = render("en", { consentRequired: true });
|
||||
expect(html).toContain('data-slot="document-reading-consent"');
|
||||
expect(html).not.toMatch(/<input[^>]*type="file"/);
|
||||
});
|
||||
|
||||
it("shows the picker once consent is in place", () => {
|
||||
const html = render("en", { consentRequired: false });
|
||||
expect(html).not.toContain('data-slot="document-reading-consent"');
|
||||
expect(html).toMatch(/<input[^>]*type="file"/);
|
||||
});
|
||||
});
|
||||
|
||||
describe("extractErrorMessage", () => {
|
||||
const t = (key: string) => key;
|
||||
const refusal = (errorCode: string, status = 403) =>
|
||||
new ApiError("refused", status, { errorCode });
|
||||
|
||||
it("reads the refusal by its code, not by the status", () => {
|
||||
expect(extractErrorMessage(refusal("consent.ai.required"), t)).toBe(
|
||||
"labs.ocr.consentRequired",
|
||||
);
|
||||
expect(
|
||||
extractErrorMessage(refusal("assistant.disabled.documentAi"), t),
|
||||
).toBe("labs.ocr.aiUnavailable");
|
||||
expect(extractErrorMessage(refusal("ai.record.notPermitted"), t)).toBe(
|
||||
"labs.ocr.aiUnavailable",
|
||||
);
|
||||
expect(extractErrorMessage(refusal("module.disabled"), t)).toBe(
|
||||
"labs.ocr.aiUnavailable",
|
||||
);
|
||||
expect(extractErrorMessage(refusal("ai.provider.none", 422), t)).toBe(
|
||||
"labs.ocr.providerUnsupported",
|
||||
);
|
||||
});
|
||||
|
||||
it("never calls an unrelated 403 a missing consent", () => {
|
||||
expect(extractErrorMessage(new ApiError("forbidden", 403), t)).toBe(
|
||||
"labs.ocr.extractFailed",
|
||||
);
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user