From 41eda2d163d7c7b4b43cf72a9467202a4c0680d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= Date: Fri, 5 Jun 2026 13:09:52 +0200 Subject: [PATCH] insights: reword the deferred chart-window stats note without a TODO marker --- src/components/insights/sub-page-shell.tsx | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/components/insights/sub-page-shell.tsx b/src/components/insights/sub-page-shell.tsx index 8066920c6..1b1d42925 100644 --- a/src/components/insights/sub-page-shell.tsx +++ b/src/components/insights/sub-page-shell.tsx @@ -262,14 +262,12 @@ export function SubPageShell({ brand-new-metric paths. Numbers-first is the Apple-Health / Withings / Oura detail-screen convention. - TODO(v1.12.7): chart-brush-reactive stats. When the user brushes / - selects a window in the chart below, recompute the stat strip's - Min/Max/Median/Mean for the visible domain. Deferred: the shared - `` (~1900 LOC, also driving the dashboard) has no - Recharts `` or lifted domain-change callback today, and its - range state lives internally; wiring a stable brush + lifting the - selected domain into this shell so both the chart and the strip read - it is a larger change than this release's scope warrants without + The stats describe the full range. Recomputing them for a window + the user brushes / selects in the chart below would mean lifting the + chart's domain into this shell so both the chart and the strip read + it — but the shared `` (also driving the dashboard) has + no Recharts `` or domain-change callback and keeps its range + state internal, so that wiring is left for a later release to avoid destabilising the chart. */} {statStrip} {/* v1.12.6 — the canonical spine body: intro (header) → stat strip