feat(ui): extract <Textarea> primitive with iOS-zoom + WCAG defences

Six textarea call-sites had been copy-pasting the same className with
the text-base sm:text-sm iOS-zoom defence; the audit flagged it as a
drift risk. New shadcn-style primitive in src/components/ui/textarea.tsx
mirrors <Input>'s shape and bakes in the defence, the WCAG 2.5.5 tap-
target floor (min-h-11 sm:min-h-9), autoCapitalize="sentences" /
spellCheck defaults for prose, and the autoComplete="off" + password-
manager ignore posture from <Input>.

Migrates four call-sites onto the primitive (bugreport, medications
JSON import, side-effect notes, admin feedback note) — saves ~16 LOC
of inline copy-paste and ~850 chars of repeated className strings.
The coach-input textarea stays as-is: it's an auto-grow composer with
a transparent bg wrapped in an outer "fake input" div, so migrating
would require nullifying nearly every primitive default.

11 new unit tests lock the contract (iOS zoom class, tap-target floor,
forwardRef sentinel, override semantics, attribute pass-through).
This commit is contained in:
Marc-André Bombeck committed 2026-05-22 08:54:49 +02:00
1 parent 8d0ae98afd
commit 3a241dbe35
7 files changed
+554 -315

No files matched your search

+7 -5
View File
@@ -6,6 +6,7 @@ import { useAuth } from "@/hooks/use-auth";
import { Button } from "@/components/ui/button";
import { Label } from "@/components/ui/label";
import { Input } from "@/components/ui/input";
import { Textarea } from "@/components/ui/textarea";
import {
Select,
SelectContent,
@@ -199,7 +200,7 @@ export default function BugReportPage() {
<div className="space-y-2">
<Label htmlFor="bug-desc">{t("bugreport.description")}</Label>
<textarea
<Textarea
id="bug-desc"
value={description}
onChange={(e) => setDescription(e.target.value)}
@@ -207,9 +208,6 @@ export default function BugReportPage() {
minLength={10}
maxLength={5000}
rows={8}
// text-base on mobile so iOS Safari doesn't zoom on
// focus; text-sm on sm+ keeps the compact desktop look.
className="border-input bg-background text-foreground placeholder:text-muted-foreground focus-visible:ring-ring w-full rounded-md border px-3 py-2 text-base focus-visible:ring-2 focus-visible:outline-none sm:text-sm"
/>
</div>
@@ -229,7 +227,11 @@ export default function BugReportPage() {
)}
<div className="flex items-center justify-end pt-2">
<Button type="submit" disabled={loading} aria-busy={loading || undefined}>
<Button
type="submit"
disabled={loading}
aria-busy={loading || undefined}
>
{/*
v1.4.33 IW9 — swap the icon on loading (Loader2 takes
the same 16x16 slot as the Bug icon) so the button
+49 -46
View File
@@ -37,6 +37,7 @@ import {
SelectTrigger,
SelectValue,
} from "@/components/ui/select";
import { Textarea } from "@/components/ui/textarea";
import {
MoreHorizontal,
Loader2,
@@ -279,48 +280,48 @@ export default function MedicationsPage() {
className="sm:max-w-lg"
footer={<div ref={setFooterEl} className="flex w-full" />}
>
<MedicationForm
footerSlot={footerEl}
initial={
editingMed
? {
id: editingMed.id,
name: editingMed.name,
dose: editingMed.dose,
category: editingMed.category,
// v1.4.25 W4d — pass through the Prisma treatment-class
// discriminator and the optional dosesPerUnit so the
// form preselects the GLP-1 surfaces correctly when
// editing an existing GLP-1 row.
treatmentClass: editingMed.treatmentClass,
dosesPerUnit: editingMed.dosesPerUnit ?? null,
active: editingMed.active,
notificationsEnabled: editingMed.notificationsEnabled,
schedules: editingMed.schedules.map((s) => ({
windowStart: s.windowStart,
windowEnd: s.windowEnd,
label: s.label ?? "",
dose: s.dose ?? "",
...parseScheduleRecurrence(s.daysOfWeek),
})),
}
: undefined
}
editActions={
editingMed
? {
onImportIntakes: () => setImportMedId(editingMed.id),
onApiAccess: () =>
setApiMed({
id: editingMed.id,
name: editingMed.name,
}),
}
: undefined
}
onSuccess={closeDialog}
onCancel={closeDialog}
/>
<MedicationForm
footerSlot={footerEl}
initial={
editingMed
? {
id: editingMed.id,
name: editingMed.name,
dose: editingMed.dose,
category: editingMed.category,
// v1.4.25 W4d — pass through the Prisma treatment-class
// discriminator and the optional dosesPerUnit so the
// form preselects the GLP-1 surfaces correctly when
// editing an existing GLP-1 row.
treatmentClass: editingMed.treatmentClass,
dosesPerUnit: editingMed.dosesPerUnit ?? null,
active: editingMed.active,
notificationsEnabled: editingMed.notificationsEnabled,
schedules: editingMed.schedules.map((s) => ({
windowStart: s.windowStart,
windowEnd: s.windowEnd,
label: s.label ?? "",
dose: s.dose ?? "",
...parseScheduleRecurrence(s.daysOfWeek),
})),
}
: undefined
}
editActions={
editingMed
? {
onImportIntakes: () => setImportMedId(editingMed.id),
onApiAccess: () =>
setApiMed({
id: editingMed.id,
name: editingMed.name,
}),
}
: undefined
}
onSuccess={closeDialog}
onCancel={closeDialog}
/>
</ResponsiveSheet>
</div>
);
@@ -465,14 +466,16 @@ function IntakeImportDialog({
{"datum": "2026-02-14", "uhrzeit": "23:33:42", "zaehler": 524}
]`}
</pre>
<textarea
<Textarea
value={jsonText}
onChange={(e) => setJsonText(e.target.value)}
placeholder={t("medications.importPaste")}
rows={8}
// text-base on mobile so iOS Safari doesn't zoom on
// focus; text-sm on sm+ for the compact import textarea.
className="border-input bg-background text-foreground placeholder:text-muted-foreground focus-visible:ring-ring w-full rounded-md border px-3 py-2 font-mono text-base focus-visible:ring-2 focus-visible:outline-none sm:text-sm"
// JSON paste — disable sentence-case and spell-check so the
// primitive defaults don't munge structured input.
autoCapitalize="none"
spellCheck={false}
className="font-mono"
/>
{result && (
<p