fix(02-12): keep scoped record polls dormant

- suppress whole-record achievements reads for narrowed grants\n- stabilize record journey response assertions
This commit is contained in:
Marc-André Bombeck committed 2026-08-06 08:34:02 +02:00
1 parent e568caa2f1
commit 358bb39465
4 files changed
+38 -17

No files matched your search

@@ -26,7 +26,10 @@ import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
import type { ReactNode } from "react";
import { I18nProvider } from "@/lib/i18n/context";
import { useAchievementsQuery } from "../use-achievements-query";
import {
canFetchAchievements,
useAchievementsQuery,
} from "../use-achievements-query";
vi.mock("@/hooks/use-auth", () => ({
useAuth: () => ({ isAuthenticated: true }),
@@ -90,6 +93,13 @@ function withQueryClient(node: ReactNode): string {
}
describe("useAchievementsQuery — consumer collapse", () => {
it("does not start the whole-record poll in a narrowed shared record", () => {
expect(canFetchAchievements({ sections: ["profile"] })).toBe(false);
expect(canFetchAchievements({ sections: [] })).toBe(false);
expect(canFetchAchievements({ sections: null })).toBe(true);
expect(canFetchAchievements(null)).toBe(true);
});
it("fires a single network call when three consumers mount together", async () => {
withQueryClient(
<>
+15 -2
View File
@@ -5,6 +5,7 @@ import { useQuery, type UseQueryResult } from "@tanstack/react-query";
import { useAuth } from "@/hooks/use-auth";
import { apiGet } from "@/lib/api/api-fetch";
import { queryKeys } from "@/lib/query-keys";
import type { AccountAccessEntry } from "@/lib/sharing/account-access-view";
import type {
AchievementMetrics,
AchievementProgress,
@@ -70,6 +71,17 @@ function fetchAchievements(): Promise<AchievementsPayload> {
return apiGet<AchievementsPayload>("/api/gamification/achievements");
}
/**
* Achievements aggregate more than one record section, so a narrowed grant
* never reaches the endpoint. Keep its shell-level poll dormant instead of
* turning a correctly refused background read into an apparent grant loss.
*/
export function canFetchAchievements(
active: Pick<AccountAccessEntry, "sections"> | null | undefined,
): boolean {
return active === null || active === undefined || active.sections === null;
}
/**
* Shared hook. Returns the unwrapped `data` payload typed as
* `AchievementsPayload`. Consumers narrow at the call site.
@@ -77,9 +89,10 @@ function fetchAchievements(): Promise<AchievementsPayload> {
export function useAchievementsQuery(
options: UseAchievementsQueryOptions = {},
): UseQueryResult<AchievementsPayload, Error> {
const { isAuthenticated } = useAuth();
const { isAuthenticated, user } = useAuth();
const enabled =
options.enabled !== undefined ? options.enabled : isAuthenticated;
(options.enabled !== undefined ? options.enabled : isAuthenticated) &&
canFetchAchievements(user?.accountAccess?.active);
const refetchInterval = options.refetchInterval ?? false;
return useQuery({