fix(onboarding): never switch a module off on a record that already uses it

The derivation wrote an explicit off for every module the answers did not
name, which is right for a record being set up and wrong for one with years of
rows behind it. An established self-hoster has, for most modules, no stored
preference at all — they were default-on and nobody ever touched the toggle —
so the first confirm took away the navigation entry, the dashboard widget and
the settings entry for domains full of content. The rows survived; the
surfaces did not.

A derived off now asks first, and only for the modules it would actually
retract. Ownership is not re-answered: the measurement domains come from the
same map the MCP reads and the coach snapshot gates off, and each remaining
module names the one table its content lives in, exhaustively, so a module
added later fails to compile until somebody says where its content is. A
module whose domain holds rows keeps whatever the record already had, because
absence is what "on" looks like in the stored map.
This commit is contained in:
Marc-André Bombeck committed 2026-09-10 11:48:27 +02:00
1 parent cc6e6ca221
commit 2d2350252f
6 files changed
+372 -5

No files matched your search

@@ -24,6 +24,9 @@ import {
type OnboardingModuleNeeds,
} from "../registry";
/** A record with nothing in it — the state a first setup describes. */
const NO_DATA: ReadonlySet<string> = new Set();
function needs(
overrides: Partial<OnboardingModuleNeeds> = {},
): OnboardingModuleNeeds {
@@ -174,6 +177,7 @@ describe("mergeDerivedModulePreferences", () => {
const merged = mergeDerivedModulePreferences(
{ mcp: true, labs: true },
preferences,
NO_DATA,
);
expect(merged.mcp).toBe(true);
expect(merged.labs).toBe(true);
@@ -181,7 +185,7 @@ describe("mergeDerivedModulePreferences", () => {
it("does turn off a module the record only had by default", () => {
const { preferences } = deriveOnboardingModuleDefaults(needs());
const merged = mergeDerivedModulePreferences({}, preferences);
const merged = mergeDerivedModulePreferences({}, preferences, NO_DATA);
expect(merged.labs).toBe(false);
expect(merged.workouts).toBe(false);
});
@@ -190,7 +194,11 @@ describe("mergeDerivedModulePreferences", () => {
const { preferences } = deriveOnboardingModuleDefaults(
needs({ areas: ["labs"] }),
);
const merged = mergeDerivedModulePreferences({ labs: false }, preferences);
const merged = mergeDerivedModulePreferences(
{ labs: false },
preferences,
NO_DATA,
);
expect(merged.labs).toBe(true);
});
@@ -199,16 +207,61 @@ describe("mergeDerivedModulePreferences", () => {
const merged = mergeDerivedModulePreferences(
{ weight: false, nonsense: true },
preferences,
NO_DATA,
);
expect(merged).not.toHaveProperty("weight");
expect(merged).not.toHaveProperty("nonsense");
});
it("never switches off a domain the record already holds rows in", () => {
const { preferences } = deriveOnboardingModuleDefaults(needs());
expect(preferences.labs).toBe(false);
expect(preferences.mood).toBe(false);
// An established record with no stored preference at all: default-on, and
// nobody ever touched the toggle. A derived `false` would take the nav
// entry, the dashboard widget and the settings entry away from a domain
// holding years of rows, so the key is left exactly as it was — and
// absence means on.
const merged = mergeDerivedModulePreferences(
{},
preferences,
new Set(["labs", "mood"]),
);
expect(merged).not.toHaveProperty("labs");
expect(merged).not.toHaveProperty("mood");
expect(merged.workouts).toBe(false);
});
it("keeps a stored explicit off where the domain holds rows", () => {
const { preferences } = deriveOnboardingModuleDefaults(needs());
// Somebody switched labs off by hand and still has old results. The flow
// must not switch it back on, and must not restate the decision either.
const merged = mergeDerivedModulePreferences(
{ labs: false },
preferences,
new Set(["labs"]),
);
expect(merged.labs).toBe(false);
});
it("still switches a domain ON when the answers name it, rows or not", () => {
const { preferences } = deriveOnboardingModuleDefaults(
needs({ areas: ["labs"] }),
);
const merged = mergeDerivedModulePreferences(
{},
preferences,
new Set(["labs"]),
);
expect(merged.labs).toBe(true);
});
it("leaves the two delegated keys alone in both directions", () => {
const { preferences } = deriveOnboardingModuleDefaults(
needs({ areas: ["cycle"] }),
);
const merged = mergeDerivedModulePreferences({}, preferences);
const merged = mergeDerivedModulePreferences({}, preferences, NO_DATA);
expect(merged).not.toHaveProperty("cycle");
expect(merged).not.toHaveProperty("coach");
});