Merge work/coach-read-locale

This commit is contained in:
Marc-André Bombeck committed 2026-07-31 11:48:21 +02:00
commit 2d01b9846d
43 files changed
+1636 -169

No files matched your search

+10 -2
View File
@@ -286,7 +286,11 @@ describe("discoverPhaseCorrelations", () => {
),
);
}
const result = discoverPhaseCorrelations({ phaseByDay, measurements });
const result = discoverPhaseCorrelations({
phaseByDay,
measurements,
locale: "en",
});
const pair = result.discovered.find(
(p) => p.behaviour === CYCLE_PHASE_CHANNEL_KEY,
);
@@ -315,7 +319,11 @@ describe("discoverPhaseCorrelations", () => {
phaseByDay.set(key, phases[i % phases.length]);
measurements.push(m("RESTING_HEART_RATE", key, 60)); // constant → no variance
}
const result = discoverPhaseCorrelations({ phaseByDay, measurements });
const result = discoverPhaseCorrelations({
phaseByDay,
measurements,
locale: "en",
});
expect(result.discovered).toEqual([]);
});
});
+10 -2
View File
@@ -51,6 +51,7 @@ import {
import { round } from "@/lib/insights/status-shared";
import type { MeasurementType } from "@/generated/prisma/enums";
import type { CyclePhase } from "@/lib/cycle/types";
import type { Locale } from "@/lib/i18n/config";
/** Stable channel key for the continuous CYCLE_PHASE discovery series. */
export const CYCLE_PHASE_CHANNEL_KEY = "CYCLE_PHASE";
@@ -292,8 +293,15 @@ export function discoverPhaseCorrelations(args: {
phaseByDay: Map<string, CyclePhase>;
measurements: CrossMetricMeasurement[];
userPriorityJson?: unknown;
/**
* The reader's locale. Each surviving row carries a finished `interpretation`
* sentence that the cycle route serves straight to the client, so it has to
* be written in the reader's language. Required — no default, because a
* default is what let the metric page's driver line ship in English.
*/
locale: Locale;
}): CorrelationDiscoveryResult {
const { phaseByDay, measurements } = args;
const { phaseByDay, measurements, locale } = args;
const userPriorityJson = args.userPriorityJson ?? null;
const phaseSeries = buildPhaseDiscoverySeries(phaseByDay);
@@ -307,7 +315,7 @@ export function discoverPhaseCorrelations(args: {
outcomeSeries.push({ key: cfg.type, role: "outcome", points });
}
return discoverCorrelations([phaseSeries, ...outcomeSeries]);
return discoverCorrelations([phaseSeries, ...outcomeSeries], { locale });
}
/**