mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-18 16:12:11 +00:00
refactor(settings): remove the preview-feature opt-ins
The per-account preview switch was kept for the topic overview pages, which were dropped before they shipped. Its one flag was stored, served and backed up, and read by nothing; the column-reader audit listed it as a pending consumer that will not come. Removed completely: - `/api/settings/preview-features` (GET, PATCH) is retired: it answers 410 Gone with `meta.errorCode: route.retired` and `removedIn: 1.46.0`, and the contract publishes it under Retired. The route, its validation schema, the `PreviewFeatures` OpenAPI schemas and the settings module are deleted. - Migration 0485 drops `users.preview_features_json` under a bounded lock wait, with the retry marker. - The backup no longer writes the field. A file from v1.44 or v1.45 that carries it still restores: the schema accepts it and no codec reads it, so nothing is refused or written for it. The backup-parity goldens lose the field and apply one setting fewer. - The data-wipe plan entry and the sharing-surface actor entry go with the route (frozen count 273 -> 272). No client build reads the route: neither iOS repository nor any local checkout references it.
This commit is contained in:
1 parent
f3b9329fb2
commit
2ae23f4ca8
26 files changed
+125
-437
No files matched your search
@@ -1,26 +0,0 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
import {
|
||||
DEFAULT_PREVIEW_FEATURES,
|
||||
resolvePreviewFeatures,
|
||||
} from "../preview-features";
|
||||
|
||||
describe("resolvePreviewFeatures", () => {
|
||||
it("is all off by default", () => {
|
||||
expect(DEFAULT_PREVIEW_FEATURES).toEqual({ topics: false });
|
||||
expect(resolvePreviewFeatures(null)).toEqual({ topics: false });
|
||||
});
|
||||
|
||||
it("reads a flag only on an explicit true", () => {
|
||||
expect(resolvePreviewFeatures({ topics: true })).toEqual({ topics: true });
|
||||
expect(resolvePreviewFeatures({ topics: "true" })).toEqual({
|
||||
topics: false,
|
||||
});
|
||||
});
|
||||
|
||||
it("drops unknown keys", () => {
|
||||
expect(resolvePreviewFeatures({ topics: true, retired: true })).toEqual({
|
||||
topics: true,
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -1,33 +0,0 @@
|
||||
/**
|
||||
* Per-user opt-in to preview features, persisted in `User.previewFeaturesJson`.
|
||||
*
|
||||
* One boolean per flag, every flag off by default. A preview feature is
|
||||
* something finished enough to try and not yet the default; switching one on
|
||||
* adds it beside what is there and never replaces an existing page.
|
||||
*
|
||||
* Flags:
|
||||
* - `topics`: topic overview pages above the single-metric Insights pages.
|
||||
* Stored, served by `/api/settings/preview-features` and carried by the
|
||||
* backup. The Settings > System switch is not listed until the topic pages
|
||||
* ship, because nothing reads the flag yet.
|
||||
*
|
||||
* Unknown keys in a stored blob are dropped on read, so a flag retired later
|
||||
* disappears cleanly and a malformed blob reads as everything off.
|
||||
*/
|
||||
|
||||
export const PREVIEW_FEATURE_KEYS = ["topics"] as const;
|
||||
export type PreviewFeatureKey = (typeof PREVIEW_FEATURE_KEYS)[number];
|
||||
|
||||
export type PreviewFeatures = Record<PreviewFeatureKey, boolean>;
|
||||
|
||||
export const DEFAULT_PREVIEW_FEATURES: PreviewFeatures = { topics: false };
|
||||
|
||||
export function resolvePreviewFeatures(raw: unknown): PreviewFeatures {
|
||||
const out: PreviewFeatures = { ...DEFAULT_PREVIEW_FEATURES };
|
||||
if (raw === null || raw === undefined || typeof raw !== "object") return out;
|
||||
const blob = raw as Record<string, unknown>;
|
||||
for (const key of PREVIEW_FEATURE_KEYS) {
|
||||
if (blob[key] === true) out[key] = true;
|
||||
}
|
||||
return out;
|
||||
}
|
||||
@@ -114,10 +114,6 @@ export const SETTINGS_SECTION_SLUGS = [
|
||||
// pieces into one coherent privacy pane. Sits next to `advanced` (the
|
||||
// destructive-action home) and before `about`.
|
||||
"privacy",
|
||||
// v1.44 — "Preview features" (per-user opt-ins, Settings > System) is not
|
||||
// listed until the first preview it switches, the topic pages, ships: a
|
||||
// switch that changes nothing is a promise the page cannot keep. The stored
|
||||
// flag, `/api/settings/preview-features` and its backup round-trip stay.
|
||||
"about",
|
||||
] as const;
|
||||
|
||||
|
||||
Reference in new issue
Block a user