mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-15 23:12:04 +00:00
feat(daily): let the Today rail dismiss milestone / ECG / tension cards
The worth-a-look rail mixed actionable items (an overdue dose, a broken sync) with observational ones (a milestone, a new ECG pointer, a tension window) that have nothing to act on beyond "seen it" — there was no way to clear them short of them expiring on their own. Add server-side dismissal scoped to the three observational kinds only: a new DismissedPriorityItem table (userId + itemKey, composite-unique), a POST /api/daily/digest/dismiss route, and a deterministic itemKey the digest builder stamps per kind (metric + reach day for a milestone, the recording's own timestamp for an ECG, the local day + part of day for a tension window) so a dismissal never bleeds into a later day's instance. The actionable kinds never carry an itemKey, so the dismiss affordance and the endpoint are both structurally unreachable for them — an itemKey not namespaced under a dismissible kind 422s before any lookup.
This commit is contained in:
1 parent
4f198ec25f
commit
270f33edb2
17 files changed
+903
-9
No files matched your search
@@ -0,0 +1,164 @@
|
||||
/**
|
||||
* `POST /api/daily/digest/dismiss` — the Today rail dismiss surface.
|
||||
*
|
||||
* Under test: cookie/Bearer auth narrows the user, the `insights` module gate
|
||||
* returns a 403 `module.disabled` envelope when off, an `itemKey` that isn't
|
||||
* namespaced under a dismissible kind 422s BEFORE any DB write, and the happy
|
||||
* path upserts the `DismissedPriorityItem` row scoped to the caller.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach } from "vitest";
|
||||
import { NextRequest } from "next/server";
|
||||
|
||||
vi.mock("@/lib/db", () => ({
|
||||
prisma: {
|
||||
dismissedPriorityItem: {
|
||||
upsert: vi.fn().mockResolvedValue({}),
|
||||
},
|
||||
},
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/modules/gate", () => ({
|
||||
requireModuleEnabled: vi.fn(async () => ({ enabled: true })),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/rate-limit", () => ({
|
||||
checkRateLimit: vi.fn(async () => ({
|
||||
allowed: true,
|
||||
remaining: 39,
|
||||
resetAt: Date.now() + 60_000,
|
||||
})),
|
||||
rateLimitHeaders: vi.fn(() => ({})),
|
||||
}));
|
||||
|
||||
vi.mock("@/lib/auth/session", () => ({ getSession: vi.fn() }));
|
||||
vi.mock("@/lib/auth/audit", () => ({
|
||||
auditLog: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
vi.mock("@/lib/logging/transports", () => ({ emitIfSampled: vi.fn() }));
|
||||
vi.mock("@/lib/db-compat", () => ({
|
||||
ensureDbCompatibility: vi.fn().mockResolvedValue(undefined),
|
||||
}));
|
||||
vi.mock("@/lib/logging/context", async (importOriginal) => {
|
||||
const actual = await importOriginal<typeof import("@/lib/logging/context")>();
|
||||
return { ...actual, annotate: vi.fn() };
|
||||
});
|
||||
vi.mock("next/headers", () => ({
|
||||
headers: vi.fn(async () => ({ get: () => null })),
|
||||
cookies: vi.fn(async () => ({
|
||||
get: () => undefined,
|
||||
set: () => {},
|
||||
delete: () => {},
|
||||
})),
|
||||
}));
|
||||
|
||||
import { POST } from "../route";
|
||||
import { prisma } from "@/lib/db";
|
||||
import { getSession } from "@/lib/auth/session";
|
||||
import { requireModuleEnabled } from "@/lib/modules/gate";
|
||||
import { apiError } from "@/lib/api-response";
|
||||
|
||||
const SESSION_OK = {
|
||||
session: { id: "sess-1", expiresAt: new Date(Date.now() + 3_600_000) },
|
||||
user: {
|
||||
id: "user-1",
|
||||
username: "tester",
|
||||
role: "USER" as const,
|
||||
locale: "en",
|
||||
},
|
||||
};
|
||||
|
||||
const callPost = POST as unknown as (req: NextRequest) => Promise<Response>;
|
||||
function makeReq(body: unknown): NextRequest {
|
||||
return new NextRequest(new URL("http://localhost/api/daily/digest/dismiss"), {
|
||||
method: "POST",
|
||||
headers: { "content-type": "application/json" },
|
||||
body: JSON.stringify(body),
|
||||
});
|
||||
}
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
vi.mocked(getSession).mockResolvedValue(SESSION_OK as never);
|
||||
vi.mocked(requireModuleEnabled).mockResolvedValue({ enabled: true });
|
||||
});
|
||||
|
||||
describe("POST /api/daily/digest/dismiss", () => {
|
||||
it("returns 401 when unauthenticated", async () => {
|
||||
vi.mocked(getSession).mockResolvedValue(null as never);
|
||||
const res = await callPost(
|
||||
makeReq({ itemKey: "milestone:record_first:WEIGHT:2026-07-16" }),
|
||||
);
|
||||
expect(res.status).toBe(401);
|
||||
expect(prisma.dismissedPriorityItem.upsert).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("returns the 403 module.disabled envelope when insights is off", async () => {
|
||||
vi.mocked(requireModuleEnabled).mockResolvedValue({
|
||||
enabled: false,
|
||||
response: apiError('Module "insights" is not enabled', 403, {
|
||||
errorCode: "module.disabled",
|
||||
module: "insights",
|
||||
}),
|
||||
});
|
||||
const res = await callPost(
|
||||
makeReq({ itemKey: "milestone:record_first:WEIGHT:2026-07-16" }),
|
||||
);
|
||||
expect(res.status).toBe(403);
|
||||
expect(prisma.dismissedPriorityItem.upsert).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("422s an itemKey that isn't namespaced under a dismissible kind — an actionable item can never be dismissed", async () => {
|
||||
const res = await callPost(makeReq({ itemKey: "dose_window:anything" }));
|
||||
expect(res.status).toBe(422);
|
||||
expect(prisma.dismissedPriorityItem.upsert).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("422s a missing itemKey", async () => {
|
||||
const res = await callPost(makeReq({}));
|
||||
expect(res.status).toBe(422);
|
||||
});
|
||||
|
||||
it("422s an unknown extra field (strict schema)", async () => {
|
||||
const res = await callPost(
|
||||
makeReq({
|
||||
itemKey: "milestone:record_first:WEIGHT:2026-07-16",
|
||||
userId: "someone-else",
|
||||
}),
|
||||
);
|
||||
expect(res.status).toBe(422);
|
||||
expect(prisma.dismissedPriorityItem.upsert).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("upserts the dismissal scoped to the caller, for each dismissible kind", async () => {
|
||||
for (const itemKey of [
|
||||
"milestone:record_first:WEIGHT:2026-07-16",
|
||||
"ecg_new_recording:2026-07-16T08:00:00.000Z",
|
||||
"tension_window:2026-07-16:afternoon",
|
||||
]) {
|
||||
vi.mocked(prisma.dismissedPriorityItem.upsert).mockClear();
|
||||
const res = await callPost(makeReq({ itemKey }));
|
||||
expect(res.status).toBe(200);
|
||||
const body = await res.json();
|
||||
expect(body.data).toEqual({ dismissed: true });
|
||||
expect(prisma.dismissedPriorityItem.upsert).toHaveBeenCalledWith({
|
||||
where: { userId_itemKey: { userId: "user-1", itemKey } },
|
||||
update: {},
|
||||
create: { userId: "user-1", itemKey },
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
it("returns 429 when the caller's dismiss rate limit is exhausted", async () => {
|
||||
const { checkRateLimit } = await import("@/lib/rate-limit");
|
||||
vi.mocked(checkRateLimit).mockResolvedValueOnce({
|
||||
allowed: false,
|
||||
remaining: 0,
|
||||
resetAt: Date.now() + 60_000,
|
||||
});
|
||||
const res = await callPost(
|
||||
makeReq({ itemKey: "milestone:record_first:WEIGHT:2026-07-16" }),
|
||||
);
|
||||
expect(res.status).toBe(429);
|
||||
expect(prisma.dismissedPriorityItem.upsert).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,82 @@
|
||||
/**
|
||||
* POST /api/daily/digest/dismiss
|
||||
*
|
||||
* "Dismiss / mark seen" for the Today rail's OBSERVATIONAL `PriorityItem`
|
||||
* kinds only — `milestone`, `ecg_new_recording`, `tension_window`. The
|
||||
* ACTIONABLE kinds (`dose_window`, `sync_issue`, `preventive_care`,
|
||||
* `coach_checkin`) are never reachable here: `dismissPriorityItemSchema`
|
||||
* rejects any `itemKey` that doesn't carry one of the three dismissible
|
||||
* kind-prefixes before a lookup ever runs (§`isDismissibleItemKey`).
|
||||
*
|
||||
* Persisted server-side (`DismissedPriorityItem`, composite-unique on
|
||||
* `userId` + `itemKey`) so the dismissal survives reload / a second device —
|
||||
* an upsert, so a repeat dismiss of the same instance is a no-op rather than
|
||||
* a conflict. `userId` is narrowed from `requireAuth()` only; the body never
|
||||
* carries one. Cookie OR Bearer, mirroring the digest GET route's own auth
|
||||
* policy, and gated on the same `insights` module (the daily rail's host
|
||||
* surface).
|
||||
*/
|
||||
import type { NextRequest } from "next/server";
|
||||
|
||||
import { apiHandler, requireAuth } from "@/lib/api-handler";
|
||||
import {
|
||||
apiError,
|
||||
apiSuccess,
|
||||
returnAllZodIssues,
|
||||
safeJson,
|
||||
} from "@/lib/api-response";
|
||||
import { annotate } from "@/lib/logging/context";
|
||||
import { prisma } from "@/lib/db";
|
||||
import { requireModuleEnabled } from "@/lib/modules/gate";
|
||||
import { checkRateLimit, rateLimitHeaders } from "@/lib/rate-limit";
|
||||
import { dismissPriorityItemSchema } from "@/lib/validations/daily";
|
||||
|
||||
export const dynamic = "force-dynamic";
|
||||
|
||||
// A cheap, owner-scoped upsert; the limit only caps a runaway client loop.
|
||||
const DISMISS_RATE_LIMIT = 40;
|
||||
const DISMISS_WINDOW_MS = 60_000;
|
||||
|
||||
export const POST = apiHandler(async (req: NextRequest) => {
|
||||
const { user } = await requireAuth();
|
||||
const gate = await requireModuleEnabled(user.id, "insights");
|
||||
if (!gate.enabled) return gate.response;
|
||||
|
||||
const rl = await checkRateLimit(
|
||||
`daily-digest-dismiss:${user.id}`,
|
||||
DISMISS_RATE_LIMIT,
|
||||
DISMISS_WINDOW_MS,
|
||||
);
|
||||
if (!rl.allowed) {
|
||||
const response = apiError("Too many requests", 429);
|
||||
for (const [k, v] of Object.entries(rateLimitHeaders(rl))) {
|
||||
response.headers.set(k, v);
|
||||
}
|
||||
return response;
|
||||
}
|
||||
|
||||
const { data: body, error: jsonError } = await safeJson(req, {
|
||||
maxBytes: 1024,
|
||||
});
|
||||
if (jsonError) return jsonError;
|
||||
|
||||
const parsed = dismissPriorityItemSchema.safeParse(body);
|
||||
if (!parsed.success) {
|
||||
return returnAllZodIssues(parsed.error, 422);
|
||||
}
|
||||
|
||||
const { itemKey } = parsed.data;
|
||||
|
||||
await prisma.dismissedPriorityItem.upsert({
|
||||
where: { userId_itemKey: { userId: user.id, itemKey } },
|
||||
update: {},
|
||||
create: { userId: user.id, itemKey },
|
||||
});
|
||||
|
||||
annotate({
|
||||
action: { name: "daily.digest.item.dismissed" },
|
||||
meta: { daily_digest_item_kind: itemKey.split(":")[0] },
|
||||
});
|
||||
|
||||
return apiSuccess({ dismissed: true });
|
||||
});
|
||||
Reference in new issue
Block a user