mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-17 07:42:23 +00:00
fix(ui): close consistency-audit contrast and duplication findings
Today hero's top-signal delta used opacity-on-muted text, landing below AA on the app's most prominent card; five mood charts and the sleep- stage IN_BED fill painted raw --dracula-*/hardcoded-hex hues with no (or an unused) light-theme counterpart. Route all of them through existing semantic/chart tokens instead (destructive/warning/success, chart-1..5, and a newly minted --chart-inbed with its own Alucard override) so every hue is AA-tuned per theme. Also collapses three duplicated primitives the audit flagged: the click-Popover VitalsInfoTip and hover-Tooltip InfoHint merge into one touch-first ui/info-popover; MedicationViewToggle and ModuleViewToggle were verbatim copy-paste and now wrap one shared ui/view-toggle; the triplicated sport-icon map (already drifted — mixedCardio rendered a different glyph in the list vs the detail/dashboard views) moves to lib/workouts/sport-icons.ts with HeartPulse as the settled icon. Adds a no-restricted-imports lint rule banning direct recharts imports outside the chart-runtime barrel, catching the bundle-duplication mistake at local lint instead of PR-CI.
This commit is contained in:
1 parent
1ff179178f
commit
247bc4f33c
25 files changed
+401
-400
No files matched your search
@@ -16,7 +16,7 @@ import { SectionHeading } from "@/components/insights/section-heading";
|
||||
import { SparklineDeltaTile } from "./sparkline-delta-tile";
|
||||
import { LearnMoreLink } from "@/components/ui/learn-more-link";
|
||||
import { CoverageMeter } from "./coverage-meter";
|
||||
import { VitalsInfoTip } from "./vitals-info-tip";
|
||||
import { InfoPopover } from "@/components/ui/info-popover";
|
||||
import { METRIC_PROVENANCE } from "./standards";
|
||||
import { type DerivedBatchRead } from "./use-derived-metric";
|
||||
import {
|
||||
@@ -171,11 +171,11 @@ function tileOrder(layout: InsightsLayout | undefined, tileId: string): number {
|
||||
|
||||
/**
|
||||
* The (i) info-tip trigger for one derived metric, wired from the map.
|
||||
* `provenance` (inputs / source / window / asOf) isn't rendered here —
|
||||
* `VitalsInfoTip` carries only the method/caveat + cited standard, mirroring
|
||||
* what `ProvenanceExplainer` itself renders today — but the param is kept so
|
||||
* every call site (which already reads `data.provenance` off the derived
|
||||
* batch) doesn't need touching if a future pass restores the detail.
|
||||
* `provenance` (inputs / source / window / asOf) isn't rendered here — the
|
||||
* shared `InfoPopover` carries only the method/caveat + cited standard,
|
||||
* mirroring what `ProvenanceExplainer` itself renders today — but the param
|
||||
* is kept so every call site (which already reads `data.provenance` off the
|
||||
* derived batch) doesn't need touching if a future pass restores the detail.
|
||||
*/
|
||||
function MetricProvenance({
|
||||
metric,
|
||||
@@ -195,7 +195,13 @@ function MetricProvenance({
|
||||
{t(meta.methodKey)}
|
||||
</>
|
||||
);
|
||||
return <VitalsInfoTip method={method} standard={meta.standard} />;
|
||||
return (
|
||||
<InfoPopover
|
||||
content={method}
|
||||
link={meta.standard}
|
||||
label={t("insights.derived.vitals.infoLabel")}
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
||||
interface TileProps {
|
||||
@@ -291,7 +297,7 @@ function BaselineTile({
|
||||
// v1.29.1 muted this on VITALS_BASELINE tiles because the always-on
|
||||
// "typical range = median ± MAD" caption repeated across every vital
|
||||
// baseline tile and read as clutter. v1.29.2 restores the context —
|
||||
// now behind the compact (i) trigger (`VitalsInfoTip`) instead of a
|
||||
// now behind the compact (i) trigger (`InfoPopover`) instead of a
|
||||
// full-width caption, so every baseline tile carries it again
|
||||
// without the repetition or the header-row squeeze that clipped the
|
||||
// cardio-fitness heading.
|
||||
|
||||
@@ -1,90 +0,0 @@
|
||||
"use client";
|
||||
|
||||
import { useState } from "react";
|
||||
import { Info } from "lucide-react";
|
||||
|
||||
import {
|
||||
Popover,
|
||||
PopoverContent,
|
||||
PopoverTrigger,
|
||||
} from "@/components/ui/popover";
|
||||
import { useTranslations } from "@/lib/i18n/context";
|
||||
import { cn } from "@/lib/utils";
|
||||
import type { ProvenanceStandard } from "./provenance-explainer";
|
||||
|
||||
/**
|
||||
* v1.29.2 QoL — the vitals-dashboard tile's (i) info affordance.
|
||||
*
|
||||
* v1.29.1 dropped the always-on "your personal normal range is the
|
||||
* median…" method caption from every `VITALS_BASELINE` tile because it
|
||||
* repeated verbatim across up to six tiles and read as clutter at the top
|
||||
* of the vitals surface — and, on the narrower tiles, squeezed the heading
|
||||
* itself (the VO₂max/cardio-fitness clip). Rather than reintroduce the
|
||||
* caption at full length, the SAME method/caveat/standard content moves
|
||||
* behind a small (i) trigger: a click-opened `Popover` (not a hover
|
||||
* tooltip — the vitals grid sees most of its use on touch), so the context
|
||||
* is one tap away instead of permanently occupying header space.
|
||||
*
|
||||
* This is a DELIBERATE, narrowly-scoped exception to the v1.22 "no
|
||||
* icon-only disclosure" direction (`ProvenanceExplainer`'s own docstring):
|
||||
* that decision targeted the always-visible-caption pattern on OTHER
|
||||
* surfaces (coincident-deviation, the score-anatomy pages), which stay
|
||||
* unchanged. The vitals grid is dense enough, and the caption repetitive
|
||||
* enough, that the same content is better one tap away here.
|
||||
*/
|
||||
export interface VitalsInfoTipProps {
|
||||
/** Plain-language method (+ optional caveat) description — text children only. */
|
||||
method: React.ReactNode;
|
||||
/** Optional cited standard, rendered as a plain external link. */
|
||||
standard?: ProvenanceStandard;
|
||||
className?: string;
|
||||
}
|
||||
|
||||
export function VitalsInfoTip({
|
||||
method,
|
||||
standard,
|
||||
className,
|
||||
}: VitalsInfoTipProps) {
|
||||
const { t } = useTranslations();
|
||||
const [open, setOpen] = useState(false);
|
||||
|
||||
return (
|
||||
<Popover open={open} onOpenChange={setOpen}>
|
||||
<PopoverTrigger asChild>
|
||||
<button
|
||||
type="button"
|
||||
data-slot="vitals-info-trigger"
|
||||
aria-label={t("insights.derived.vitals.infoLabel")}
|
||||
aria-expanded={open}
|
||||
className={cn(
|
||||
"text-muted-foreground hover:text-foreground focus-visible:ring-ring/50",
|
||||
"inline-flex min-h-11 min-w-11 shrink-0 items-center justify-center rounded-full",
|
||||
"-mx-2 -my-3",
|
||||
"transition-colors focus-visible:ring-2 focus-visible:outline-none",
|
||||
className,
|
||||
)}
|
||||
>
|
||||
<Info className="h-3.5 w-3.5" aria-hidden="true" />
|
||||
</button>
|
||||
</PopoverTrigger>
|
||||
<PopoverContent
|
||||
data-slot="vitals-info-body"
|
||||
align="end"
|
||||
sideOffset={6}
|
||||
className="max-w-xs space-y-1.5"
|
||||
>
|
||||
<p className="text-muted-foreground text-xs leading-snug">{method}</p>
|
||||
{standard ? (
|
||||
<a
|
||||
href={standard.url}
|
||||
target="_blank"
|
||||
rel="noopener noreferrer"
|
||||
className="text-primary block text-xs leading-snug hover:underline"
|
||||
>
|
||||
{standard.name}
|
||||
</a>
|
||||
) : null}
|
||||
</PopoverContent>
|
||||
</Popover>
|
||||
);
|
||||
}
|
||||
Reference in new issue
Block a user