mirror of
https://github.com/MBombeck/HealthLog.git
synced 2026-11-19 08:12:52 +00:00
fix(timeline): open on everything when the default window is empty
Opened without a zoom, three months that hold nothing while the record has older entries now show everything instead of a dead end, without writing the zoom into the URL. A window named in the URL that is empty offers "Show everything" when the record has entries before it. An unreadable ?zoom= or range opens on the same default as no zoom.
This commit is contained in:
1 parent
a4cccc11ba
commit
23e0cc35af
7 files changed
+300
-21
No files matched your search
@@ -79,6 +79,35 @@ test("opens on three months when the URL names no zoom", async ({ page }) => {
|
||||
await setTimelineModule(page, false);
|
||||
});
|
||||
|
||||
test("only old data opens on everything, and an empty window offers it", async ({
|
||||
page,
|
||||
}) => {
|
||||
await setTimelineModuleOn(page);
|
||||
const log = await mockTimeline(page, "full", TODAY, { onlyOld: true });
|
||||
await page.goto("/timeline");
|
||||
// The default three months hold nothing: the page opens on everything,
|
||||
// without writing it into the URL.
|
||||
await expect(
|
||||
page.locator('[data-slot="timeline-zoom"] [data-value="all"]'),
|
||||
).toHaveAttribute("aria-checked", "true", { timeout: 20_000 });
|
||||
await expect(page.locator('[data-slot="timeline-chart"]')).toBeVisible();
|
||||
await expect(page).toHaveURL(/\/timeline$/);
|
||||
expect(log.timelineQueries.map((q) => q.get("zoom"))).toEqual(
|
||||
expect.arrayContaining(["quarter", "all"]),
|
||||
);
|
||||
|
||||
// Three months asked for by name stay three months, and offer the rest.
|
||||
await page.goto("/timeline?zoom=quarter");
|
||||
const empty = page.locator('[data-slot="timeline-window-empty"]');
|
||||
await expect(empty).toBeVisible({ timeout: 20_000 });
|
||||
await page.locator('[data-slot="timeline-show-everything"]').click();
|
||||
await expect(page).toHaveURL(/zoom=all/);
|
||||
await expect(page.locator('[data-slot="timeline-chart"]')).toBeVisible();
|
||||
|
||||
// The next test starts from the module switched off.
|
||||
await setTimelineModule(page, false);
|
||||
});
|
||||
|
||||
test("switching it on opens the readiness inventory, which leads to the timeline", async ({
|
||||
page,
|
||||
}) => {
|
||||
|
||||
@@ -822,11 +822,16 @@ export interface TimelineMockLog {
|
||||
/**
|
||||
* Answer the timeline routes from the `full` or `ready` record. Returns a
|
||||
* log of what the page asked for and posted, for assertions.
|
||||
*
|
||||
* `onlyOld`: the record's entries all lie before the last year, so a
|
||||
* quarter or year window answers empty (with the record's `dataFrom`) and
|
||||
* only everything, or a chosen range, carries them.
|
||||
*/
|
||||
export async function mockTimeline(
|
||||
page: Page,
|
||||
state: "full" | "ready",
|
||||
today: string,
|
||||
options: { onlyOld?: boolean } = {},
|
||||
): Promise<TimelineMockLog> {
|
||||
const log: TimelineMockLog = { timelineQueries: [], lifeEventPosts: [] };
|
||||
await page.route(/\/api\/timeline\/readiness(\?|$)/, (route) =>
|
||||
@@ -844,6 +849,17 @@ export async function mockTimeline(
|
||||
const to = url.searchParams.get("to");
|
||||
const bucket = bucketFor(zoom, from, to);
|
||||
const dataFrom = state === "full" ? "2019-01-01" : "2024-05-01";
|
||||
if (options.onlyOld && (zoom === "quarter" || zoom === "year")) {
|
||||
return json(route, 200, {
|
||||
...body,
|
||||
zoom,
|
||||
bucket,
|
||||
range: { from, to, dataFrom },
|
||||
lanes: body.lanes.map((lane) => ({ ...lane, items: [] })),
|
||||
standing: [],
|
||||
series: values.map((key) => ({ key, unit: null, points: [] })),
|
||||
});
|
||||
}
|
||||
// A chosen range answers its own window, as the server does.
|
||||
const chosen = zoom === "range" && from && to;
|
||||
const all =
|
||||
|
||||
Reference in new issue
Block a user