Merge the day picker, Coach new-chat button, day panel on /coach and text cleanup into release/v1.42.0

src/lib/validations/__tests__/notification-prefs.test.ts

@@ -109,7 +109,6 @@ describe("parseNotificationPrefs", () => {
         nudgeVitals: true,
         nudgeRoutine: true,
         nudgeFrequency: "weekly",
-        ambientSuggestions: true,
         nudgeAiComposed: false,
       },
       measurementReminder: {
@@ -134,7 +133,6 @@ describe("parseNotificationPrefs", () => {
         nudgeVitals: true,
         nudgeRoutine: true,
         nudgeFrequency: "weekly",
-        ambientSuggestions: true,
         nudgeAiComposed: false,
       },
       measurementReminder: {
@@ -161,7 +159,6 @@ describe("parseNotificationPrefs", () => {
         nudgeVitals: true,
         nudgeRoutine: true,
         nudgeFrequency: "weekly",
-        ambientSuggestions: true,
         nudgeAiComposed: false,
       },
       measurementReminder: {
@@ -204,7 +201,6 @@ describe("resolveNotificationPrefs (deep-merge)", () => {
         nudgeVitals: true,
         nudgeRoutine: true,
         nudgeFrequency: "weekly",
-        ambientSuggestions: true,
         nudgeAiComposed: false,
       },
       measurementReminder: {
@@ -235,7 +231,6 @@ describe("resolveNotificationPrefs (deep-merge)", () => {
         nudgeVitals: true,
         nudgeRoutine: true,
         nudgeFrequency: "weekly",
-        ambientSuggestions: true,
         nudgeAiComposed: false,
       },
       measurementReminder: {
@@ -263,7 +258,6 @@ describe("resolveNotificationPrefs (deep-merge)", () => {
         nudgeVitals: true,
         nudgeRoutine: true,
         nudgeFrequency: "weekly",
-        ambientSuggestions: true,
         nudgeAiComposed: false,
       },
       measurementReminder: {
@@ -291,7 +285,6 @@ describe("resolveNotificationPrefs (deep-merge)", () => {
         nudgeVitals: true,
         nudgeRoutine: true,
         nudgeFrequency: "weekly",
-        ambientSuggestions: true,
         nudgeAiComposed: false,
       },
       measurementReminder: {
@@ -320,7 +313,6 @@ describe("resolveNotificationPrefs (deep-merge)", () => {
         nudgeVitals: true,
         nudgeRoutine: true,
         nudgeFrequency: "weekly",
-        ambientSuggestions: true,
         nudgeAiComposed: false,
       },
       measurementReminder: {

src/lib/validations/notification-prefs.ts

@@ -125,14 +125,6 @@ const coachPrefsSchema = z
     nudgeRoutine: z.boolean(),
     /** v1.16.5 — frequency cap: one nudge per 7 or per 14 days. */
     nudgeFrequency: z.enum(["weekly", "biweekly"]),
-    /**
-     * v1.25.0 — opt-out for the proactive ambient SUGGESTIONS surfaced in the
-     * UI (the daily seeded example opener on the Coach hero + the "try asking"
-     * prompt chips). Default ON. Separate from `nudgesEnabled` (the push-nudge
-     * master switch) so a user can keep the nudges but silence the example
-     * prompts, or vice versa.
-     */
-    ambientSuggestions: z.boolean(),
     /**
      * v1.25.0 — opt-IN for AI-composed nudge copy. Default OFF: the proactive
      * nudge ships a deterministic warm localized template, and that template is
@@ -219,11 +211,6 @@ export interface NotificationPrefs {
     nudgeRoutine: boolean;
     /** v1.16.5 — cap interval: "weekly" (7 d) or "biweekly" (14 d). */
     nudgeFrequency: "weekly" | "biweekly";
-    /**
-     * v1.25.0 — proactive ambient example suggestions in the UI (seeded
-     * opener + suggested-prompt chips). Default `true`.
-     */
-    ambientSuggestions: boolean;
     /**
      * v1.25.0 — opt-in for AI-composed nudge copy. Default `false`; the
      * deterministic template stays the default + fail-closed fallback.
@@ -285,7 +272,6 @@ export const DEFAULT_NOTIFICATION_PREFS: NotificationPrefs = {
     nudgeVitals: true,
     nudgeRoutine: true,
     nudgeFrequency: "weekly",
-    ambientSuggestions: true,
     nudgeAiComposed: false,
   },
   measurementReminder: {
@@ -483,16 +469,6 @@ export interface CoachNudgePrefs {
   aiComposed: boolean;
 }
 
-/**
- * v1.25.0 — the single source every proactive ambient SUGGESTION surface
- * consults (the daily seeded example opener on the Coach hero + the
- * suggested-prompt chips). Default `true`; a null / drifted row resolves to
- * the documented default so the suggestions work out of the box.
- */
-export function resolveCoachAmbientSuggestionsEnabled(raw: unknown): boolean {
-  return parseNotificationPrefs(raw).coach.ambientSuggestions;
-}
-
 export function resolveCoachNudgePrefs(raw: unknown): CoachNudgePrefs {
   const coach = parseNotificationPrefs(raw).coach;
   return {