refactor: simplify-pass apply-yes cleanup

Five independent atomic edits from the W5 simplify review, grouped
in a single commit since none pull weight as a compound theme:

- coach-input: collapse `!disabled && value.trim().length > 0`
  triplication onto a single `canSubmit` (S-01).
- hero-strip: extract the duplicate weekly-report Button shell into
  a shared label fragment with the Link wrapping conditionally
  (S-02).
- api-token-overview-section: extract `<TokenStatusBadge size>` so
  the desktop table and mobile card list stay in lock-step on the
  revoked / expired / active 3-way ternary (S-03).
- trends-row: hoist the dynamic-load chart skeleton to a shared
  `ChartSkeleton` component (S-04). No chart-visual change —
  placeholder only.
- correlation-row: collapse the grid className ternary onto `cn()`
  with a conditional `md:grid-cols-2` (S-05).

Test count unchanged (2105).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Marc-André BombeckandClaude Opus 4.7 committed 2026-05-10 22:17:29 +02:00
1 parent 65a8b5a8b6
commit 1631d8042c
5 files changed
+98 -92

No files matched your search

@@ -55,6 +55,46 @@ function TruncatedCell({
);
}
/**
* v1.4.22 W5 reconcile (S-03) — the revoked / isExpired / active
* 3-way ternary is identical between the desktop table and the
* mobile card list; the only difference is `text-xs` vs `text-[10px]`.
* Centralise so the two surfaces stay in lock-step.
*/
function TokenStatusBadge({
token,
size,
}: {
token: ApiTokenInfo;
size: "sm" | "xs";
}) {
const { t } = useTranslations();
const expired =
token.expiresAt != null && new Date(token.expiresAt) < new Date();
const sizeClass = size === "xs" ? "text-[10px]" : "text-xs";
if (token.revoked) {
return (
<Badge variant="destructive" className={`shrink-0 ${sizeClass}`}>
{t("settings.tokenRevoked")}
</Badge>
);
}
if (expired) {
return (
<Badge variant="destructive" className={`shrink-0 ${sizeClass}`}>
{t("settings.tokenExpired")}
</Badge>
);
}
return (
<Badge
className={`bg-dracula-green/15 text-dracula-green shrink-0 ${sizeClass}`}
>
{t("common.active")}
</Badge>
);
}
/**
* F-18 (v1.4.19): the auto-login flow names tokens
* "web auto-login 2026-05-05T19:46:20.603Z" / "iOS auto-login …" by
@@ -181,8 +221,6 @@ export function ApiTokenOverviewSection() {
</thead>
<tbody className="divide-border divide-y">
{tokens.map((token, i) => {
const isExpired =
token.expiresAt && new Date(token.expiresAt) < new Date();
return (
<tr
key={token.id}
@@ -213,19 +251,7 @@ export function ApiTokenOverviewSection() {
</div>
</td>
<td className="px-3 py-2 text-right">
{token.revoked ? (
<Badge variant="destructive" className="text-xs">
{t("settings.tokenRevoked")}
</Badge>
) : isExpired ? (
<Badge variant="destructive" className="text-xs">
{t("settings.tokenExpired")}
</Badge>
) : (
<Badge className="bg-dracula-green/15 text-dracula-green text-xs">
{t("common.active")}
</Badge>
)}
<TokenStatusBadge token={token} size="sm" />
</td>
{/* v1.4.22 C2 (5th attempt) — drop
`whitespace-nowrap` on the date cells. The
@@ -264,8 +290,6 @@ export function ApiTokenOverviewSection() {
data-testid="admin-tokens-mobile-list"
>
{tokens.map((token) => {
const isExpired =
token.expiresAt && new Date(token.expiresAt) < new Date();
return (
<li
key={token.id}
@@ -278,25 +302,7 @@ export function ApiTokenOverviewSection() {
value={formatTokenName(token.name)}
className="min-w-0 flex-1 font-medium"
/>
{token.revoked ? (
<Badge
variant="destructive"
className="shrink-0 text-[10px]"
>
{t("settings.tokenRevoked")}
</Badge>
) : isExpired ? (
<Badge
variant="destructive"
className="shrink-0 text-[10px]"
>
{t("settings.tokenExpired")}
</Badge>
) : (
<Badge className="bg-dracula-green/15 text-dracula-green shrink-0 text-[10px]">
{t("common.active")}
</Badge>
)}
<TokenStatusBadge token={token} size="xs" />
</div>
<TruncatedCell
value={token.user.username}