From 11cd7fbeb637758d21d3875b7584403fcf10cc21 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc-Andr=C3=A9=20Bombeck?= <mbombeck@gmail.com>
Date: Thu, 22 Oct 2026 02:31:56 +0200
Subject: [PATCH] fix(integrations): name a managed profile without a display
 name by its username

The connect cards read the display name alone, so a profile created without
one rendered "Connect for" with nobody after it. Use the account label the
switcher and the banner use.
---
 .../managed-integration-status.test.tsx       | 27 ++++++++++++++-----
 .../settings/managed-integration-status.tsx   | 10 +++----
 2 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/src/components/settings/__tests__/managed-integration-status.test.tsx b/src/components/settings/__tests__/managed-integration-status.test.tsx
index f782d0d55..d7126b5dd 100644
--- a/src/components/settings/__tests__/managed-integration-status.test.tsx
+++ b/src/components/settings/__tests__/managed-integration-status.test.tsx
@@ -7,17 +7,19 @@ import { renderToStaticMarkup } from "react-dom/server";
 
 import type { ConnectionHealth } from "@/lib/integrations/connection-health";
 
+const NAMED_RECORD = {
+  accountId: "record-1",
+  recordKind: "managed",
+  username: "managed-1",
+  displayName: "Managed record" as string | null,
+  fullName: null as string | null,
+};
+let activeRecord = NAMED_RECORD;
 vi.mock("@/hooks/use-auth", () => ({
   useAuth: () => ({
     user: {
       id: "guardian",
-      accountAccess: {
-        active: {
-          accountId: "record-1",
-          recordKind: "managed",
-          displayName: "Managed record",
-        },
-      },
+      accountAccess: { active: activeRecord },
     },
     isAuthenticated: true,
     isLoading: false,
@@ -78,6 +80,7 @@ describe("<ManagedIntegrationStatus>", () => {
   beforeEach(() => {
     payload = undefined;
     loading = false;
+    activeRecord = NAMED_RECORD;
   });
 
   it("renders one shared card per provider from health, with controls on the OAuth ones", () => {
@@ -140,6 +143,16 @@ describe("<ManagedIntegrationStatus>", () => {
     );
   });
 
+  it("names a profile without a display name by its username", () => {
+    activeRecord = { ...NAMED_RECORD, displayName: null };
+    payload = withHealth({});
+    const html = render();
+    expect(html.match(/Connects for managed-1</g)).toHaveLength(6);
+    expect(html.match(/>Connect for managed-1</g)).toHaveLength(6);
+    expect(html).not.toMatch(/Connects? for </);
+    expect(html).toContain('aria-label="managed-1"');
+  });
+
   it("paints the cards while loading without claiming a state", () => {
     loading = true;
     const html = render();
diff --git a/src/components/settings/managed-integration-status.tsx b/src/components/settings/managed-integration-status.tsx
index 4ce08a958..6f84aa551 100644
--- a/src/components/settings/managed-integration-status.tsx
+++ b/src/components/settings/managed-integration-status.tsx
@@ -28,6 +28,7 @@ import {
   queryKeys,
 } from "@/lib/query-keys";
 import { assertRecordSettingsResponseForRecord } from "@/lib/record-settings/response";
+import { accountLabel } from "@/lib/sharing/account-access-view";
 
 type ManagedIntegrationKey = keyof typeof INTEGRATION_DISPLAY_NAMES;
 
@@ -90,7 +91,9 @@ export function ManagedIntegrationStatus() {
     enabled: activeRecord?.recordKind === "managed" && recordId !== null,
   });
 
-  const recordName = activeRecord?.displayName ?? "";
+  // Named the way the switcher and the banner name it: a profile created
+  // without a display name still has a name to connect for.
+  const recordName = activeRecord ? accountLabel(activeRecord) : "";
 
   const invalidateStatus = () =>
     queryClient.invalidateQueries({
@@ -248,10 +251,7 @@ export function ManagedIntegrationStatus() {
           <ExternalLink className="size-3" aria-hidden="true" />
         </a>
       </p>
-      <ul
-        className="space-y-4"
-        aria-label={activeRecord?.displayName ?? undefined}
-      >
+      <ul className="space-y-4" aria-label={recordName || undefined}>
         {entries.map((entry) => (
           <li key={entry.integration}>
             <IntegrationCard