fix(insights): drop the question-mark explainer circle from the heading

The round `?` popover next to each category heading read as restless
beside the title and duplicated copy already shown inline. Remove the
`MetricExplainer` trigger entirely; the static one- to two-sentence
definition stays as the muted caption directly beneath the heading, so
the definition is still always visible without a tap. The bundle keeps
the per-metric Title leaf for stable key pairs even though only the Body
caption now renders.
This commit is contained in:
Marc-André Bombeck committed 2026-06-01 22:50:59 +02:00
1 parent e5b873833a
commit 0e9fa7bf80
3 files changed
+10 -278

No files matched your search

@@ -5,14 +5,20 @@ import { join } from "node:path";
/**
* v1.8.0 — explainer-metric key guard.
*
* `<MetricExplainer>` builds its i18n lookups from a template literal:
* The sub-page shell builds its i18n lookup from a template literal off
* the `explainerMetric` prop:
*
* t(`insights.subPage.explainer.${metric}Title`)
* t(`insights.subPage.explainer.${metric}Body`)
* t(`insights.subPage.explainer.${metric}Body`) // inline definition
*
* v1.8.6 — the round `?` popover that also read the `<metric>Title` leaf
* is gone; the shell now renders only the inline `Body` caption. The
* `Title` leaf is still pinned here so the bundle keeps a stable, fully
* populated key pair per metric (the locale-integrity guard propagates
* it across the other five locales).
*
* The static `i18n-call-site-coverage.test.ts` only sees literal
* `t("…")` calls, so a typo in an `explainerMetric=` prop would resolve
* to a missing key and paint the raw key string into the popover — with
* to a missing key and paint the raw key string under the heading — with
* no CI signal. This test closes that gap the same way the
* Health-Score provenance key tests pin their dynamic keys: it walks
* every `explainerMetric="…"` value used under `src/app/insights/**`